From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: johan.hedberg@gmail.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Bluetooth: Ignore A2MP data on non-BR/EDR links
Date: Wed, 16 Oct 2013 11:54:47 +0300 [thread overview]
Message-ID: <20131016085445.GL2861@aemeltch-MOBL1> (raw)
In-Reply-To: <1381912621-10238-1-git-send-email-johan.hedberg@gmail.com>
Hi Johan,
On Wed, Oct 16, 2013 at 11:37:00AM +0300, johan.hedberg@gmail.com wrote:
> From: Johan Hedberg <johan.hedberg@intel.com>
>
> The A2MP CID is only valid for BR/EDR transports. We should ignore A2MP
> data on non-BR/EDR links and refuse to create an amp_mgr object.
>
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
> net/bluetooth/a2mp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/bluetooth/a2mp.c b/net/bluetooth/a2mp.c
> index fe32a33..efcd108 100644
> --- a/net/bluetooth/a2mp.c
> +++ b/net/bluetooth/a2mp.c
> @@ -836,6 +836,9 @@ struct l2cap_chan *a2mp_channel_create(struct l2cap_conn *conn,
> {
> struct amp_mgr *mgr;
>
> + if (conn->hcon->type != ACL_LINK)
> + return NULL;
> +
Have you experienced this ever happened?
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2013-10-16 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 8:37 [PATCH 1/2] Bluetooth: Ignore A2MP data on non-BR/EDR links johan.hedberg
2013-10-16 8:37 ` [PATCH 2/2] Bluetooth: Ignore SMP data on non-LE links johan.hedberg
2013-10-16 8:42 ` Marcel Holtmann
2013-10-16 8:42 ` [PATCH 1/2] Bluetooth: Ignore A2MP data on non-BR/EDR links Marcel Holtmann
2013-10-16 8:54 ` Andrei Emeltchenko [this message]
2013-10-16 9:10 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016085445.GL2861@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox