From: Gianluca Anzolin <gianluca@sottospazio.it>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Alexander Holler <holler@ahsoftware.de>,
"Gustavo F. Padovan" <gustavo@padovan.org>,
peter@hurleysoftware.com,
"linux-bluetooth@vger.kernel.org development"
<linux-bluetooth@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
jslaby@suse.cz, stable@vger.kernel.org
Subject: Re: [PATCH v3 0/4] Regression fixes for rfcomm/tty.c
Date: Tue, 28 Jan 2014 09:31:54 +0100 [thread overview]
Message-ID: <20140128083154.GA29060@sottospazio.it> (raw)
In-Reply-To: <E0DDC796-EECF-46B6-8EDF-801CF8EFD456@holtmann.org>
On Mon, Jan 20, 2014 at 09:37:14AM -0800, Marcel Holtmann wrote:
> Hi Alexander,
>
> >> all 4 patches have been applied to bluetooth-next tree.
> >
> > Maybe a bit late, but I've just seen they miss a Cc: stable@vger.kernel.org to automatically end up in 3.12 and 3.13 too.
>
> we can always promote them to stable. On Purpose I wanted them to cycle through bluetooth-next for a while to make sure they do not cause any other regressions.
>
> Regards
>
> Marcel
>
Unfortunately it seems I overlooked the fact that rfcomm_dev_activate() is
called with the port->mutex held. So patches 2/3/4 cause a regression I missed
because I didn't turn on the appropriate debug options (circular locking
dependency, a bug report already appeared on this list).
I'm afraid this all stems from my partial knowledge of the tty_port code and
unfortunately I don't know how to solve the problem right now.
I think it's better to revert those patches for the moment.
Regards,
Gianluca
next prev parent reply other threads:[~2014-01-28 8:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 20:23 [PATCH v3 0/4] Regression fixes for rfcomm/tty.c Gianluca Anzolin
2014-01-06 20:23 ` [PATCH v3 1/4] rfcomm: release the port when the last user closes the tty Gianluca Anzolin
2014-01-06 20:23 ` [PATCH v3 2/4] rfcomm: move rfcomm_get_device() before rfcomm_dev_activate() Gianluca Anzolin
2014-01-06 20:23 ` [PATCH v3 3/4] rfcomm: always wait for a bt connection on open() Gianluca Anzolin
2014-01-06 20:23 ` [PATCH v3 4/4] rfcomm: remove rfcomm_carrier_raised() Gianluca Anzolin
2014-01-06 21:57 ` [PATCH v3 0/4] Regression fixes for rfcomm/tty.c Marcel Holtmann
2014-01-20 8:34 ` Alexander Holler
2014-01-20 17:37 ` Marcel Holtmann
2014-01-28 8:31 ` Gianluca Anzolin [this message]
2014-01-28 12:08 ` Marcel Holtmann
2014-01-30 13:09 ` Alexander Holler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140128083154.GA29060@sottospazio.it \
--to=gianluca@sottospazio.it \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@padovan.org \
--cc=holler@ahsoftware.de \
--cc=jslaby@suse.cz \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=peter@hurleysoftware.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox