From: Alexander Holler <holler@ahsoftware.de>
To: Gianluca Anzolin <gianluca@sottospazio.it>,
Marcel Holtmann <marcel@holtmann.org>
Cc: "Gustavo F. Padovan" <gustavo@padovan.org>,
peter@hurleysoftware.com,
"linux-bluetooth@vger.kernel.org development"
<linux-bluetooth@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
jslaby@suse.cz, stable@vger.kernel.org
Subject: Re: [PATCH v3 0/4] Regression fixes for rfcomm/tty.c
Date: Thu, 30 Jan 2014 14:09:09 +0100 [thread overview]
Message-ID: <52EA4EF5.5000007@ahsoftware.de> (raw)
In-Reply-To: <20140128083154.GA29060@sottospazio.it>
Am 28.01.2014 09:31, schrieb Gianluca Anzolin:
> Unfortunately it seems I overlooked the fact that rfcomm_dev_activate() is
> called with the port->mutex held. So patches 2/3/4 cause a regression I missed
> because I didn't turn on the appropriate debug options (circular locking
> dependency, a bug report already appeared on this list).
>
> I'm afraid this all stems from my partial knowledge of the tty_port code and
> unfortunately I don't know how to solve the problem right now.
Understandable, it's like a mine field. ;) Maybe it might make sense to
add Alan Cox to Cc, I think he's active again and knows a lot about
tty_port.
> I think it's better to revert those patches for the moment.
I prefer to still use those patches because without them, I have a more
serious problem (at least for my use cases, which happily haven't run
into that deadlock).
But thanks for notifying me/us about the possibility of a deadlock when
using your patches.
Regards,
Alexander Holler
prev parent reply other threads:[~2014-01-30 13:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 20:23 [PATCH v3 0/4] Regression fixes for rfcomm/tty.c Gianluca Anzolin
2014-01-06 20:23 ` [PATCH v3 1/4] rfcomm: release the port when the last user closes the tty Gianluca Anzolin
2014-01-06 20:23 ` [PATCH v3 2/4] rfcomm: move rfcomm_get_device() before rfcomm_dev_activate() Gianluca Anzolin
2014-01-06 20:23 ` [PATCH v3 3/4] rfcomm: always wait for a bt connection on open() Gianluca Anzolin
2014-01-06 20:23 ` [PATCH v3 4/4] rfcomm: remove rfcomm_carrier_raised() Gianluca Anzolin
2014-01-06 21:57 ` [PATCH v3 0/4] Regression fixes for rfcomm/tty.c Marcel Holtmann
2014-01-20 8:34 ` Alexander Holler
2014-01-20 17:37 ` Marcel Holtmann
2014-01-28 8:31 ` Gianluca Anzolin
2014-01-28 12:08 ` Marcel Holtmann
2014-01-30 13:09 ` Alexander Holler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EA4EF5.5000007@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=gianluca@sottospazio.it \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@padovan.org \
--cc=jslaby@suse.cz \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=peter@hurleysoftware.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox