From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] tools: Fix using uninitialized value
Date: Mon, 3 Mar 2014 16:55:16 +0200 [thread overview]
Message-ID: <20140303145516.GA16395@localhost.P-661HNU-F1> (raw)
In-Reply-To: <1393838024-18439-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
On Mon, Mar 03, 2014, Andrei Emeltchenko wrote:
> Fixes warning:
> tools/ibeacon.c:150:14: warning: The left expression of the compound
> assignment is an uninitialized value. The computed value will also be
> garbage
> cmd.data[2] |= 0x02; /* LE General Discoverable Mode
> */
> ~~~~~~~~~~~ ^
> 1 warning generated.
> ---
> tools/ibeacon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/ibeacon.c b/tools/ibeacon.c
> index 458f9e7..2071c6b 100644
> --- a/tools/ibeacon.c
> +++ b/tools/ibeacon.c
> @@ -147,7 +147,7 @@ static void adv_tx_power_callback(const void *data, uint8_t size,
>
> cmd.data[0] = 0x02; /* Field length */
> cmd.data[1] = 0x01; /* Flags */
> - cmd.data[2] |= 0x02; /* LE General Discoverable Mode */
> + cmd.data[2] = 0x02; /* LE General Discoverable Mode */
> cmd.data[2] |= 0x04; /* BR/EDR Not Supported */
>
> cmd.data[3] = 0x1a; /* Field length */
Applied. Thanks.
Johan
next prev parent reply other threads:[~2014-03-03 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 9:13 [PATCH] tools: Fix using uninitialized value Andrei Emeltchenko
2014-03-03 14:55 ` Johan Hedberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-25 10:19 Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140303145516.GA16395@localhost.P-661HNU-F1 \
--to=johan.hedberg@gmail.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox