* [PATCH] tools: Fix using uninitialized value
@ 2014-03-03 9:13 Andrei Emeltchenko
2014-03-03 14:55 ` Johan Hedberg
0 siblings, 1 reply; 3+ messages in thread
From: Andrei Emeltchenko @ 2014-03-03 9:13 UTC (permalink / raw)
To: linux-bluetooth
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Fixes warning:
tools/ibeacon.c:150:14: warning: The left expression of the compound
assignment is an uninitialized value. The computed value will also be
garbage
cmd.data[2] |= 0x02; /* LE General Discoverable Mode
*/
~~~~~~~~~~~ ^
1 warning generated.
---
tools/ibeacon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/ibeacon.c b/tools/ibeacon.c
index 458f9e7..2071c6b 100644
--- a/tools/ibeacon.c
+++ b/tools/ibeacon.c
@@ -147,7 +147,7 @@ static void adv_tx_power_callback(const void *data, uint8_t size,
cmd.data[0] = 0x02; /* Field length */
cmd.data[1] = 0x01; /* Flags */
- cmd.data[2] |= 0x02; /* LE General Discoverable Mode */
+ cmd.data[2] = 0x02; /* LE General Discoverable Mode */
cmd.data[2] |= 0x04; /* BR/EDR Not Supported */
cmd.data[3] = 0x1a; /* Field length */
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tools: Fix using uninitialized value
2014-03-03 9:13 [PATCH] tools: Fix using uninitialized value Andrei Emeltchenko
@ 2014-03-03 14:55 ` Johan Hedberg
0 siblings, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2014-03-03 14:55 UTC (permalink / raw)
To: Andrei Emeltchenko; +Cc: linux-bluetooth
Hi Andrei,
On Mon, Mar 03, 2014, Andrei Emeltchenko wrote:
> Fixes warning:
> tools/ibeacon.c:150:14: warning: The left expression of the compound
> assignment is an uninitialized value. The computed value will also be
> garbage
> cmd.data[2] |= 0x02; /* LE General Discoverable Mode
> */
> ~~~~~~~~~~~ ^
> 1 warning generated.
> ---
> tools/ibeacon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/ibeacon.c b/tools/ibeacon.c
> index 458f9e7..2071c6b 100644
> --- a/tools/ibeacon.c
> +++ b/tools/ibeacon.c
> @@ -147,7 +147,7 @@ static void adv_tx_power_callback(const void *data, uint8_t size,
>
> cmd.data[0] = 0x02; /* Field length */
> cmd.data[1] = 0x01; /* Flags */
> - cmd.data[2] |= 0x02; /* LE General Discoverable Mode */
> + cmd.data[2] = 0x02; /* LE General Discoverable Mode */
> cmd.data[2] |= 0x04; /* BR/EDR Not Supported */
>
> cmd.data[3] = 0x1a; /* Field length */
Applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] tools: Fix using uninitialized value
@ 2014-02-25 10:19 Andrei Emeltchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andrei Emeltchenko @ 2014-02-25 10:19 UTC (permalink / raw)
To: linux-bluetooth
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Fixes warning:
tools/ibeacon.c:150:14: warning: The left expression of the compound
assignment is an uninitialized value. The computed value will also be
garbage
cmd.data[2] |= 0x02; /* LE General Discoverable Mode
*/
~~~~~~~~~~~ ^
1 warning generated.
---
tools/ibeacon.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/ibeacon.c b/tools/ibeacon.c
index 458f9e7..cd0ef65 100644
--- a/tools/ibeacon.c
+++ b/tools/ibeacon.c
@@ -145,6 +145,8 @@ static void adv_tx_power_callback(const void *data, uint8_t size,
return;
}
+ memset(&cmd, 0, sizeof(cmd));
+
cmd.data[0] = 0x02; /* Field length */
cmd.data[1] = 0x01; /* Flags */
cmd.data[2] |= 0x02; /* LE General Discoverable Mode */
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-03 14:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-03 9:13 [PATCH] tools: Fix using uninitialized value Andrei Emeltchenko
2014-03-03 14:55 ` Johan Hedberg
-- strict thread matches above, loose matches on Subject: below --
2014-02-25 10:19 Andrei Emeltchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox