Linux bluetooth development
 help / color / mirror / Atom feed
* [patch 12/16] bt: bluecard: Use del_timer_sync() in teardown path
       [not found] <20140323150557.288925975@linutronix.de>
  2014-03-23 15:09 ` [patch 13/16] bt: hci-bcsp: Use del_timer_sync() in teardown path Thomas Gleixner
@ 2014-03-23 15:09 ` Thomas Gleixner
  2014-03-23 17:30   ` Marcel Holtmann
  2014-03-23 15:09 ` [patch 14/16] bt: hci-h5: Use del_timer_sync() in exit path Thomas Gleixner
  2 siblings, 1 reply; 6+ messages in thread
From: Thomas Gleixner @ 2014-03-23 15:09 UTC (permalink / raw)
  To: LKML; +Cc: Julia Lawall, Andrew Morton, Marcel Holtmann, bt

Make sure no timer callback is running before releasing the
datastructure which contains it.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: bt <linux-bluetooth@vger.kernel.org>
---
 drivers/bluetooth/bluecard_cs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: tip/drivers/bluetooth/bluecard_cs.c
===================================================================
--- tip.orig/drivers/bluetooth/bluecard_cs.c
+++ tip/drivers/bluetooth/bluecard_cs.c
@@ -898,7 +898,7 @@ static void bluecard_release(struct pcmc
 
 	bluecard_close(info);
 
-	del_timer(&(info->timer));
+	del_timer_sync(&(info->timer));
 
 	pcmcia_disable_device(link);
 }

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [patch 13/16] bt: hci-bcsp: Use del_timer_sync() in teardown path
       [not found] <20140323150557.288925975@linutronix.de>
@ 2014-03-23 15:09 ` Thomas Gleixner
  2014-03-23 17:30   ` Marcel Holtmann
  2014-03-23 15:09 ` [patch 12/16] bt: bluecard: " Thomas Gleixner
  2014-03-23 15:09 ` [patch 14/16] bt: hci-h5: Use del_timer_sync() in exit path Thomas Gleixner
  2 siblings, 1 reply; 6+ messages in thread
From: Thomas Gleixner @ 2014-03-23 15:09 UTC (permalink / raw)
  To: LKML; +Cc: Julia Lawall, Andrew Morton, Marcel Holtmann, bt

Make sure no timer callback is running before freeing the
datastructure which contains it.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: bt <linux-bluetooth@vger.kernel.org>
---
 drivers/bluetooth/hci_bcsp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: tip/drivers/bluetooth/hci_bcsp.c
===================================================================
--- tip.orig/drivers/bluetooth/hci_bcsp.c
+++ tip/drivers/bluetooth/hci_bcsp.c
@@ -722,7 +722,7 @@ static int bcsp_close(struct hci_uart *h
 	skb_queue_purge(&bcsp->unack);
 	skb_queue_purge(&bcsp->rel);
 	skb_queue_purge(&bcsp->unrel);
-	del_timer(&bcsp->tbcsp);
+	del_timer_sync(&bcsp->tbcsp);
 
 	kfree(bcsp);
 	return 0;

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [patch 14/16] bt: hci-h5: Use del_timer_sync() in exit path
       [not found] <20140323150557.288925975@linutronix.de>
  2014-03-23 15:09 ` [patch 13/16] bt: hci-bcsp: Use del_timer_sync() in teardown path Thomas Gleixner
  2014-03-23 15:09 ` [patch 12/16] bt: bluecard: " Thomas Gleixner
@ 2014-03-23 15:09 ` Thomas Gleixner
  2014-03-23 17:30   ` Marcel Holtmann
  2 siblings, 1 reply; 6+ messages in thread
From: Thomas Gleixner @ 2014-03-23 15:09 UTC (permalink / raw)
  To: LKML; +Cc: Julia Lawall, Andrew Morton, Marcel Holtmann, bt

Make sure no timer callback is running before releasing the
datastructure which contains it.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: bt <linux-bluetooth@vger.kernel.org>
---
 drivers/bluetooth/hci_h5.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: tip/drivers/bluetooth/hci_h5.c
===================================================================
--- tip.orig/drivers/bluetooth/hci_h5.c
+++ tip/drivers/bluetooth/hci_h5.c
@@ -210,7 +210,7 @@ static int h5_close(struct hci_uart *hu)
 	skb_queue_purge(&h5->rel);
 	skb_queue_purge(&h5->unrel);
 
-	del_timer(&h5->timer);
+	del_timer_sync(&h5->timer);
 
 	kfree(h5);
 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [patch 14/16] bt: hci-h5: Use del_timer_sync() in exit path
  2014-03-23 15:09 ` [patch 14/16] bt: hci-h5: Use del_timer_sync() in exit path Thomas Gleixner
@ 2014-03-23 17:30   ` Marcel Holtmann
  0 siblings, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2014-03-23 17:30 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: LKML, Julia Lawall, Andrew Morton, bt

Hi Thomas,

> Make sure no timer callback is running before releasing the
> datastructure which contains it.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Cc: bt <linux-bluetooth@vger.kernel.org>
> ---
> drivers/bluetooth/hci_h5.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

we already fixed something similar in bluetooth-next tree. I think your patch is no longer needed.

Regards

Marcel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [patch 13/16] bt: hci-bcsp: Use del_timer_sync() in teardown path
  2014-03-23 15:09 ` [patch 13/16] bt: hci-bcsp: Use del_timer_sync() in teardown path Thomas Gleixner
@ 2014-03-23 17:30   ` Marcel Holtmann
  0 siblings, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2014-03-23 17:30 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: LKML, Julia Lawall, Andrew Morton, bt

Hi Thomas,

> Make sure no timer callback is running before freeing the
> datastructure which contains it.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Cc: bt <linux-bluetooth@vger.kernel.org>
> ---
> drivers/bluetooth/hci_bcsp.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

we already fixed something similar in bluetooth-next tree. I think your patch is no longer needed.

Regards

Marcel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [patch 12/16] bt: bluecard: Use del_timer_sync() in teardown path
  2014-03-23 15:09 ` [patch 12/16] bt: bluecard: " Thomas Gleixner
@ 2014-03-23 17:30   ` Marcel Holtmann
  0 siblings, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2014-03-23 17:30 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: LKML, Julia Lawall, Andrew Morton, bt

Hi Thomas,

> Make sure no timer callback is running before releasing the
> datastructure which contains it.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Cc: bt <linux-bluetooth@vger.kernel.org>
> ---
> drivers/bluetooth/bluecard_cs.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-03-23 17:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20140323150557.288925975@linutronix.de>
2014-03-23 15:09 ` [patch 13/16] bt: hci-bcsp: Use del_timer_sync() in teardown path Thomas Gleixner
2014-03-23 17:30   ` Marcel Holtmann
2014-03-23 15:09 ` [patch 12/16] bt: bluecard: " Thomas Gleixner
2014-03-23 17:30   ` Marcel Holtmann
2014-03-23 15:09 ` [patch 14/16] bt: hci-h5: Use del_timer_sync() in exit path Thomas Gleixner
2014-03-23 17:30   ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox