[PATCH] Bluetooth: Fix L2CAP LE debugfs entries permissions

Linux bluetooth development
 help / color / mirror / Atom feed

* [PATCH] Bluetooth: Fix L2CAP LE debugfs entries permissions
@ 2014-05-14 15:53 Samuel Ortiz
  2014-05-14 16:07 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: Samuel Ortiz @ 2014-05-14 15:53 UTC (permalink / raw)
  To: Marcel Holtmann, Gustavo Padovan, Johan Hedberg; +Cc: linux-bluetooth


0466 was probably meant to be 0644, there's no reason why everyone
except root could write there.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
---
 net/bluetooth/l2cap_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index a1e5bb7..dc4d301 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -7519,9 +7519,9 @@ int __init l2cap_init(void)
 	l2cap_debugfs = debugfs_create_file("l2cap", 0444, bt_debugfs,
 					    NULL, &l2cap_debugfs_fops);
 
-	debugfs_create_u16("l2cap_le_max_credits", 0466, bt_debugfs,
+	debugfs_create_u16("l2cap_le_max_credits", 0644, bt_debugfs,
 			   &le_max_credits);
-	debugfs_create_u16("l2cap_le_default_mps", 0466, bt_debugfs,
+	debugfs_create_u16("l2cap_le_default_mps", 0644, bt_debugfs,
 			   &le_default_mps);
 
 	bt_6lowpan_init();
-- 
2.0.0.rc0

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Bluetooth: Fix L2CAP LE debugfs entries permissions
  2014-05-14 15:53 [PATCH] Bluetooth: Fix L2CAP LE debugfs entries permissions Samuel Ortiz
@ 2014-05-14 16:07 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2014-05-14 16:07 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: Gustavo F. Padovan, Johan Hedberg, linux-bluetooth

Hi Samuel,

> 0466 was probably meant to be 0644, there's no reason why everyone
> except root could write there.
> 
> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
> ---
> net/bluetooth/l2cap_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

patch has been applied to bluetooth tree.

Gustavo, please make a pull request for 3.15 for this one. This is a security issue that we should address as quickly as possible.

Regards

Marcel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-14 16:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-14 15:53 [PATCH] Bluetooth: Fix L2CAP LE debugfs entries permissions Samuel Ortiz
2014-05-14 16:07 ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox