[PATCH] Bluetooth: Add missing COMPATIBLE_IOCTL for UART line discipline

[PATCH] Bluetooth: Add missing COMPATIBLE_IOCTL for UART line discipline

[Marcel Holtmann]

The HCIUARTGETDEVICE, HCIUARTSETFLAGS and HCIUARTGETFLAGS ioctl are
missing the COMPATIBLE_IOCTL declaration.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---
 fs/compat_ioctl.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
index a5b8eb69a8f4..6402eaf8ab95 100644
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -1261,6 +1261,9 @@ COMPATIBLE_IOCTL(HCIUNBLOCKADDR)
 COMPATIBLE_IOCTL(HCIINQUIRY)
 COMPATIBLE_IOCTL(HCIUARTSETPROTO)
 COMPATIBLE_IOCTL(HCIUARTGETPROTO)
+COMPATIBLE_IOCTL(HCIUARTGETDEVICE)
+COMPATIBLE_IOCTL(HCIUARTSETFLAGS)
+COMPATIBLE_IOCTL(HCIUARTGETFLAGS)
 COMPATIBLE_IOCTL(RFCOMMCREATEDEV)
 COMPATIBLE_IOCTL(RFCOMMRELEASEDEV)
 COMPATIBLE_IOCTL(RFCOMMGETDEVLIST)
-- 
2.5.0

Re: [PATCH] Bluetooth: Add missing COMPATIBLE_IOCTL for UART line discipline

[Johan Hedberg]

Hi Marcel,

On Mon, Jan 25, 2016, Marcel Holtmann wrote:
> The HCIUARTGETDEVICE, HCIUARTSETFLAGS and HCIUARTGETFLAGS ioctl are
> missing the COMPATIBLE_IOCTL declaration.
> 
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
>  fs/compat_ioctl.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied to bluetooth.git. Thanks.

Johan

Re: [PATCH] Bluetooth: Add missing COMPATIBLE_IOCTL for UART line discipline

[Jaap Jan Meijer]

Hi Johan,

Could you please also add
"[PATCH] Bluetooth: hci_ldisc: Add support for compat_ioctl handling"
to get proper ioctl compat functionality?

Many thanks in advance,

J.J.

2016-01-27 16:49 GMT+01:00 Johan Hedberg <johan.hedberg@gmail.com>:
> Hi Marcel,
>
> On Mon, Jan 25, 2016, Marcel Holtmann wrote:
>> The HCIUARTGETDEVICE, HCIUARTSETFLAGS and HCIUARTGETFLAGS ioctl are
>> missing the COMPATIBLE_IOCTL declaration.
>>
>> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
>> ---
>>  fs/compat_ioctl.c | 3 +++
>>  1 file changed, 3 insertions(+)
>
> Applied to bluetooth.git. Thanks.
>
> Johan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Bluetooth: Add missing COMPATIBLE_IOCTL for UART line discipline

[Marcel Holtmann]

Hi Jaap,

> Could you please also add
> "[PATCH] Bluetooth: hci_ldisc: Add support for compat_ioctl handling"
> to get proper ioctl compat functionality?
> 
> Many thanks in advance,

are you sure that is really needed? I do wonder why we need that. At least with COMPATIBLE_IOCTL the error message should actually change. Can you trace how far we get in the code path.

Regards

Marcel

Re: [PATCH] Bluetooth: Add missing COMPATIBLE_IOCTL for UART line discipline

[Jaap Jan Meijer]

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]

Hi Marcel,

At the moment I can only tell you that the error was the same without the
second patch.

But those might have bin incremental builds, I think. I will check again
with proper builds and see if I can get some debugging going.

Kind regards,

J.J.



Op vr 29 jan. 2016 11:44 schreef Marcel Holtmann <marcel@holtmann.org>:

> Hi Jaap,
>
> > Could you please also add
> > "[PATCH] Bluetooth: hci_ldisc: Add support for compat_ioctl handling"
> > to get proper ioctl compat functionality?
> >
> > Many thanks in advance,
>
> are you sure that is really needed? I do wonder why we need that. At least
> with COMPATIBLE_IOCTL the error message should actually change. Can you
> trace how far we get in the code path.
>
> Regards
>
> Marcel
>
>

[-- Attachment #2: Type: text/html, Size: 1213 bytes --]

Re: [PATCH] Bluetooth: Add missing COMPATIBLE_IOCTL for UART line discipline

[Jaap Jan Meijer]

Hi Marcel,

At the moment I can only tell you that the error was the same without
the second patch.

But those might have bin incremental builds, I think. I will check
again with proper builds and see if I can get some debugging going.

Kind regards,

J.J.

2016-01-29 11:44 GMT+01:00 Marcel Holtmann <marcel@holtmann.org>:
> Hi Jaap,
>
>> Could you please also add
>> "[PATCH] Bluetooth: hci_ldisc: Add support for compat_ioctl handling"
>> to get proper ioctl compat functionality?
>>
>> Many thanks in advance,
>
> are you sure that is really needed? I do wonder why we need that. At least with COMPATIBLE_IOCTL the error message should actually change. Can you trace how far we get in the code path.
>
> Regards
>
> Marcel
>

Re: [PATCH] Bluetooth: Add missing COMPATIBLE_IOCTL for UART line discipline

[Jaap Jan Meijer]

Hi Marcel,

After doing a proper build it indeed was not necessary to apply the
second patch. Sorry about that, lesson learned.


Regards,

J.J.

2016-01-29 11:44 GMT+01:00 Marcel Holtmann <marcel@holtmann.org>:
> Hi Jaap,
>
>> Could you please also add
>> "[PATCH] Bluetooth: hci_ldisc: Add support for compat_ioctl handling"
>> to get proper ioctl compat functionality?
>>
>> Many thanks in advance,
>
> are you sure that is really needed? I do wonder why we need that. At least with COMPATIBLE_IOCTL the error message should actually change. Can you trace how far we get in the code path.
>
> Regards
>
> Marcel
>