* bluez: avctp_connect_cb(): BT_IO_OPT_IMTU for omtu?
@ 2019-06-19 16:03 Pali Rohár
2019-07-03 10:39 ` Pali Rohár
0 siblings, 1 reply; 3+ messages in thread
From: Pali Rohár @ 2019-06-19 16:03 UTC (permalink / raw)
To: linux-bluetooth, Luiz Augusto von Dentz
[-- Attachment #1: Type: text/plain, Size: 508 bytes --]
Hello, in bluez source code is function avctp_connect_cb() with
following code:
bt_io_get(chan, &gerr,
BT_IO_OPT_DEST, &address,
BT_IO_OPT_IMTU, &imtu,
BT_IO_OPT_IMTU, &omtu,
BT_IO_OPT_INVALID);
Why is BT_IO_OPT_IMTU used for retrieving omtu? Should not be there
BT_IO_OPT_OMTU for retrieving omtu? Seems like a typo: imtu vs omtu.
Above code was introduced in commit b5666a3747 (AVCTP: Allocate memory
to hold incoming/outgoing PDUs).
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bluez: avctp_connect_cb(): BT_IO_OPT_IMTU for omtu?
2019-06-19 16:03 bluez: avctp_connect_cb(): BT_IO_OPT_IMTU for omtu? Pali Rohár
@ 2019-07-03 10:39 ` Pali Rohár
2019-07-03 12:44 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 3+ messages in thread
From: Pali Rohár @ 2019-07-03 10:39 UTC (permalink / raw)
To: linux-bluetooth, Luiz Augusto von Dentz
On Wednesday 19 June 2019 18:03:20 Pali Rohár wrote:
> Hello, in bluez source code is function avctp_connect_cb() with
> following code:
>
> bt_io_get(chan, &gerr,
> BT_IO_OPT_DEST, &address,
> BT_IO_OPT_IMTU, &imtu,
> BT_IO_OPT_IMTU, &omtu,
> BT_IO_OPT_INVALID);
>
> Why is BT_IO_OPT_IMTU used for retrieving omtu? Should not be there
> BT_IO_OPT_OMTU for retrieving omtu? Seems like a typo: imtu vs omtu.
>
> Above code was introduced in commit b5666a3747 (AVCTP: Allocate memory
> to hold incoming/outgoing PDUs).
Hello, I would like to remind this question. It above code bluez correct?
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bluez: avctp_connect_cb(): BT_IO_OPT_IMTU for omtu?
2019-07-03 10:39 ` Pali Rohár
@ 2019-07-03 12:44 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2019-07-03 12:44 UTC (permalink / raw)
To: Pali Rohár; +Cc: linux-bluetooth@vger.kernel.org
Hi Pali,
On Wed, Jul 3, 2019 at 1:39 PM Pali Rohár <pali.rohar@gmail.com> wrote:
>
> On Wednesday 19 June 2019 18:03:20 Pali Rohár wrote:
> > Hello, in bluez source code is function avctp_connect_cb() with
> > following code:
> >
> > bt_io_get(chan, &gerr,
> > BT_IO_OPT_DEST, &address,
> > BT_IO_OPT_IMTU, &imtu,
> > BT_IO_OPT_IMTU, &omtu,
> > BT_IO_OPT_INVALID);
> >
> > Why is BT_IO_OPT_IMTU used for retrieving omtu? Should not be there
> > BT_IO_OPT_OMTU for retrieving omtu? Seems like a typo: imtu vs omtu.
> >
> > Above code was introduced in commit b5666a3747 (AVCTP: Allocate memory
> > to hold incoming/outgoing PDUs).
>
> Hello, I would like to remind this question. It above code bluez correct?
Fixed:
https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=b2fd4c7e1ecf715a0f56e0a4534329db9b4e44b1
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-03 12:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-19 16:03 bluez: avctp_connect_cb(): BT_IO_OPT_IMTU for omtu? Pali Rohár
2019-07-03 10:39 ` Pali Rohár
2019-07-03 12:44 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox