From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marcel Holtmann <marcel@holtmann.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] Bluetooth: virtio_bt: fix an error code in probe()
Date: Wed, 15 Dec 2021 14:46:45 +0300 [thread overview]
Message-ID: <20211215114644.GC14552@kili> (raw)
Return an error code if virtbt_open_vdev() fails. Don't return success.
Fixes: 212a6e51a630 ("Bluetooth: virtio_bt: fix device removal")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This almost certainly goes through Michael's virt tree and not the
Bluetooth tree.
drivers/bluetooth/virtio_bt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/virtio_bt.c b/drivers/bluetooth/virtio_bt.c
index 1dd734aef87b..f6d699fed139 100644
--- a/drivers/bluetooth/virtio_bt.c
+++ b/drivers/bluetooth/virtio_bt.c
@@ -362,7 +362,8 @@ static int virtbt_probe(struct virtio_device *vdev)
}
virtio_device_ready(vdev);
- if (virtbt_open_vdev(vbt))
+ err = virtbt_open_vdev(vbt);
+ if (err)
goto open_failed;
return 0;
--
2.20.1
next reply other threads:[~2021-12-15 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 11:46 Dan Carpenter [this message]
2021-12-20 23:17 ` [PATCH] Bluetooth: virtio_bt: fix an error code in probe() Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215114644.GC14552@kili \
--to=dan.carpenter@oracle.com \
--cc=johan.hedberg@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox