* [PATCH] Bluetooth: virtio_bt: fix an error code in probe()
@ 2021-12-15 11:46 Dan Carpenter
2021-12-20 23:17 ` Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-12-15 11:46 UTC (permalink / raw)
To: Marcel Holtmann, Michael S. Tsirkin
Cc: Johan Hedberg, Luiz Augusto von Dentz, linux-bluetooth,
kernel-janitors
Return an error code if virtbt_open_vdev() fails. Don't return success.
Fixes: 212a6e51a630 ("Bluetooth: virtio_bt: fix device removal")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This almost certainly goes through Michael's virt tree and not the
Bluetooth tree.
drivers/bluetooth/virtio_bt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/virtio_bt.c b/drivers/bluetooth/virtio_bt.c
index 1dd734aef87b..f6d699fed139 100644
--- a/drivers/bluetooth/virtio_bt.c
+++ b/drivers/bluetooth/virtio_bt.c
@@ -362,7 +362,8 @@ static int virtbt_probe(struct virtio_device *vdev)
}
virtio_device_ready(vdev);
- if (virtbt_open_vdev(vbt))
+ err = virtbt_open_vdev(vbt);
+ if (err)
goto open_failed;
return 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Bluetooth: virtio_bt: fix an error code in probe()
2021-12-15 11:46 [PATCH] Bluetooth: virtio_bt: fix an error code in probe() Dan Carpenter
@ 2021-12-20 23:17 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2021-12-20 23:17 UTC (permalink / raw)
To: Dan Carpenter
Cc: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
linux-bluetooth, kernel-janitors
On Wed, Dec 15, 2021 at 02:46:45PM +0300, Dan Carpenter wrote:
> Return an error code if virtbt_open_vdev() fails. Don't return success.
>
> Fixes: 212a6e51a630 ("Bluetooth: virtio_bt: fix device removal")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> This almost certainly goes through Michael's virt tree and not the
> Bluetooth tree.
>
> drivers/bluetooth/virtio_bt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/virtio_bt.c b/drivers/bluetooth/virtio_bt.c
> index 1dd734aef87b..f6d699fed139 100644
> --- a/drivers/bluetooth/virtio_bt.c
> +++ b/drivers/bluetooth/virtio_bt.c
> @@ -362,7 +362,8 @@ static int virtbt_probe(struct virtio_device *vdev)
> }
>
> virtio_device_ready(vdev);
> - if (virtbt_open_vdev(vbt))
> + err = virtbt_open_vdev(vbt);
> + if (err)
> goto open_failed;
>
> return 0;
> --
> 2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-20 23:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-15 11:46 [PATCH] Bluetooth: virtio_bt: fix an error code in probe() Dan Carpenter
2021-12-20 23:17 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox