[PATCH v2 1/2] monitor: Fix decoding of HCI CIS Established Event

[PATCH v2 1/2] monitor: Fix decoding of HCI CIS Established Event

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

The ISO Interval is actually using set using 1.25ms slots:

BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 4, Part E
page 2304:

  Time = N * 1.25 ms
---
 monitor/packet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index 4473fda29a46..cd567231449e 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -11557,7 +11557,7 @@ static void le_cis_established_evt(struct timeval *tv, uint16_t index,
 	print_field("Peripheral to Central Flush Timeout: %u", evt->p_ft);
 	print_field("Central to Peripheral MTU: %u", le16_to_cpu(evt->c_mtu));
 	print_field("Peripheral to Central MTU: %u", le16_to_cpu(evt->p_mtu));
-	print_field("ISO Interval: %u", le16_to_cpu(evt->interval));
+	print_slot_125("ISO Interval", evt->interval);
 }
 
 static void le_req_cis_evt(struct timeval *tv, uint16_t index,
-- 
2.40.1

[PATCH v2 2/2] btdev: Fix CIS Establish ISO Interval

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

ISO Interval is actually using 1.25 ms slots so it needs to be properly
converted.
---
 emulator/btdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emulator/btdev.c b/emulator/btdev.c
index 462f352ea252..0a375febad68 100644
--- a/emulator/btdev.c
+++ b/emulator/btdev.c
@@ -5977,7 +5977,7 @@ static void le_cis_estabilished(struct btdev *dev, struct btdev_conn *conn,
 		evt.p_ft = 0x01;
 		evt.c_mtu = le_cig->cis[cis_idx].c_sdu;
 		evt.p_mtu = le_cig->cis[cis_idx].p_sdu;
-		evt.interval = le_cig->params.c_latency;
+		evt.interval = (le_cig->params.c_latency + 1) / 1.25;
 	}
 
 	le_meta_event(dev, BT_HCI_EVT_LE_CIS_ESTABLISHED, &evt, sizeof(evt));
-- 
2.40.1

Re: [PATCH v2 1/2] monitor: Fix decoding of HCI CIS Established Event

[patchwork-bot+bluetooth]

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 21 Jun 2023 14:38:44 -0700 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> The ISO Interval is actually using set using 1.25ms slots:
> 
> BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 4, Part E
> page 2304:
> 
> [...]

Here is the summary with links:
  - [v2,1/2] monitor: Fix decoding of HCI CIS Established Event
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=dafec5e4e41e
  - [v2,2/2] btdev: Fix CIS Establish ISO Interval
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=2f3479337f14

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html