Linux bluetooth development
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: Annotate struct hci_drv_rp_read_info with __counted_by_le()
@ 2025-08-10 21:53 Thorsten Blum
  2025-08-10 22:34 ` bluez.test.bot
  2025-08-11 16:16 ` [PATCH] " patchwork-bot+bluetooth
  0 siblings, 2 replies; 3+ messages in thread
From: Thorsten Blum @ 2025-08-10 21:53 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Simon Horman, Kees Cook, Gustavo A. R. Silva
  Cc: Thorsten Blum, linux-bluetooth, netdev, linux-kernel,
	linux-hardening

Add the __counted_by_le() compiler attribute to the flexible array
member 'supported_commands' to improve access bounds-checking via
CONFIG_UBSAN_BOUNDS and CONFIG_FORTIFY_SOURCE.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 include/net/bluetooth/hci_drv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/bluetooth/hci_drv.h b/include/net/bluetooth/hci_drv.h
index 2f01c44f05ec..3fd6fdbdb02e 100644
--- a/include/net/bluetooth/hci_drv.h
+++ b/include/net/bluetooth/hci_drv.h
@@ -47,7 +47,7 @@ struct hci_drv_ev_cmd_complete {
 struct hci_drv_rp_read_info {
 	__u8	driver_name[HCI_DRV_MAX_DRIVER_NAME_LENGTH];
 	__le16	num_supported_commands;
-	__le16	supported_commands[];
+	__le16	supported_commands[] __counted_by_le(num_supported_commands);
 } __packed;
 
 /* Driver specific OGF (Opcode Group Field)
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: Bluetooth: Annotate struct hci_drv_rp_read_info with __counted_by_le()
  2025-08-10 21:53 [PATCH] Bluetooth: Annotate struct hci_drv_rp_read_info with __counted_by_le() Thorsten Blum
@ 2025-08-10 22:34 ` bluez.test.bot
  2025-08-11 16:16 ` [PATCH] " patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2025-08-10 22:34 UTC (permalink / raw)
  To: linux-bluetooth, thorsten.blum

[-- Attachment #1: Type: text/plain, Size: 2776 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=989753

---Test result---

Test Summary:
CheckPatch                    PENDING   0.45 seconds
GitLint                       PENDING   0.35 seconds
SubjectPrefix                 PASS      0.09 seconds
BuildKernel                   PASS      23.95 seconds
CheckAllWarning               PASS      26.72 seconds
CheckSparse                   PASS      29.54 seconds
BuildKernel32                 PASS      23.91 seconds
TestRunnerSetup               PASS      478.20 seconds
TestRunner_l2cap-tester       PASS      26.17 seconds
TestRunner_iso-tester         FAIL      32.81 seconds
TestRunner_bnep-tester        PASS      5.91 seconds
TestRunner_mgmt-tester        FAIL      123.24 seconds
TestRunner_rfcomm-tester      PASS      9.19 seconds
TestRunner_sco-tester         PASS      14.62 seconds
TestRunner_ioctl-tester       PASS      10.00 seconds
TestRunner_mesh-tester        FAIL      11.37 seconds
TestRunner_smp-tester         PASS      8.37 seconds
TestRunner_userchan-tester    PASS      6.04 seconds
IncrementalBuild              PENDING   0.59 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
BUG: KASAN: slab-use-after-free in iso_conn_hold_unless_zero+0x76/0x1c0
Total: 134, Passed: 134 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 490, Passed: 482 (98.4%), Failed: 4, Not Run: 4

Failed Test Cases
Add Ext Advertising - Success 22 (LE -> off, Remove) Failed       0.120 seconds
Set Device ID - Power off and Power on               Failed       0.119 seconds
Set Device ID - SSP off and Power on                 Failed       0.126 seconds
LL Privacy - Add Device 2 (2 Devices to AL)          Failed       0.173 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    2.198 seconds
Mesh - Send cancel - 2                               Timed out    1.997 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Bluetooth: Annotate struct hci_drv_rp_read_info with __counted_by_le()
  2025-08-10 21:53 [PATCH] Bluetooth: Annotate struct hci_drv_rp_read_info with __counted_by_le() Thorsten Blum
  2025-08-10 22:34 ` bluez.test.bot
@ 2025-08-11 16:16 ` patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+bluetooth @ 2025-08-11 16:16 UTC (permalink / raw)
  To: Thorsten Blum
  Cc: marcel, johan.hedberg, luiz.dentz, davem, edumazet, kuba, pabeni,
	horms, kees, gustavoars, linux-bluetooth, netdev, linux-kernel,
	linux-hardening

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Sun, 10 Aug 2025 23:53:20 +0200 you wrote:
> Add the __counted_by_le() compiler attribute to the flexible array
> member 'supported_commands' to improve access bounds-checking via
> CONFIG_UBSAN_BOUNDS and CONFIG_FORTIFY_SOURCE.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  include/net/bluetooth/hci_drv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - Bluetooth: Annotate struct hci_drv_rp_read_info with __counted_by_le()
    https://git.kernel.org/bluetooth/bluetooth-next/c/af4ae40b525d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-08-11 16:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-10 21:53 [PATCH] Bluetooth: Annotate struct hci_drv_rp_read_info with __counted_by_le() Thorsten Blum
2025-08-10 22:34 ` bluez.test.bot
2025-08-11 16:16 ` [PATCH] " patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox