From: Michal Dzik <michal.dzik@streamunlimited.com>
To: linux-bluetooth@vger.kernel.org
Cc: Michal Dzik <michal.dzik@streamunlimited.com>
Subject: [PATCH BlueZ v2 1/4] transport: allow setting Metadata property on broadcast
Date: Fri, 17 Apr 2026 13:29:11 +0200 [thread overview]
Message-ID: <20260417112914.3752605-2-michal.dzik@streamunlimited.com> (raw)
In-Reply-To: <20260417112914.3752605-1-michal.dzik@streamunlimited.com>
Also fixes a problem where 64-bit iov_len was incorrectly initialized with
32-bit value in dbus_message_iter_get_fixed_array().
---
profiles/audio/transport.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/profiles/audio/transport.c b/profiles/audio/transport.c
index d9feef768..81a63c365 100644
--- a/profiles/audio/transport.c
+++ b/profiles/audio/transport.c
@@ -1336,6 +1336,7 @@ static void set_metadata(const GDBusPropertyTable *property,
struct bap_transport *bap = transport->data;
DBusMessageIter array;
struct iovec iov;
+ int len;
int ret;
if (dbus_message_iter_get_arg_type(iter) != DBUS_TYPE_ARRAY) {
@@ -1347,7 +1348,8 @@ static void set_metadata(const GDBusPropertyTable *property,
dbus_message_iter_recurse(iter, &array);
dbus_message_iter_get_fixed_array(&array, &iov.iov_base,
- (int *)&iov.iov_len);
+ &len);
+ iov.iov_len = len;
ret = bt_bap_stream_metadata(bap->stream, &iov, bap_metadata_complete,
UINT_TO_PTR(id));
@@ -1614,7 +1616,7 @@ static const GDBusPropertyTable transport_bap_bc_properties[] = {
{ "QoS", "a{sv}", get_bcast_qos, set_bcast_qos, qos_bcast_exists },
{ "Endpoint", "o", get_endpoint, NULL, endpoint_exists },
{ "Location", "u", get_location },
- { "Metadata", "ay", get_metadata },
+ { "Metadata", "ay", get_metadata, set_metadata },
{ "Links", "ao", get_links, set_links, NULL },
{ }
};
--
2.43.0
next prev parent reply other threads:[~2026-04-17 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 11:29 [PATCH BlueZ v2 0/4] BAP broadcast fixes Michal Dzik
2026-04-17 11:29 ` Michal Dzik [this message]
2026-04-17 12:27 ` bluez.test.bot
2026-04-17 11:29 ` [PATCH BlueZ v2 2/4] shared/bap: run callback after setting the broadcast metadata Michal Dzik
2026-04-17 11:29 ` [PATCH BlueZ v2 3/4] audio/bap: fill BIG and BIS for receiver Michal Dzik
2026-04-17 11:29 ` [PATCH BlueZ v2 4/4] audio: update QoS dbus property after it is set Michal Dzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260417112914.3752605-2-michal.dzik@streamunlimited.com \
--to=michal.dzik@streamunlimited.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox