public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Dzik <michal.dzik@streamunlimited.com>
To: linux-bluetooth@vger.kernel.org
Cc: Michal Dzik <michal.dzik@streamunlimited.com>
Subject: [PATCH BlueZ v2 4/4] audio: update QoS dbus property after it is set
Date: Fri, 17 Apr 2026 13:29:14 +0200	[thread overview]
Message-ID: <20260417112914.3752605-5-michal.dzik@streamunlimited.com> (raw)
In-Reply-To: <20260417112914.3752605-1-michal.dzik@streamunlimited.com>

Dbus set and get on QoS property use different data:
- get uses bap->qos
- set uses bap->stream->qos
This works, because bap->qos is a copy of bap->stream->qos. The only
issue is when we set this property and then try to get it. We see old, not
updated copy. Simply calling bap_update_bcast_qos() fixes the problem.
---
 profiles/audio/transport.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/profiles/audio/transport.c b/profiles/audio/transport.c
index 81a63c365..5c2a2777e 100644
--- a/profiles/audio/transport.c
+++ b/profiles/audio/transport.c
@@ -1556,6 +1556,8 @@ static void bcast_qos_set(void *user_data, int err)
 					"Failed to set Broadcast Code");
 }
 
+static void bap_update_bcast_qos(const struct media_transport *transport);
+
 static void set_bcast_qos(const GDBusPropertyTable *property,
 			DBusMessageIter *dict, GDBusPendingPropertySet id,
 			void *data)
@@ -1604,6 +1606,7 @@ static void set_bcast_qos(const GDBusPropertyTable *property,
 	}
 
 	bt_bap_stream_qos(bap->stream, bap_qos, NULL, NULL);
+	bap_update_bcast_qos(transport);
 	g_dbus_pending_property_success(id);
 }
 
-- 
2.43.0


  parent reply	other threads:[~2026-04-17 11:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17 11:29 [PATCH BlueZ v2 0/4] BAP broadcast fixes Michal Dzik
2026-04-17 11:29 ` [PATCH BlueZ v2 1/4] transport: allow setting Metadata property on broadcast Michal Dzik
2026-04-17 12:27   ` BAP broadcast fixes bluez.test.bot
2026-04-17 11:29 ` [PATCH BlueZ v2 2/4] shared/bap: run callback after setting the broadcast metadata Michal Dzik
2026-04-17 11:29 ` [PATCH BlueZ v2 3/4] audio/bap: fill BIG and BIS for receiver Michal Dzik
2026-04-17 11:29 ` Michal Dzik [this message]
2026-04-20 21:59 ` [PATCH BlueZ v2 0/4] BAP broadcast fixes patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260417112914.3752605-5-michal.dzik@streamunlimited.com \
    --to=michal.dzik@streamunlimited.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox