From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ v1] input: Fix checking LE bonding on HIDP
Date: Wed, 22 Apr 2026 11:03:28 -0400 [thread overview]
Message-ID: <20260422150328.2062359-1-luiz.dentz@gmail.com> (raw)
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
HIDP is classic only, LE uses HOG, so there is no point in checking the
bonding with the address type which in case the device supports
dual-mode will map to LE random/public address.
Fixes: https://github.com/bluez/bluez/issues/2034
---
profiles/input/device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/profiles/input/device.c b/profiles/input/device.c
index 6bdc5ee3aaf3..5b1be2b169f3 100644
--- a/profiles/input/device.c
+++ b/profiles/input/device.c
@@ -127,8 +127,8 @@ static int connection_disconnect(struct input_device *idev, uint32_t flags);
static bool input_device_bonded(struct input_device *idev)
{
- return device_is_bonded(idev->device,
- btd_device_get_bdaddr_type(idev->device));
+ /* HIDP is classic only; so consider it bonded if BDADDR_BREDR is */
+ return device_is_bonded(idev->device, BDADDR_BREDR);
}
static void input_device_free(struct input_device *idev)
@@ -172,8 +172,8 @@ static void input_device_free(struct input_device *idev)
static void virtual_cable_unplug(struct input_device *idev)
{
- device_remove_bonding(idev->device,
- btd_device_get_bdaddr_type(idev->device));
+ /* HIDP is classic only; so only remove BDADDR_BREDR bonding */
+ device_remove_bonding(idev->device, BDADDR_BREDR);
idev->virtual_cable_unplug = false;
}
--
2.53.0
next reply other threads:[~2026-04-22 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 15:03 Luiz Augusto von Dentz [this message]
2026-04-22 16:40 ` [BlueZ,v1] input: Fix checking LE bonding on HIDP bluez.test.bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-21 20:22 [PATCH BlueZ v1] " Luiz Augusto von Dentz
2026-04-22 8:01 ` Bastien Nocera
2026-04-22 14:58 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260422150328.2062359-1-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox