From: Bastien Nocera <hadess@hadess.net>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ v1] input: Fix checking LE bonding on HIDP
Date: Wed, 22 Apr 2026 10:01:13 +0200 [thread overview]
Message-ID: <93591251ab13408ba014fff8b9bcfc171893e232.camel@hadess.net> (raw)
In-Reply-To: <20260421202253.1957689-1-luiz.dentz@gmail.com>
On Tue, 2026-04-21 at 16:22 -0400, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> HIDP is classic only, LE uses HOG, so there is no point in checking
> the
> bonding with the address type which in case the device supports
> dual-mode will map to LE random/public address.
>
> Fixes: https://github.com/bluez/bluez/issues/2034
> ---
> profiles/input/device.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/profiles/input/device.c b/profiles/input/device.c
> index 6bdc5ee3aaf3..0ee6988c4e90 100644
> --- a/profiles/input/device.c
> +++ b/profiles/input/device.c
> @@ -127,8 +127,7 @@ static int connection_disconnect(struct
> input_device *idev, uint32_t flags);
>
> static bool input_device_bonded(struct input_device *idev)
> {
> - return device_is_bonded(idev->device,
> - btd_device_get_bdaddr_type(idev-
> >device));
> + return device_is_bonded(idev->device, BDADDR_BREDR);
Do we want to do the same in virtual_cable_unplug() in that same file?
Do we also want to apply this to hog_accept() with BDADDR_LE in
profiles/input/hog.c ?
> }
>
> static void input_device_free(struct input_device *idev)
next prev parent reply other threads:[~2026-04-22 8:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 20:22 [PATCH BlueZ v1] input: Fix checking LE bonding on HIDP Luiz Augusto von Dentz
2026-04-21 21:26 ` [BlueZ,v1] " bluez.test.bot
2026-04-22 8:01 ` Bastien Nocera [this message]
2026-04-22 14:58 ` [PATCH BlueZ v1] " Luiz Augusto von Dentz
-- strict thread matches above, loose matches on Subject: below --
2026-04-22 15:03 Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93591251ab13408ba014fff8b9bcfc171893e232.camel@hadess.net \
--to=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox