[PATCH BlueZ 1/2] shared/bap: Fix unused value in qos

[PATCH BlueZ 1/2] shared/bap: Fix unused value in qos

[michael_kong]

In bt_bap_parse_base, PresentationDelay is parsed but not written to QoS.
---
 src/shared/bap.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/shared/bap.c b/src/shared/bap.c
index 78ba22259..bd523e5e6 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -7655,16 +7655,15 @@ bool bt_bap_parse_base(uint8_t sid, struct iovec *iov,
 			bt_bap_bis_func_t handler,
 			void *user_data)
 {
-	uint32_t delay;
 	uint8_t sgrps;
 	bool ret = true;
 
 	util_debug(func, NULL, "BASE len: %zd", iov->iov_len);
 
-	if (!util_iov_pull_le24(iov, &delay))
+	if (!util_iov_pull_le24(iov, &qos->bcast.delay))
 		return false;
 
-	util_debug(func, NULL, "PresentationDelay: %d", delay);
+	util_debug(func, NULL, "PresentationDelay: %d", qos->bcast.delay);
 
 	if (!util_iov_pull_u8(iov, &sgrps))
 		return false;
-- 
2.29.1.windows.1

[PATCH BlueZ 2/2] transport: Add support for obtaining PresentationDelay in broadcast QoS

[michael_kong]

---
 profiles/audio/transport.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/profiles/audio/transport.c b/profiles/audio/transport.c
index 3cb4ab0e2..4b9d26c5e 100644
--- a/profiles/audio/transport.c
+++ b/profiles/audio/transport.c
@@ -1605,6 +1605,8 @@ static gboolean get_bcast_qos(const GDBusPropertyTable *property,
 					&bap->qos.bcast.mse);
 	dict_append_entry(&dict, "Timeout", DBUS_TYPE_UINT16,
 					&bap->qos.bcast.timeout);
+	dict_append_entry(&dict, "PresentationDelay", DBUS_TYPE_UINT32,
+					&bap->qos.bcast.delay);
 
 	append_io_qos(&dict, &bap->qos.bcast.io_qos);
 
-- 
2.29.1.windows.1

RE: [BlueZ,1/2] shared/bap: Fix unused value in qos

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2591 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1098419

---Test result---

Test Summary:
CheckPatch                    PASS      0.66 seconds
GitLint                       FAIL      0.50 seconds
BuildEll                      PASS      18.04 seconds
BluezMake                     PASS      643.58 seconds
MakeCheck                     PASS      14.71 seconds
MakeDistcheck                 FAIL      213.39 seconds
CheckValgrind                 PASS      258.46 seconds
CheckSmatch                   WARNING   313.93 seconds
bluezmakeextell               PASS      169.78 seconds
IncrementalBuild              PASS      643.36 seconds
ScanBuild                     PASS      945.89 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,2/2] transport: Add support for obtaining PresentationDelay in broadcast QoS

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (83>80): "[BlueZ,2/2] transport: Add support for obtaining PresentationDelay in broadcast QoS"
##############################
Test: MakeDistcheck - FAIL
Desc: Run Bluez Make Distcheck
Output:

make[4]: *** [Makefile:10239: test-suite.log] Error 1
make[3]: *** [Makefile:10347: check-TESTS] Error 2
make[2]: *** [Makefile:10818: check-am] Error 2
make[1]: *** [Makefile:10820: check] Error 2
make: *** [Makefile:10741: distcheck] Error 1
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/shared/bap.c:312:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:312:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:312:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structures


https://github.com/bluez/bluez/pull/2139

---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ 1/2] shared/bap: Fix unused value in qos

[patchwork-bot+bluetooth]

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 21 May 2026 11:28:14 +0800 you wrote:
> In bt_bap_parse_base, PresentationDelay is parsed but not written to QoS.
> ---
>  src/shared/bap.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Here is the summary with links:
  - [BlueZ,1/2] shared/bap: Fix unused value in qos
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=29fb17c909a0
  - [BlueZ,2/2] transport: Add support for obtaining PresentationDelay in broadcast QoS
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=fd25b4b1e596

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html