[PATCH v1] gobex: Fix ABORT response being discarded

[PATCH v1] gobex: Fix ABORT response being discarded

[Jinwang Li]

g_obex_drop_tx_queue() in transfer_complete() clears any pending tx,
so the ABORT success response should be enqueued after transfer_complete().

Fixes the following PTS test cases:
- OPP/SR/OPH/BV-27-I
- FTP/SR/OTR/BV-02-C
- PBAP/PSE/PDF/BV-06-I
- PBAP/PSE/PBF/BV-03-I

Fixes: 7a35c12a6ceb ("gobex: Fix segfault caused by interrupted transfer")
Assisted-by: Claude:claude-sonnet-5
Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
---
 gobex/gobex-transfer.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gobex/gobex-transfer.c b/gobex/gobex-transfer.c
index c94d018b2..e4c7c557d 100644
--- a/gobex/gobex-transfer.c
+++ b/gobex/gobex-transfer.c
@@ -314,11 +314,12 @@ static void transfer_abort_req(GObex *obex, GObexPacket *req, gpointer user_data
 
 	err = g_error_new(G_OBEX_ERROR, G_OBEX_ERROR_CANCELLED,
 						"Request was aborted");
-	rsp = g_obex_packet_new(G_OBEX_RSP_SUCCESS, TRUE, G_OBEX_HDR_INVALID);
-	g_obex_send(obex, rsp, NULL);
 
 	transfer_complete(transfer, err);
 	g_error_free(err);
+
+	rsp = g_obex_packet_new(G_OBEX_RSP_SUCCESS, TRUE, G_OBEX_HDR_INVALID);
+	g_obex_send(obex, rsp, NULL);
 }
 
 static guint8 put_get_bytes(struct transfer *transfer, GObexPacket *req)
-- 
2.34.1

RE: [v1] gobex: Fix ABORT response being discarded

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1963 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1152525

---Test result---

Test Summary:
CheckPatch                    FAIL      0.52 seconds
GitLint                       PASS      0.36 seconds
BuildEll                      PASS      20.98 seconds
BluezMake                     PASS      566.26 seconds
MakeCheck                     PASS      2.38 seconds
MakeDistcheck                 PASS      155.07 seconds
CheckValgrind                 PASS      149.90 seconds
CheckSmatch                   PASS      301.14 seconds
bluezmakeextell               PASS      98.35 seconds
IncrementalBuild              PASS      562.27 seconds
ScanBuild                     PASS      902.18 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[v1] gobex: Fix ABORT response being discarded
WARNING:BAD_SIGN_OFF: Non-standard signature: Assisted-by:
#125: 
Assisted-by: Claude:claude-sonnet-5

ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Claude:claude-sonnet-5'
#125: 
Assisted-by: Claude:claude-sonnet-5

/github/workspace/src/patch/14770796.patch total: 1 errors, 1 warnings, 14 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/patch/14770796.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




https://github.com/bluez/bluez/pull/2440

---
Regards,
Linux Bluetooth

Re: [PATCH v1] gobex: Fix ABORT response being discarded

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 27 Aug 2026 16:36:51 +0800 you wrote:
> g_obex_drop_tx_queue() in transfer_complete() clears any pending tx,
> so the ABORT success response should be enqueued after transfer_complete().
> 
> Fixes the following PTS test cases:
> - OPP/SR/OPH/BV-27-I
> - FTP/SR/OTR/BV-02-C
> - PBAP/PSE/PDF/BV-06-I
> - PBAP/PSE/PBF/BV-03-I
> 
> [...]

Here is the summary with links:
  - [v1] gobex: Fix ABORT response being discarded
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=d094be10ff0c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html