From: Bastien Nocera <hadess@hadess.net>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH] all: Fix typo in AVRCP_ATTRIBUTE_ILEGAL
Date: Thu, 27 Aug 2026 16:57:38 +0200 [thread overview]
Message-ID: <20260827145742.1568129-1-hadess@hadess.net> (raw)
It's "illegal" not "ilegal".
---
monitor/avctp.c | 6 +++---
profiles/audio/avrcp.c | 2 +-
profiles/audio/avrcp.h | 2 +-
tools/parser/avrcp.c | 6 +++---
unit/avrcp-lib.c | 8 ++++----
unit/avrcp-lib.h | 2 +-
6 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/monitor/avctp.c b/monitor/avctp.c
index 6309275f6efd..0db352f18ffd 100644
--- a/monitor/avctp.c
+++ b/monitor/avctp.c
@@ -141,7 +141,7 @@
#define AVRCP_PACKET_TYPE_END 0x03
/* player attributes */
-#define AVRCP_ATTRIBUTE_ILEGAL 0x00
+#define AVRCP_ATTRIBUTE_ILLEGAL 0x00
#define AVRCP_ATTRIBUTE_EQUALIZER 0x01
#define AVRCP_ATTRIBUTE_REPEAT_MODE 0x02
#define AVRCP_ATTRIBUTE_SHUFFLE 0x03
@@ -462,7 +462,7 @@ static const char *pt2str(uint8_t pt)
static const char *attr2str(uint8_t attr)
{
switch (attr) {
- case AVRCP_ATTRIBUTE_ILEGAL:
+ case AVRCP_ATTRIBUTE_ILLEGAL:
return "Illegal";
case AVRCP_ATTRIBUTE_EQUALIZER:
return "Equalizer ON/OFF Status";
@@ -480,7 +480,7 @@ static const char *attr2str(uint8_t attr)
static const char *value2str(uint8_t attr, uint8_t value)
{
switch (attr) {
- case AVRCP_ATTRIBUTE_ILEGAL:
+ case AVRCP_ATTRIBUTE_ILLEGAL:
return "Illegal";
case AVRCP_ATTRIBUTE_EQUALIZER:
switch (value) {
diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
index 028c1c254b82..3271b84782e8 100644
--- a/profiles/audio/avrcp.c
+++ b/profiles/audio/avrcp.c
@@ -2413,7 +2413,7 @@ static gboolean avrcp_list_player_attributes_rsp(struct avctp *conn,
for (i = 0; len > 0; len--, i++) {
/* Don't query invalid attributes */
- if (pdu->params[i + 1] == AVRCP_ATTRIBUTE_ILEGAL ||
+ if (pdu->params[i + 1] == AVRCP_ATTRIBUTE_ILLEGAL ||
pdu->params[i + 1] > AVRCP_ATTRIBUTE_LAST)
continue;
diff --git a/profiles/audio/avrcp.h b/profiles/audio/avrcp.h
index b5381b4df234..21351a4bc422 100644
--- a/profiles/audio/avrcp.h
+++ b/profiles/audio/avrcp.h
@@ -10,7 +10,7 @@
*/
/* player attributes */
-#define AVRCP_ATTRIBUTE_ILEGAL 0x00
+#define AVRCP_ATTRIBUTE_ILLEGAL 0x00
#define AVRCP_ATTRIBUTE_EQUALIZER 0x01
#define AVRCP_ATTRIBUTE_REPEAT_MODE 0x02
#define AVRCP_ATTRIBUTE_SHUFFLE 0x03
diff --git a/tools/parser/avrcp.c b/tools/parser/avrcp.c
index 9f0c1596b4b9..7da9b0d07b3c 100644
--- a/tools/parser/avrcp.c
+++ b/tools/parser/avrcp.c
@@ -145,7 +145,7 @@
#define AVRCP_STATUS_ADDRESSED_PLAYER_CHANGED 0x16
/* player attributes */
-#define AVRCP_ATTRIBUTE_ILEGAL 0x00
+#define AVRCP_ATTRIBUTE_ILLEGAL 0x00
#define AVRCP_ATTRIBUTE_EQUALIZER 0x01
#define AVRCP_ATTRIBUTE_REPEAT_MODE 0x02
#define AVRCP_ATTRIBUTE_SHUFFLE 0x03
@@ -471,7 +471,7 @@ static void avrcp_get_capabilities_dump(int level, struct frame *frm, uint16_t l
static const char *attr2str(uint8_t attr)
{
switch (attr) {
- case AVRCP_ATTRIBUTE_ILEGAL:
+ case AVRCP_ATTRIBUTE_ILLEGAL:
return "Illegal";
case AVRCP_ATTRIBUTE_EQUALIZER:
return "Equalizer ON/OFF Status";
@@ -512,7 +512,7 @@ static void avrcp_list_player_attributes_dump(int level, struct frame *frm,
static const char *value2str(uint8_t attr, uint8_t value)
{
switch (attr) {
- case AVRCP_ATTRIBUTE_ILEGAL:
+ case AVRCP_ATTRIBUTE_ILLEGAL:
return "Illegal";
case AVRCP_ATTRIBUTE_EQUALIZER:
switch (value) {
diff --git a/unit/avrcp-lib.c b/unit/avrcp-lib.c
index 720775fd2603..1549f8145d5f 100644
--- a/unit/avrcp-lib.c
+++ b/unit/avrcp-lib.c
@@ -717,7 +717,7 @@ static bool check_attributes(uint8_t number, const uint8_t *attrs)
for (i = 0; i < number; i++) {
if (attrs[i] > AVRCP_ATTRIBUTE_LAST ||
- attrs[i] == AVRCP_ATTRIBUTE_ILEGAL)
+ attrs[i] == AVRCP_ATTRIBUTE_ILLEGAL)
return false;
}
@@ -765,7 +765,7 @@ static ssize_t list_values(struct avrcp *session, uint8_t transaction,
req = (void *) params;
if (req->attr > AVRCP_ATTRIBUTE_LAST ||
- req->attr == AVRCP_ATTRIBUTE_ILEGAL)
+ req->attr == AVRCP_ATTRIBUTE_ILLEGAL)
return -EINVAL;
if (!player->ind || !player->ind->list_values)
@@ -828,7 +828,7 @@ static ssize_t get_value_text(struct avrcp *session, uint8_t transaction,
return -EINVAL;
if (req->number > AVRCP_ATTRIBUTE_LAST ||
- req->number == AVRCP_ATTRIBUTE_ILEGAL)
+ req->number == AVRCP_ATTRIBUTE_ILLEGAL)
return -EINVAL;
if (!check_value(req->attr, req->number, req->values))
@@ -3138,7 +3138,7 @@ int avrcp_get_player_attribute_text_rsp(struct avrcp *session,
uint8_t len = 0;
if (attrs[i] > AVRCP_ATTRIBUTE_LAST ||
- attrs[i] == AVRCP_ATTRIBUTE_ILEGAL)
+ attrs[i] == AVRCP_ATTRIBUTE_ILLEGAL)
return -EINVAL;
if (text[i])
diff --git a/unit/avrcp-lib.h b/unit/avrcp-lib.h
index 5adb321880e8..3979dcaa13a4 100644
--- a/unit/avrcp-lib.h
+++ b/unit/avrcp-lib.h
@@ -69,7 +69,7 @@
#define CAP_EVENTS_SUPPORTED 0x03
/* Player Attributes */
-#define AVRCP_ATTRIBUTE_ILEGAL 0x00
+#define AVRCP_ATTRIBUTE_ILLEGAL 0x00
#define AVRCP_ATTRIBUTE_EQUALIZER 0x01
#define AVRCP_ATTRIBUTE_REPEAT_MODE 0x02
#define AVRCP_ATTRIBUTE_SHUFFLE 0x03
--
2.55.0
next reply other threads:[~2026-08-27 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 14:57 Bastien Nocera [this message]
2026-08-27 16:21 ` all: Fix typo in AVRCP_ATTRIBUTE_ILEGAL bluez.test.bot
2026-08-27 17:10 ` [PATCH] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827145742.1568129-1-hadess@hadess.net \
--to=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox