* [PATCH] all: Fix typo in AVRCP_ATTRIBUTE_ILEGAL
@ 2026-08-27 14:57 Bastien Nocera
2026-08-27 16:21 ` bluez.test.bot
2026-08-27 17:10 ` [PATCH] " patchwork-bot+bluetooth
0 siblings, 2 replies; 3+ messages in thread
From: Bastien Nocera @ 2026-08-27 14:57 UTC (permalink / raw)
To: linux-bluetooth
It's "illegal" not "ilegal".
---
monitor/avctp.c | 6 +++---
profiles/audio/avrcp.c | 2 +-
profiles/audio/avrcp.h | 2 +-
tools/parser/avrcp.c | 6 +++---
unit/avrcp-lib.c | 8 ++++----
unit/avrcp-lib.h | 2 +-
6 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/monitor/avctp.c b/monitor/avctp.c
index 6309275f6efd..0db352f18ffd 100644
--- a/monitor/avctp.c
+++ b/monitor/avctp.c
@@ -141,7 +141,7 @@
#define AVRCP_PACKET_TYPE_END 0x03
/* player attributes */
-#define AVRCP_ATTRIBUTE_ILEGAL 0x00
+#define AVRCP_ATTRIBUTE_ILLEGAL 0x00
#define AVRCP_ATTRIBUTE_EQUALIZER 0x01
#define AVRCP_ATTRIBUTE_REPEAT_MODE 0x02
#define AVRCP_ATTRIBUTE_SHUFFLE 0x03
@@ -462,7 +462,7 @@ static const char *pt2str(uint8_t pt)
static const char *attr2str(uint8_t attr)
{
switch (attr) {
- case AVRCP_ATTRIBUTE_ILEGAL:
+ case AVRCP_ATTRIBUTE_ILLEGAL:
return "Illegal";
case AVRCP_ATTRIBUTE_EQUALIZER:
return "Equalizer ON/OFF Status";
@@ -480,7 +480,7 @@ static const char *attr2str(uint8_t attr)
static const char *value2str(uint8_t attr, uint8_t value)
{
switch (attr) {
- case AVRCP_ATTRIBUTE_ILEGAL:
+ case AVRCP_ATTRIBUTE_ILLEGAL:
return "Illegal";
case AVRCP_ATTRIBUTE_EQUALIZER:
switch (value) {
diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
index 028c1c254b82..3271b84782e8 100644
--- a/profiles/audio/avrcp.c
+++ b/profiles/audio/avrcp.c
@@ -2413,7 +2413,7 @@ static gboolean avrcp_list_player_attributes_rsp(struct avctp *conn,
for (i = 0; len > 0; len--, i++) {
/* Don't query invalid attributes */
- if (pdu->params[i + 1] == AVRCP_ATTRIBUTE_ILEGAL ||
+ if (pdu->params[i + 1] == AVRCP_ATTRIBUTE_ILLEGAL ||
pdu->params[i + 1] > AVRCP_ATTRIBUTE_LAST)
continue;
diff --git a/profiles/audio/avrcp.h b/profiles/audio/avrcp.h
index b5381b4df234..21351a4bc422 100644
--- a/profiles/audio/avrcp.h
+++ b/profiles/audio/avrcp.h
@@ -10,7 +10,7 @@
*/
/* player attributes */
-#define AVRCP_ATTRIBUTE_ILEGAL 0x00
+#define AVRCP_ATTRIBUTE_ILLEGAL 0x00
#define AVRCP_ATTRIBUTE_EQUALIZER 0x01
#define AVRCP_ATTRIBUTE_REPEAT_MODE 0x02
#define AVRCP_ATTRIBUTE_SHUFFLE 0x03
diff --git a/tools/parser/avrcp.c b/tools/parser/avrcp.c
index 9f0c1596b4b9..7da9b0d07b3c 100644
--- a/tools/parser/avrcp.c
+++ b/tools/parser/avrcp.c
@@ -145,7 +145,7 @@
#define AVRCP_STATUS_ADDRESSED_PLAYER_CHANGED 0x16
/* player attributes */
-#define AVRCP_ATTRIBUTE_ILEGAL 0x00
+#define AVRCP_ATTRIBUTE_ILLEGAL 0x00
#define AVRCP_ATTRIBUTE_EQUALIZER 0x01
#define AVRCP_ATTRIBUTE_REPEAT_MODE 0x02
#define AVRCP_ATTRIBUTE_SHUFFLE 0x03
@@ -471,7 +471,7 @@ static void avrcp_get_capabilities_dump(int level, struct frame *frm, uint16_t l
static const char *attr2str(uint8_t attr)
{
switch (attr) {
- case AVRCP_ATTRIBUTE_ILEGAL:
+ case AVRCP_ATTRIBUTE_ILLEGAL:
return "Illegal";
case AVRCP_ATTRIBUTE_EQUALIZER:
return "Equalizer ON/OFF Status";
@@ -512,7 +512,7 @@ static void avrcp_list_player_attributes_dump(int level, struct frame *frm,
static const char *value2str(uint8_t attr, uint8_t value)
{
switch (attr) {
- case AVRCP_ATTRIBUTE_ILEGAL:
+ case AVRCP_ATTRIBUTE_ILLEGAL:
return "Illegal";
case AVRCP_ATTRIBUTE_EQUALIZER:
switch (value) {
diff --git a/unit/avrcp-lib.c b/unit/avrcp-lib.c
index 720775fd2603..1549f8145d5f 100644
--- a/unit/avrcp-lib.c
+++ b/unit/avrcp-lib.c
@@ -717,7 +717,7 @@ static bool check_attributes(uint8_t number, const uint8_t *attrs)
for (i = 0; i < number; i++) {
if (attrs[i] > AVRCP_ATTRIBUTE_LAST ||
- attrs[i] == AVRCP_ATTRIBUTE_ILEGAL)
+ attrs[i] == AVRCP_ATTRIBUTE_ILLEGAL)
return false;
}
@@ -765,7 +765,7 @@ static ssize_t list_values(struct avrcp *session, uint8_t transaction,
req = (void *) params;
if (req->attr > AVRCP_ATTRIBUTE_LAST ||
- req->attr == AVRCP_ATTRIBUTE_ILEGAL)
+ req->attr == AVRCP_ATTRIBUTE_ILLEGAL)
return -EINVAL;
if (!player->ind || !player->ind->list_values)
@@ -828,7 +828,7 @@ static ssize_t get_value_text(struct avrcp *session, uint8_t transaction,
return -EINVAL;
if (req->number > AVRCP_ATTRIBUTE_LAST ||
- req->number == AVRCP_ATTRIBUTE_ILEGAL)
+ req->number == AVRCP_ATTRIBUTE_ILLEGAL)
return -EINVAL;
if (!check_value(req->attr, req->number, req->values))
@@ -3138,7 +3138,7 @@ int avrcp_get_player_attribute_text_rsp(struct avrcp *session,
uint8_t len = 0;
if (attrs[i] > AVRCP_ATTRIBUTE_LAST ||
- attrs[i] == AVRCP_ATTRIBUTE_ILEGAL)
+ attrs[i] == AVRCP_ATTRIBUTE_ILLEGAL)
return -EINVAL;
if (text[i])
diff --git a/unit/avrcp-lib.h b/unit/avrcp-lib.h
index 5adb321880e8..3979dcaa13a4 100644
--- a/unit/avrcp-lib.h
+++ b/unit/avrcp-lib.h
@@ -69,7 +69,7 @@
#define CAP_EVENTS_SUPPORTED 0x03
/* Player Attributes */
-#define AVRCP_ATTRIBUTE_ILEGAL 0x00
+#define AVRCP_ATTRIBUTE_ILLEGAL 0x00
#define AVRCP_ATTRIBUTE_EQUALIZER 0x01
#define AVRCP_ATTRIBUTE_REPEAT_MODE 0x02
#define AVRCP_ATTRIBUTE_SHUFFLE 0x03
--
2.55.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: all: Fix typo in AVRCP_ATTRIBUTE_ILEGAL
2026-08-27 14:57 [PATCH] all: Fix typo in AVRCP_ATTRIBUTE_ILEGAL Bastien Nocera
@ 2026-08-27 16:21 ` bluez.test.bot
2026-08-27 17:10 ` [PATCH] " patchwork-bot+bluetooth
1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2026-08-27 16:21 UTC (permalink / raw)
To: linux-bluetooth, hadess
[-- Attachment #1: Type: text/plain, Size: 1360 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1152689
---Test result---
Test Summary:
CheckPatch PASS 0.87 seconds
GitLint PASS 0.48 seconds
BuildEll PASS 21.43 seconds
BluezMake PASS 650.17 seconds
MakeCheck PASS 18.92 seconds
MakeDistcheck PASS 163.82 seconds
CheckValgrind PASS 239.06 seconds
CheckSmatch WARNING 319.49 seconds
bluezmakeextell PASS 104.14 seconds
IncrementalBuild PASS 622.09 seconds
ScanBuild PASS 1006.35 seconds
Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
unit/avrcp-lib.c:1085:34: warning: Variable length array is used.unit/avrcp-lib.c:1583:34: warning: Variable length array is used.unit/avrcp-lib.c:1612:34: warning: Variable length array is used.unit/avrcp-lib.c:1638:34: warning: Variable length array is used.
https://github.com/bluez/bluez/pull/2442
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] all: Fix typo in AVRCP_ATTRIBUTE_ILEGAL
2026-08-27 14:57 [PATCH] all: Fix typo in AVRCP_ATTRIBUTE_ILEGAL Bastien Nocera
2026-08-27 16:21 ` bluez.test.bot
@ 2026-08-27 17:10 ` patchwork-bot+bluetooth
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+bluetooth @ 2026-08-27 17:10 UTC (permalink / raw)
To: Bastien Nocera; +Cc: linux-bluetooth
Hello:
This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Thu, 27 Aug 2026 16:57:38 +0200 you wrote:
> It's "illegal" not "ilegal".
> ---
> monitor/avctp.c | 6 +++---
> profiles/audio/avrcp.c | 2 +-
> profiles/audio/avrcp.h | 2 +-
> tools/parser/avrcp.c | 6 +++---
> unit/avrcp-lib.c | 8 ++++----
> unit/avrcp-lib.h | 2 +-
> 6 files changed, 13 insertions(+), 13 deletions(-)
Here is the summary with links:
- all: Fix typo in AVRCP_ATTRIBUTE_ILEGAL
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=73ccf6d83e6a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-27 17:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-27 14:57 [PATCH] all: Fix typo in AVRCP_ATTRIBUTE_ILEGAL Bastien Nocera
2026-08-27 16:21 ` bluez.test.bot
2026-08-27 17:10 ` [PATCH] " patchwork-bot+bluetooth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox