Linux bluetooth development
 help / color / mirror / Atom feed
* [PATCH BlueZ] monitor: Fix legacy SCAN_RSP PDU type names
@ 2026-10-02 20:00 Kevin Dewald
  2026-10-02 22:07 ` [BlueZ] " bluez.test.bot
  0 siblings, 1 reply; 2+ messages in thread
From: Kevin Dewald @ 2026-10-02 20:00 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Kevin Dewald

The names of the two legacy scan response event types are swapped. A
scan response keeps the properties of the advertisement it answers, so
0x1b, which has the connectable bit set, is the response to ADV_IND and
0x1a is the response to ADV_SCAN_IND, as listed in Core Specification
Vol 4, Part E, 7.7.65.13, Table 7.1.

Fixes: e29ef3b85116 ("monitor: Add LE Extended Scan commands decoding")
Assisted-by: Claude:claude-opus-5.5
---
 monitor/packet.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index 8450347fc..5b289ad9f 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -13074,10 +13074,10 @@ static void print_legacy_adv_report_pdu(uint16_t flags)
 		str = "ADV_DIRECT_IND";
 		break;
 	case 0x1a:
-		str = "SCAN_RSP to an ADV_IND";
+		str = "SCAN_RSP to an ADV_SCAN_IND";
 		break;
 	case 0x1b:
-		str = "SCAN_RSP to an ADV_SCAN_IND";
+		str = "SCAN_RSP to an ADV_IND";
 		break;
 	default:
 		str = "Reserved";
-- 
2.54.0 (Apple Git-157)


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [BlueZ] monitor: Fix legacy SCAN_RSP PDU type names
  2026-10-02 20:00 [PATCH BlueZ] monitor: Fix legacy SCAN_RSP PDU type names Kevin Dewald
@ 2026-10-02 22:07 ` bluez.test.bot
  0 siblings, 0 replies; 2+ messages in thread
From: bluez.test.bot @ 2026-10-02 22:07 UTC (permalink / raw)
  To: linux-bluetooth, kevin

[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1178588/

---Test result---

Test Summary:
CheckPatch                    PASS      0.29 seconds
GitLint                       PASS      0.22 seconds
BuildEll                      PASS      19.97 seconds
BluezMake                     PASS      400.93 seconds
MakeCheck                     PASS      0.83 seconds
MakeDistcheck                 PASS      143.06 seconds
CheckValgrind                 PASS      148.04 seconds
CheckSmatch                   WARNING   292.34 seconds
bluezmakeextell               PASS      93.70 seconds
TestFunctional                PASS      1158.36 seconds
IncrementalBuild              PASS      404.38 seconds
ScanBuild                     PASS      1157.22 seconds

Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
monitor/packet.c:2289:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3924:52: warning: array of flexible structuresmonitor/bt.h:3912:40: warning: array of flexible structures


https://github.com/bluez/bluez/pull/2624

---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-02 22:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-02 20:00 [PATCH BlueZ] monitor: Fix legacy SCAN_RSP PDU type names Kevin Dewald
2026-10-02 22:07 ` [BlueZ] " bluez.test.bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox