[RFC PATCH] asha: use robust streaming connection parameters

[RFC PATCH] asha: use robust streaming connection parameters

[Kyle Pepper]

The tested renderer requests a six-second supervision timeout and
latency of five events. Use these values instead of the one-second
timeout and ten-event latency that accompanied link failures.

Assisted-by: OpenCode:gpt-6.1-sol
---
Submission review notes (not part of the commit message):
Local validation is for base 7428ca2df9356363079db0f48412c20cbdb9471f.
Compatibility with newer upstream tips has not been verified locally.
October 9 N8/UB500 trials independently restore timeout 1 s and latency
10. Completed HCI values change as intended; the variants have five and
four supervision timeouts respectively. Restoring latency 5 / timeout 6 s
restores short streaming. These are device-tested values, not universally
optimal ASHA defaults. STATUS and the other downstream fixes stayed on.

 profiles/audio/asha.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/profiles/audio/asha.c b/profiles/audio/asha.c
index 8e625fdca3..409b4f20b5 100644
--- a/profiles/audio/asha.c
+++ b/profiles/audio/asha.c
@@ -50,6 +50,9 @@
 #define ASHA_MIN_MTU 163
 /* The default of 672 does not work */
 #define ASHA_CONNECTION_MTU 512
+#define ASHA_CONN_INTERVAL 0x0010 /* 20 ms in 1.25 ms units */
+#define ASHA_CONN_LATENCY 0x0005
+#define ASHA_SUPERVISION_TIMEOUT 0x0258 /* 6 s in 10 ms units */
 
 struct bt_asha_device {
 	struct bt_asha *asha;
@@ -162,10 +165,8 @@ unsigned int bt_asha_device_start(struct bt_asha_device *asha_dev,
 	int ret;
 
 	btd_device_set_conn_param(asha_dev->device,
-			0x0010 /* min interval = 1.25ms intervals => 20ms */,
-			0x0010 /* max interval = 1.25ms intervals => 20ms */,
-			0x000A /* 10 events' latency */,
-			0x0064 /* 1s timeout */);
+			ASHA_CONN_INTERVAL, ASHA_CONN_INTERVAL,
+			ASHA_CONN_LATENCY, ASHA_SUPERVISION_TIMEOUT);
 
 	ret = asha_connect_socket(asha_dev, cb, user_data);
 

base-commit: 7428ca2df9356363079db0f48412c20cbdb9471f

RE: [RFC] asha: use robust streaming connection parameters

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1184361/

---Test result---

Test Summary:
CheckPatch                    PASS      0.29 seconds
GitLint                       PASS      0.21 seconds
BuildEll                      PASS      19.27 seconds
BluezMake                     PASS      292.49 seconds
MakeCheck                     PASS      3.24 seconds
MakeDistcheck                 PASS      140.71 seconds
CheckValgrind                 PASS      150.03 seconds
CheckSmatch                   PASS      289.97 seconds
bluezmakeextell               PASS      94.02 seconds
TestFunctional                FAIL      1155.62 seconds
IncrementalBuild              PASS      292.11 seconds
ScanBuild                     PASS      1116.24 seconds

Details
##############################
Test: TestFunctional - FAIL
Desc: Run test-functional
Output:
FAIL functional.test_hog::test_hog[sci-hosts18-vm2]: pytest_bluezenv.rpc.RemoteTimeoutError: Connection recv timed out


https://github.com/bluez/bluez/pull/2667

---
Regards,
Linux Bluetooth