* [PATCH v2 1/2] shared/hfp: Remove reduntant check
@ 2014-10-31 9:32 Lukasz Rymanowski
2014-10-31 19:13 ` Szymon Janc
0 siblings, 1 reply; 2+ messages in thread
From: Lukasz Rymanowski @ 2014-10-31 9:32 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Lukasz Rymanowski
To make this check strcmp is good enought. Not need to check len first
and then do memory compare.
---
src/shared/hfp.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/shared/hfp.c b/src/shared/hfp.c
index 9a66ed2..0ce38cc 100644
--- a/src/shared/hfp.c
+++ b/src/shared/hfp.c
@@ -135,10 +135,7 @@ static bool match_handler_prefix(const void *a, const void *b)
const struct cmd_handler *handler = a;
const char *prefix = b;
- if (strlen(handler->prefix) != strlen(prefix))
- return false;
-
- if (memcmp(handler->prefix, prefix, strlen(prefix)))
+ if (strcmp(handler->prefix, prefix) != 0)
return false;
return true;
--
1.8.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/2] shared/hfp: Remove reduntant check
2014-10-31 9:32 [PATCH v2 1/2] shared/hfp: Remove reduntant check Lukasz Rymanowski
@ 2014-10-31 19:13 ` Szymon Janc
0 siblings, 0 replies; 2+ messages in thread
From: Szymon Janc @ 2014-10-31 19:13 UTC (permalink / raw)
To: Lukasz Rymanowski; +Cc: linux-bluetooth
Hi Łukasz,
On Friday 31 of October 2014 10:32:32 Lukasz Rymanowski wrote:
> To make this check strcmp is good enought. Not need to check len first
> and then do memory compare.
> ---
> src/shared/hfp.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/src/shared/hfp.c b/src/shared/hfp.c
> index 9a66ed2..0ce38cc 100644
> --- a/src/shared/hfp.c
> +++ b/src/shared/hfp.c
> @@ -135,10 +135,7 @@ static bool match_handler_prefix(const void *a, const
> void *b) const struct cmd_handler *handler = a;
> const char *prefix = b;
>
> - if (strlen(handler->prefix) != strlen(prefix))
> - return false;
> -
> - if (memcmp(handler->prefix, prefix, strlen(prefix)))
> + if (strcmp(handler->prefix, prefix) != 0)
> return false;
>
> return true;
Applied (with typos in commit message fixed), thanks.
--
BR
Szymon Janc
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-31 19:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-31 9:32 [PATCH v2 1/2] shared/hfp: Remove reduntant check Lukasz Rymanowski
2014-10-31 19:13 ` Szymon Janc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox