* [PATCH] core: Use proper header for S_IRUSR/S_IWUSR
@ 2013-07-09 7:40 Szymon Janc
2013-07-15 9:25 ` Johan Hedberg
2013-07-31 7:39 ` Szymon Janc
0 siblings, 2 replies; 5+ messages in thread
From: Szymon Janc @ 2013-07-09 7:40 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Szymon Janc
According to open() manual one should include <sys/stat.h>.
This fix build with bionic library:
target thumb C: libbluetoothd <= external/bluetooth/bluez/src/attrib-server.c
external/bluetooth/bluez/src/attrib-server.c: In function 'write_value':
external/bluetooth/bluez/src/attrib-server.c:922:26: error: 'S_IRUSR'
undeclared (first use in this function)
external/bluetooth/bluez/src/attrib-server.c:922:26: note: each undeclared
identifier is reported only once for each function it appears in
external/bluetooth/bluez/src/attrib-server.c:922:36: error: 'S_IWUSR'
undeclared (first use in this function)
---
src/attrib-server.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/attrib-server.c b/src/attrib-server.c
index e5e3030..93f03b3 100644
--- a/src/attrib-server.c
+++ b/src/attrib-server.c
@@ -32,7 +32,7 @@
#include <string.h>
#include <unistd.h>
#include <glib.h>
-#include <sys/file.h>
+#include <sys/stat.h>
#include <bluetooth/bluetooth.h>
#include <bluetooth/sdp.h>
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] core: Use proper header for S_IRUSR/S_IWUSR
2013-07-09 7:40 [PATCH] core: Use proper header for S_IRUSR/S_IWUSR Szymon Janc
@ 2013-07-15 9:25 ` Johan Hedberg
2013-07-31 7:39 ` Szymon Janc
1 sibling, 0 replies; 5+ messages in thread
From: Johan Hedberg @ 2013-07-15 9:25 UTC (permalink / raw)
To: Szymon Janc; +Cc: linux-bluetooth
Hi Szymon,
On Tue, Jul 09, 2013, Szymon Janc wrote:
> According to open() manual one should include <sys/stat.h>.
> This fix build with bionic library:
>
> target thumb C: libbluetoothd <= external/bluetooth/bluez/src/attrib-server.c
> external/bluetooth/bluez/src/attrib-server.c: In function 'write_value':
> external/bluetooth/bluez/src/attrib-server.c:922:26: error: 'S_IRUSR'
> undeclared (first use in this function)
> external/bluetooth/bluez/src/attrib-server.c:922:26: note: each undeclared
> identifier is reported only once for each function it appears in
> external/bluetooth/bluez/src/attrib-server.c:922:36: error: 'S_IWUSR'
> undeclared (first use in this function)
> ---
> src/attrib-server.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] core: Use proper header for S_IRUSR/S_IWUSR
2013-07-09 7:40 [PATCH] core: Use proper header for S_IRUSR/S_IWUSR Szymon Janc
2013-07-15 9:25 ` Johan Hedberg
@ 2013-07-31 7:39 ` Szymon Janc
2013-07-31 7:57 ` Johan Hedberg
1 sibling, 1 reply; 5+ messages in thread
From: Szymon Janc @ 2013-07-31 7:39 UTC (permalink / raw)
To: linux-bluetooth
On Tuesday 09 of July 2013 09:40:00 Szymon Janc wrote:
> According to open() manual one should include <sys/stat.h>.
> This fix build with bionic library:
>
> target thumb C: libbluetoothd <= external/bluetooth/bluez/src/attrib-server.c
> external/bluetooth/bluez/src/attrib-server.c: In function 'write_value':
> external/bluetooth/bluez/src/attrib-server.c:922:26: error: 'S_IRUSR'
> undeclared (first use in this function)
> external/bluetooth/bluez/src/attrib-server.c:922:26: note: each undeclared
> identifier is reported only once for each function it appears in
> external/bluetooth/bluez/src/attrib-server.c:922:36: error: 'S_IWUSR'
> undeclared (first use in this function)
ping
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] core: Use proper header for S_IRUSR/S_IWUSR
2013-07-31 7:39 ` Szymon Janc
@ 2013-07-31 7:57 ` Johan Hedberg
2013-07-31 8:32 ` Szymon Janc
0 siblings, 1 reply; 5+ messages in thread
From: Johan Hedberg @ 2013-07-31 7:57 UTC (permalink / raw)
To: Szymon Janc; +Cc: linux-bluetooth
Hi Szymon,
On Wed, Jul 31, 2013, Szymon Janc wrote:
> On Tuesday 09 of July 2013 09:40:00 Szymon Janc wrote:
> > According to open() manual one should include <sys/stat.h>.
> > This fix build with bionic library:
> >
> > target thumb C: libbluetoothd <= external/bluetooth/bluez/src/attrib-server.c
> > external/bluetooth/bluez/src/attrib-server.c: In function 'write_value':
> > external/bluetooth/bluez/src/attrib-server.c:922:26: error: 'S_IRUSR'
> > undeclared (first use in this function)
> > external/bluetooth/bluez/src/attrib-server.c:922:26: note: each undeclared
> > identifier is reported only once for each function it appears in
> > external/bluetooth/bluez/src/attrib-server.c:922:36: error: 'S_IWUSR'
> > undeclared (first use in this function)
>
> ping
This was applied already a few weeks ago (July 15th) and I even sent the
usual "applied" email about it.
Johan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-31 8:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-09 7:40 [PATCH] core: Use proper header for S_IRUSR/S_IWUSR Szymon Janc
2013-07-15 9:25 ` Johan Hedberg
2013-07-31 7:39 ` Szymon Janc
2013-07-31 7:57 ` Johan Hedberg
2013-07-31 8:32 ` Szymon Janc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox