* [PATCH 1/2] android/ipc: trivial: Remove empty line
@ 2014-01-22 16:03 Andrei Emeltchenko
2014-01-22 16:03 ` [PATCH 2/2] android/pan: Fix possible NULL dereference Andrei Emeltchenko
2014-01-22 16:40 ` [PATCH 1/2] android/ipc: trivial: Remove empty line Szymon Janc
0 siblings, 2 replies; 3+ messages in thread
From: Andrei Emeltchenko @ 2014-01-22 16:03 UTC (permalink / raw)
To: linux-bluetooth
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
android/hal-msg.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/android/hal-msg.h b/android/hal-msg.h
index cfb5460..d46b428 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -391,7 +391,6 @@ struct hal_cmd_pan_disconnect {
/* Notifications and confirmations */
-
#define HAL_POWER_OFF 0x00
#define HAL_POWER_ON 0x01
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] android/pan: Fix possible NULL dereference
2014-01-22 16:03 [PATCH 1/2] android/ipc: trivial: Remove empty line Andrei Emeltchenko
@ 2014-01-22 16:03 ` Andrei Emeltchenko
2014-01-22 16:40 ` [PATCH 1/2] android/ipc: trivial: Remove empty line Szymon Janc
1 sibling, 0 replies; 3+ messages in thread
From: Andrei Emeltchenko @ 2014-01-22 16:03 UTC (permalink / raw)
To: linux-bluetooth
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
It is better to return here since dev is not allocated and assigned NULL
value.
---
android/pan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/android/pan.c b/android/pan.c
index 4e04da0..adc5df7 100644
--- a/android/pan.c
+++ b/android/pan.c
@@ -439,7 +439,7 @@ static void nap_confirm_cb(GIOChannel *chan, gpointer data)
if (err) {
error("%s", err->message);
g_error_free(err);
- goto failed;
+ return;
}
DBG("incoming connect request from %s", address);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] android/ipc: trivial: Remove empty line
2014-01-22 16:03 [PATCH 1/2] android/ipc: trivial: Remove empty line Andrei Emeltchenko
2014-01-22 16:03 ` [PATCH 2/2] android/pan: Fix possible NULL dereference Andrei Emeltchenko
@ 2014-01-22 16:40 ` Szymon Janc
1 sibling, 0 replies; 3+ messages in thread
From: Szymon Janc @ 2014-01-22 16:40 UTC (permalink / raw)
To: Andrei Emeltchenko; +Cc: linux-bluetooth
Hi Andrei,
On Wednesday 22 of January 2014 18:03:57 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> ---
> android/hal-msg.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/android/hal-msg.h b/android/hal-msg.h
> index cfb5460..d46b428 100644
> --- a/android/hal-msg.h
> +++ b/android/hal-msg.h
> @@ -391,7 +391,6 @@ struct hal_cmd_pan_disconnect {
>
> /* Notifications and confirmations */
>
> -
> #define HAL_POWER_OFF 0x00
> #define HAL_POWER_ON 0x01
>
>
Both patches applied, thanks.
--
Best regards,
Szymon Janc
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-22 16:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-22 16:03 [PATCH 1/2] android/ipc: trivial: Remove empty line Andrei Emeltchenko
2014-01-22 16:03 ` [PATCH 2/2] android/pan: Fix possible NULL dereference Andrei Emeltchenko
2014-01-22 16:40 ` [PATCH 1/2] android/ipc: trivial: Remove empty line Szymon Janc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox