[PATCH BlueZ 1/2] android/pics-hogp: Fix having both types of discover set

[PATCH BlueZ 1/2] android/pics-hogp: Fix having both types of discover set

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

Currently the code discover by service handle and not by UUID.
---
 android/pics-hogp.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/android/pics-hogp.txt b/android/pics-hogp.txt
index 81e182c..6544b54 100644
--- a/android/pics-hogp.txt
+++ b/android/pics-hogp.txt
@@ -330,10 +330,10 @@ TSPC_HOGP_13_1	True		Attribute Protocol supported over LE Transport
 				(M)
 TSPC_HOGP_13_2	True		Generic Attribute Profile Client (M)
 TSPC_HOGP_13_3	True		Discover All Primary Services (C.1)
-TSPC_HOGP_13_4	True		Discover Primary Services by Service UUID (C.1)
+TSPC_HOGP_13_4	False		Discover Primary Services by Service UUID (C.1)
 TSPC_HOGP_13_5	True		Find Included Services (M)
 TSPC_HOGP_13_6	True		Discover All Characteristics of a Service (C.2)
-TSPC_HOGP_13_7	True		Discover Characteristics by UUID (C.2)
+TSPC_HOGP_13_7	False		Discover Characteristics by UUID (C.2)
 TSPC_HOGP_13_8	True		Discover All Characteristic Descriptors (M)
 TSPC_HOGP_13_9	True		Read Characteristic Value (M)
 TSPC_HOGP_13_10	True		Read using Characteristic UUID (O)
-- 
1.9.3

[PATCH BlueZ 2/2] android/pics-hogp: Do not set Suspend feature

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This requires integration with Android power management so leave it out
for now.
---
 android/pics-hogp.txt | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/android/pics-hogp.txt b/android/pics-hogp.txt
index 6544b54..aefdf2b 100644
--- a/android/pics-hogp.txt
+++ b/android/pics-hogp.txt
@@ -244,11 +244,11 @@ TSPC_HOGP_11_11a True		Report characteristic configuration with 0x0000
 
 TSPC_HOGP_11_12	True		Read HID Information characteristic
 					(M)
-TSPC_HOGP_11_13	True		Suspend State (O)
-TSPC_HOGP_11_14	True		Exit Suspend State (C.1)
-TSPC_HOGP_11_15	True		Write HID Control Point characteristic: Suspend
+TSPC_HOGP_11_13	False		Suspend State (O)
+TSPC_HOGP_11_14	False		Exit Suspend State (C.1)
+TSPC_HOGP_11_15	False		Write HID Control Point characteristic: Suspend
 					command (C.1)
-TSPC_HOGP_11_16	True		Write HID Control Point characteristic: Exit
+TSPC_HOGP_11_16	False		Write HID Control Point characteristic: Exit
 					Suspend command (C.1)
 TSPC_HOGP_11_17	True		Read Protocol Mode characteristic: Get Protocol
 					command (O)
-- 
1.9.3

Re: [PATCH BlueZ 1/2] android/pics-hogp: Fix having both types of discover set

[Szymon Janc]

Hi Luiz,

On Monday 23 of June 2014 15:46:16 Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> Currently the code discover by service handle and not by UUID.
> ---
>  android/pics-hogp.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/android/pics-hogp.txt b/android/pics-hogp.txt
> index 81e182c..6544b54 100644
> --- a/android/pics-hogp.txt
> +++ b/android/pics-hogp.txt
> @@ -330,10 +330,10 @@ TSPC_HOGP_13_1	True		Attribute Protocol supported over LE Transport
>  				(M)
>  TSPC_HOGP_13_2	True		Generic Attribute Profile Client (M)
>  TSPC_HOGP_13_3	True		Discover All Primary Services (C.1)
> -TSPC_HOGP_13_4	True		Discover Primary Services by Service UUID (C.1)
> +TSPC_HOGP_13_4	False		Discover Primary Services by Service UUID (C.1)
>  TSPC_HOGP_13_5	True		Find Included Services (M)
>  TSPC_HOGP_13_6	True		Discover All Characteristics of a Service (C.2)
> -TSPC_HOGP_13_7	True		Discover Characteristics by UUID (C.2)
> +TSPC_HOGP_13_7	False		Discover Characteristics by UUID (C.2)
>  TSPC_HOGP_13_8	True		Discover All Characteristic Descriptors (M)
>  TSPC_HOGP_13_9	True		Read Characteristic Value (M)
>  TSPC_HOGP_13_10	True		Read using Characteristic UUID (O)
> 

Both patches applied. Thanks.

-- 
Best regards, 
Szymon Janc