From: "Luiz Augusto von Dentz" <luiz.dentz@gmail.com>
To: "Fabien Chevalier" <fabchevalier@free.fr>
Cc: BlueZ development <bluez-devel@lists.sourceforge.net>,
Johan Hedberg <johan.hedberg@nokia.com>,
Brad Midgley <bmidgley@xmission.com>
Subject: Re: [Bluez-devel] [PATCH] Small headset.c fixes
Date: Sun, 14 Oct 2007 22:48:25 -0300 [thread overview]
Message-ID: <2d5a2c100710141848s5cc34c5bn71c077673114e924@mail.gmail.com> (raw)
In-Reply-To: <4712383C.9030200@free.fr>
Hi Fabien,
On 10/14/07, Fabien Chevalier <fabchevalier@free.fr> wrote:
> Hi All,
>
> Please find attached a rather small patch, that fixes some small issues
> i found while reading headset.c code:
> * make String representation of state consistent with the state name
> * send Stop() signal only if we transition from playing state, not
> playin_in_progress
> * remove unused io_id field.
Thought we should not emit Stopped signal please maintain the code
for sco cleanup (close_sco), sco connection may fail or disconnected
before we got a chance to change the state to playing.
Besides that it seems good to me.
-- =
Luiz Augusto von Dentz
Engenheiro de Computa=E7=E3o
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
next prev parent reply other threads:[~2007-10-15 1:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-14 15:39 [Bluez-devel] [PATCH] Small headset.c fixes Fabien Chevalier
2007-10-15 1:48 ` Luiz Augusto von Dentz [this message]
2007-10-15 9:25 ` Fabien Chevalier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d5a2c100710141848s5cc34c5bn71c077673114e924@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=bluez-devel@lists.sourceforge.net \
--cc=bmidgley@xmission.com \
--cc=fabchevalier@free.fr \
--cc=johan.hedberg@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox