* [PATCH 2/5] android/tester: Add SCAN_MODE=CONNECTABLE set prop success test case
2013-12-30 14:25 [PATCH 1/5] android/tester: Add BDADDR set prop fail test case Grzegorz Kolodziejczyk
@ 2013-12-30 14:25 ` Grzegorz Kolodziejczyk
2013-12-30 14:25 ` [PATCH 3/5] android/tester: Add BONDED_DEVICES set prop fail " Grzegorz Kolodziejczyk
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Grzegorz Kolodziejczyk @ 2013-12-30 14:25 UTC (permalink / raw)
To: linux-bluetooth
This adds SCAN_MODE property set to CONNECTABLE - success test case.
---
android/android-tester.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/android/android-tester.c b/android/android-tester.c
index d7ebc02..358c58b 100644
--- a/android/android-tester.c
+++ b/android/android-tester.c
@@ -809,6 +809,18 @@ static const struct generic_data bluetooth_setprop_bdaddr_invalid_test = {
.set_property.len = sizeof(setprop_bdaddr),
};
+static bt_scan_mode_t setprop_scanmode_connectable = BT_SCAN_MODE_CONNECTABLE;
+
+static const struct generic_data
+ bluetooth_setprop_scanmode_connectable_success_test = {
+ .expected_hal_cb.adapter_properties_cb = getprop_success_cb,
+ .expected_cb_count = 1,
+ .expected_adapter_status = BT_STATUS_SUCCESS,
+ .expected_property.type = BT_PROPERTY_ADAPTER_SCAN_MODE,
+ .expected_property.val = &setprop_scanmode_connectable,
+ .expected_property.len = sizeof(setprop_scanmode_connectable),
+};
+
static const struct generic_data bluetooth_discovery_start_success_test = {
.expected_hal_cb.discovery_state_changed_cb =
discovery_start_success_cb,
@@ -1158,6 +1170,19 @@ static void test_setprop_bdaddr_invalid(const void *test_data)
check_expected_status(adapter_status);
}
+static void test_setprop_scanmode_connectable_success(const void *test_data)
+{
+ struct test_data *data = tester_get_data();
+ const struct generic_data *test = data->test_data;
+ const bt_property_t *prop = &test->expected_property;
+ bt_status_t adapter_status;
+
+ init_test_conditions(data);
+
+ adapter_status = data->if_bluetooth->set_adapter_property(prop);
+ check_expected_status(adapter_status);
+}
+
static void test_discovery_start_success(const void *test_data)
{
struct test_data *data = tester_get_data();
@@ -1722,6 +1747,11 @@ int main(int argc, char *argv[])
setup_enabled_adapter,
test_setprop_bdaddr_invalid, teardown);
+ test_bredrle("Bluetooth Set SCAN_MODE CONNECTABLE - Success",
+ &bluetooth_setprop_scanmode_connectable_success_test,
+ setup_enabled_adapter,
+ test_setprop_scanmode_connectable_success, teardown);
+
test_bredrle("Bluetooth BREDR Discovery Start - Success",
&bluetooth_discovery_start_success_test,
setup_enabled_adapter,
--
1.8.4.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/5] android/tester: Add BONDED_DEVICES set prop fail test case
2013-12-30 14:25 [PATCH 1/5] android/tester: Add BDADDR set prop fail test case Grzegorz Kolodziejczyk
2013-12-30 14:25 ` [PATCH 2/5] android/tester: Add SCAN_MODE=CONNECTABLE set prop success " Grzegorz Kolodziejczyk
@ 2013-12-30 14:25 ` Grzegorz Kolodziejczyk
2013-12-30 14:25 ` [PATCH 4/5] android/tester: Add CLASS_OF_DEVICE get prop success " Grzegorz Kolodziejczyk
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Grzegorz Kolodziejczyk @ 2013-12-30 14:25 UTC (permalink / raw)
To: linux-bluetooth
This adds BONDED_DEVICES set property fail test case due to only
get possibility.
---
android/android-tester.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/android/android-tester.c b/android/android-tester.c
index 358c58b..15f427c 100644
--- a/android/android-tester.c
+++ b/android/android-tester.c
@@ -821,6 +821,18 @@ static const struct generic_data
.expected_property.len = sizeof(setprop_scanmode_connectable),
};
+static bt_bdaddr_t setprop_bonded_devices = {
+ .address = { 0x00, 0x01, 0x02, 0x03, 0x04, 0x05 },
+};
+
+static const struct generic_data
+ bluetooth_setprop_bonded_devices_invalid_test = {
+ .expected_adapter_status = BT_STATUS_FAIL,
+ .set_property.type = BT_PROPERTY_ADAPTER_BONDED_DEVICES,
+ .set_property.val = &setprop_bonded_devices,
+ .set_property.len = sizeof(setprop_bonded_devices),
+};
+
static const struct generic_data bluetooth_discovery_start_success_test = {
.expected_hal_cb.discovery_state_changed_cb =
discovery_start_success_cb,
@@ -1183,6 +1195,19 @@ static void test_setprop_scanmode_connectable_success(const void *test_data)
check_expected_status(adapter_status);
}
+static void test_setprop_bonded_devices_invalid(const void *test_data)
+{
+ struct test_data *data = tester_get_data();
+ const struct generic_data *test = data->test_data;
+ const bt_property_t *prop = &test->expected_property;
+ bt_status_t adapter_status;
+
+ init_test_conditions(data);
+
+ adapter_status = data->if_bluetooth->set_adapter_property(prop);
+ check_expected_status(adapter_status);
+}
+
static void test_discovery_start_success(const void *test_data)
{
struct test_data *data = tester_get_data();
@@ -1752,6 +1777,11 @@ int main(int argc, char *argv[])
setup_enabled_adapter,
test_setprop_scanmode_connectable_success, teardown);
+ test_bredrle("Bluetooth Set BONDED_DEVICES - Invalid",
+ &bluetooth_setprop_bonded_devices_invalid_test,
+ setup_enabled_adapter,
+ test_setprop_bonded_devices_invalid, teardown);
+
test_bredrle("Bluetooth BREDR Discovery Start - Success",
&bluetooth_discovery_start_success_test,
setup_enabled_adapter,
--
1.8.4.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/5] android/tester: Add CLASS_OF_DEVICE get prop success test case
2013-12-30 14:25 [PATCH 1/5] android/tester: Add BDADDR set prop fail test case Grzegorz Kolodziejczyk
2013-12-30 14:25 ` [PATCH 2/5] android/tester: Add SCAN_MODE=CONNECTABLE set prop success " Grzegorz Kolodziejczyk
2013-12-30 14:25 ` [PATCH 3/5] android/tester: Add BONDED_DEVICES set prop fail " Grzegorz Kolodziejczyk
@ 2013-12-30 14:25 ` Grzegorz Kolodziejczyk
2013-12-30 14:25 ` [PATCH 5/5] android/tester: Add TYPE_OF_DEVICE " Grzegorz Kolodziejczyk
2013-12-30 15:30 ` [PATCH 1/5] android/tester: Add BDADDR set prop fail " Szymon Janc
4 siblings, 0 replies; 6+ messages in thread
From: Grzegorz Kolodziejczyk @ 2013-12-30 14:25 UTC (permalink / raw)
To: linux-bluetooth
This adds CLASS_OF_DEVICE get property success test case.
---
android/android-tester.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/android/android-tester.c b/android/android-tester.c
index 15f427c..c548e35 100644
--- a/android/android-tester.c
+++ b/android/android-tester.c
@@ -833,6 +833,17 @@ static const struct generic_data
.set_property.len = sizeof(setprop_bonded_devices),
};
+static uint32_t getprop_cod = 0;
+
+static const struct generic_data bluetooth_getprop_cod_success_test = {
+ .expected_hal_cb.adapter_properties_cb = getprop_success_cb,
+ .expected_cb_count = 1,
+ .expected_adapter_status = BT_STATUS_SUCCESS,
+ .expected_property.type = BT_PROPERTY_CLASS_OF_DEVICE,
+ .expected_property.val = &getprop_cod,
+ .expected_property.len = sizeof(getprop_cod),
+};
+
static const struct generic_data bluetooth_discovery_start_success_test = {
.expected_hal_cb.discovery_state_changed_cb =
discovery_start_success_cb,
@@ -1208,6 +1219,19 @@ static void test_setprop_bonded_devices_invalid(const void *test_data)
check_expected_status(adapter_status);
}
+static void test_getprop_cod_success(const void *test_data)
+{
+ struct test_data *data = tester_get_data();
+ const struct generic_data *test = data->test_data;
+ const bt_property_t prop = test->expected_property;
+ bt_status_t adapter_status;
+
+ init_test_conditions(data);
+
+ adapter_status = data->if_bluetooth->get_adapter_property(prop.type);
+ check_expected_status(adapter_status);
+}
+
static void test_discovery_start_success(const void *test_data)
{
struct test_data *data = tester_get_data();
@@ -1782,6 +1806,11 @@ int main(int argc, char *argv[])
setup_enabled_adapter,
test_setprop_bonded_devices_invalid, teardown);
+ test_bredrle("Bluetooth Get CLASS_OF_DEVICE - Success",
+ &bluetooth_getprop_cod_success_test,
+ setup_enabled_adapter,
+ test_getprop_cod_success, teardown);
+
test_bredrle("Bluetooth BREDR Discovery Start - Success",
&bluetooth_discovery_start_success_test,
setup_enabled_adapter,
--
1.8.4.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 5/5] android/tester: Add TYPE_OF_DEVICE get prop success test case
2013-12-30 14:25 [PATCH 1/5] android/tester: Add BDADDR set prop fail test case Grzegorz Kolodziejczyk
` (2 preceding siblings ...)
2013-12-30 14:25 ` [PATCH 4/5] android/tester: Add CLASS_OF_DEVICE get prop success " Grzegorz Kolodziejczyk
@ 2013-12-30 14:25 ` Grzegorz Kolodziejczyk
2013-12-30 15:30 ` [PATCH 1/5] android/tester: Add BDADDR set prop fail " Szymon Janc
4 siblings, 0 replies; 6+ messages in thread
From: Grzegorz Kolodziejczyk @ 2013-12-30 14:25 UTC (permalink / raw)
To: linux-bluetooth
This adds TYPE_OF_DEVICE get property success test case.
---
android/android-tester.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/android/android-tester.c b/android/android-tester.c
index c548e35..c89b97a 100644
--- a/android/android-tester.c
+++ b/android/android-tester.c
@@ -844,6 +844,17 @@ static const struct generic_data bluetooth_getprop_cod_success_test = {
.expected_property.len = sizeof(getprop_cod),
};
+static bt_device_type_t getprop_tod = BT_DEVICE_DEVTYPE_BREDR;
+
+static const struct generic_data bluetooth_getprop_tod_success_test = {
+ .expected_hal_cb.adapter_properties_cb = getprop_success_cb,
+ .expected_cb_count = 1,
+ .expected_adapter_status = BT_STATUS_SUCCESS,
+ .expected_property.type = BT_PROPERTY_TYPE_OF_DEVICE,
+ .expected_property.val = &getprop_tod,
+ .expected_property.len = sizeof(getprop_tod),
+};
+
static const struct generic_data bluetooth_discovery_start_success_test = {
.expected_hal_cb.discovery_state_changed_cb =
discovery_start_success_cb,
@@ -1232,6 +1243,19 @@ static void test_getprop_cod_success(const void *test_data)
check_expected_status(adapter_status);
}
+static void test_getprop_tod_success(const void *test_data)
+{
+ struct test_data *data = tester_get_data();
+ const struct generic_data *test = data->test_data;
+ const bt_property_t prop = test->expected_property;
+ bt_status_t adapter_status;
+
+ init_test_conditions(data);
+
+ adapter_status = data->if_bluetooth->get_adapter_property(prop.type);
+ check_expected_status(adapter_status);
+}
+
static void test_discovery_start_success(const void *test_data)
{
struct test_data *data = tester_get_data();
@@ -1811,6 +1835,11 @@ int main(int argc, char *argv[])
setup_enabled_adapter,
test_getprop_cod_success, teardown);
+ test_bredrle("Bluetooth Get TYPE_OF_DEVICE - Success",
+ &bluetooth_getprop_tod_success_test,
+ setup_enabled_adapter,
+ test_getprop_tod_success, teardown);
+
test_bredrle("Bluetooth BREDR Discovery Start - Success",
&bluetooth_discovery_start_success_test,
setup_enabled_adapter,
--
1.8.4.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/5] android/tester: Add BDADDR set prop fail test case
2013-12-30 14:25 [PATCH 1/5] android/tester: Add BDADDR set prop fail test case Grzegorz Kolodziejczyk
` (3 preceding siblings ...)
2013-12-30 14:25 ` [PATCH 5/5] android/tester: Add TYPE_OF_DEVICE " Grzegorz Kolodziejczyk
@ 2013-12-30 15:30 ` Szymon Janc
4 siblings, 0 replies; 6+ messages in thread
From: Szymon Janc @ 2013-12-30 15:30 UTC (permalink / raw)
To: Grzegorz Kolodziejczyk; +Cc: linux-bluetooth
Hi Grzegorz,
On Monday 30 December 2013 15:25:05 Grzegorz Kolodziejczyk wrote:
> This adds BDADDR set property fail test case due to only get
> possibility.
> ---
> android/android-tester.c | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/android/android-tester.c b/android/android-tester.c
> index ee23fff..d7ebc02 100644
> --- a/android/android-tester.c
> +++ b/android/android-tester.c
> @@ -798,6 +798,17 @@ static const struct generic_data
> .set_property.len = sizeof(setprop_remote_service),
> };
>
> +static bt_bdaddr_t setprop_bdaddr = {
> + .address = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 },
> +};
> +
> +static const struct generic_data bluetooth_setprop_bdaddr_invalid_test = {
> + .expected_adapter_status = BT_STATUS_FAIL,
> + .set_property.type = BT_PROPERTY_BDADDR,
> + .set_property.val = &setprop_bdaddr,
> + .set_property.len = sizeof(setprop_bdaddr),
> +};
> +
> static const struct generic_data bluetooth_discovery_start_success_test = {
> .expected_hal_cb.discovery_state_changed_cb =
> discovery_start_success_cb,
> @@ -1134,6 +1145,19 @@ static void test_setprop_service_record_invalid(const
> void *test_data) check_expected_status(adapter_status);
> }
>
> +static void test_setprop_bdaddr_invalid(const void *test_data)
> +{
> + struct test_data *data = tester_get_data();
> + const struct generic_data *test = data->test_data;
> + const bt_property_t *prop = &test->expected_property;
> + bt_status_t adapter_status;
> +
> + init_test_conditions(data);
> +
> + adapter_status = data->if_bluetooth->set_adapter_property(prop);
> + check_expected_status(adapter_status);
> +}
> +
> static void test_discovery_start_success(const void *test_data)
> {
> struct test_data *data = tester_get_data();
> @@ -1693,6 +1717,11 @@ int main(int argc, char *argv[])
> setup_enabled_adapter,
> test_setprop_service_record_invalid, teardown);
>
> + test_bredrle("Bluetooth Set BDADDR - Invalid",
> + &bluetooth_setprop_bdaddr_invalid_test,
> + setup_enabled_adapter,
> + test_setprop_bdaddr_invalid, teardown);
> +
> test_bredrle("Bluetooth BREDR Discovery Start - Success",
> &bluetooth_discovery_start_success_test,
> setup_enabled_adapter,
All patches applied, thanks.
--
Szymon K. Janc
szymon.janc@gmail.com
^ permalink raw reply [flat|nested] 6+ messages in thread