* Advertising api - local name missing
@ 2015-07-28 15:01 dogan yazar
2015-07-29 7:14 ` Szymon Janc
0 siblings, 1 reply; 3+ messages in thread
From: dogan yazar @ 2015-07-28 15:01 UTC (permalink / raw)
To: linux-bluetooth
Advertising api does not have a field to set shortened or complete
local name. Daemon sets the local name (bluetoothd[828]:
src/adapter.c:local_name_changed_callback() Current alias: foo)
but when I run test/example-advertisement the local name is not sent
in the advertisement.
Is this a deliberate design choice, or a bug or just a low priority
feature to be implemented later?
Thanks
Dogan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Advertising api - local name missing
2015-07-28 15:01 Advertising api - local name missing dogan yazar
@ 2015-07-29 7:14 ` Szymon Janc
2015-07-29 13:49 ` Marcel Holtmann
0 siblings, 1 reply; 3+ messages in thread
From: Szymon Janc @ 2015-07-29 7:14 UTC (permalink / raw)
To: dogan yazar; +Cc: linux-bluetooth
Hi Dogan,
On Tuesday 28 of July 2015 17:01:53 dogan yazar wrote:
> Advertising api does not have a field to set shortened or complete
> local name. Daemon sets the local name (bluetoothd[828]:
> src/adapter.c:local_name_changed_callback() Current alias: foo)
> but when I run test/example-advertisement the local name is not sent
> in the advertisement.
> Is this a deliberate design choice, or a bug or just a low priority
> feature to be implemented later?
Name and appearance would be placed in scan response. Kernel already allows to
set flags for this but for some reason this is not exposed in D-Bus.
This is similar to TX Power which is exposed in D-Bus API so you may look at
this if you are willing to add support for name.
Also note that first instance controller by kernel should already have local
name included in scan response.
--
BR
Szymon Janc
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Advertising api - local name missing
2015-07-29 7:14 ` Szymon Janc
@ 2015-07-29 13:49 ` Marcel Holtmann
0 siblings, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2015-07-29 13:49 UTC (permalink / raw)
To: Szymon Janc; +Cc: dogan yazar, linux-bluetooth
Hi Szymon,
>> Advertising api does not have a field to set shortened or complete
>> local name. Daemon sets the local name (bluetoothd[828]:
>> src/adapter.c:local_name_changed_callback() Current alias: foo)
>> but when I run test/example-advertisement the local name is not sent
>> in the advertisement.
>> Is this a deliberate design choice, or a bug or just a low priority
>> feature to be implemented later?
>
> Name and appearance would be placed in scan response. Kernel already allows to
> set flags for this but for some reason this is not exposed in D-Bus.
> This is similar to TX Power which is exposed in D-Bus API so you may look at
> this if you are willing to add support for name.
>
> Also note that first instance controller by kernel should already have local
> name included in scan response.
have you checked the supported advertising flags by the kernel. I think we do not support the name inclusion by the kernel. Meaning bluetoothd would have to do that for us and manually put it in the scan response data.
This is something that could be added to the kernel. It is specified by mgmt-api.txt, but not implemented yet.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-29 13:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-28 15:01 Advertising api - local name missing dogan yazar
2015-07-29 7:14 ` Szymon Janc
2015-07-29 13:49 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox