public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [Bluez-devel] Patch to add support for Apple Aluminum Bluetooth Keyboard
@ 2007-10-26 17:46 Dean McCarron
  2007-10-31 16:32 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: Dean McCarron @ 2007-10-26 17:46 UTC (permalink / raw)
  To: bluez-devel


Here's a trivial patch to add support for Apple's aluminum
bluetooth keyboard. The keyboard works out of the the box,
but this enables the Fn modifier key so that a few useful
keys (namely pageup/pagedown using Fn+arrows).

Apologies if I'm not conforming to local patch formatting
conventions, but the needed change is pretty obvious regardless.

--- linux-2.6.23.1/net/bluetooth/hidp/core.c.orig       2007-10-26 
10:28:59.000000000 -0700
+++ linux-2.6.23.1/net/bluetooth/hidp/core.c    2007-10-26 
10:30:59.000000000 -0700
@@ -686,6 +686,7 @@
  } hidp_blacklist[] = {
         /* Apple wireless Mighty Mouse */
         { 0x05ac, 0x030c, HID_QUIRK_MIGHTYMOUSE | 
HID_QUIRK_INVERT_HWHEEL },
+       { 0x05ac, 0x022c, HID_QUIRK_POWERBOOK_HAS_FN },

         { }     /* Terminating entry */
  };


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Bluez-devel] Patch to add support for Apple Aluminum Bluetooth Keyboard
  2007-10-26 17:46 [Bluez-devel] Patch to add support for Apple Aluminum Bluetooth Keyboard Dean McCarron
@ 2007-10-31 16:32 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2007-10-31 16:32 UTC (permalink / raw)
  To: BlueZ development

Hi Dean,

> Here's a trivial patch to add support for Apple's aluminum
> bluetooth keyboard. The keyboard works out of the the box,
> but this enables the Fn modifier key so that a few useful
> keys (namely pageup/pagedown using Fn+arrows).
> 
> Apologies if I'm not conforming to local patch formatting
> conventions, but the needed change is pretty obvious regardless.

patch looks fine, but can you please re-send it with a proper
Signed-off-by line. Remember that this is a kernel patch and it has to
follow the guidelines of the kernel. Otherwise I simply have to ignore
your credit for this patch.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-10-31 16:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-26 17:46 [Bluez-devel] Patch to add support for Apple Aluminum Bluetooth Keyboard Dean McCarron
2007-10-31 16:32 ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox