From: Szymon Janc <szymon.janc@gmail.com>
To: Lukasz Rymanowski <lukasz.rymanowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org, szymon.janc@tieto.com
Subject: Re: [PATCH] android/gatt: Fix regression introduced by b278efa5
Date: Mon, 31 Mar 2014 00:07:09 +0200 [thread overview]
Message-ID: <4849796.2zhvJRlmh5@athlon> (raw)
In-Reply-To: <1396159471-1773-1-git-send-email-lukasz.rymanowski@tieto.com>
Hi Łukasz,
On Sunday 30 March 2014 08:04:31 Lukasz Rymanowski wrote:
> Seems that GattService onScanResult is only looking into remote uuids in
> adverisement data. No device object is created in the Android framework,
> Therefore we need to send regular device found for BLE devices as well.
> Otherwise the Android GATT application will not be aware of remote device
> properties like name etc.
> ---
> android/bluetooth.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/android/bluetooth.c b/android/bluetooth.c
> index 690aaf6..734adeb 100644
> --- a/android/bluetooth.c
> +++ b/android/bluetooth.c
> @@ -1331,9 +1331,6 @@ static bool is_new_device(const struct device *dev)
> if (dev->found)
> return false;
>
> - if (adapter.cur_discovery_type != SCAN_TYPE_DUAL)
> - return false;
> -
> if (dev->bond_state == HAL_BOND_STATE_BONDED)
> return false;
Applied, thanks.
--
Szymon K. Janc
szymon.janc@gmail.com
prev parent reply other threads:[~2014-03-30 22:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-30 6:04 [PATCH] android/gatt: Fix regression introduced by b278efa5 Lukasz Rymanowski
2014-03-30 22:07 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4849796.2zhvJRlmh5@athlon \
--to=szymon.janc@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lukasz.rymanowski@tieto.com \
--cc=szymon.janc@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox