* [PATCH] android/gatt: Fix regression introduced by b278efa5
@ 2014-03-30 6:04 Lukasz Rymanowski
2014-03-30 22:07 ` Szymon Janc
0 siblings, 1 reply; 2+ messages in thread
From: Lukasz Rymanowski @ 2014-03-30 6:04 UTC (permalink / raw)
To: linux-bluetooth; +Cc: szymon.janc, Lukasz Rymanowski
Seems that GattService onScanResult is only looking into remote uuids in
adverisement data. No device object is created in the Android framework,
Therefore we need to send regular device found for BLE devices as well.
Otherwise the Android GATT application will not be aware of remote device
properties like name etc.
---
android/bluetooth.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/android/bluetooth.c b/android/bluetooth.c
index 690aaf6..734adeb 100644
--- a/android/bluetooth.c
+++ b/android/bluetooth.c
@@ -1331,9 +1331,6 @@ static bool is_new_device(const struct device *dev)
if (dev->found)
return false;
- if (adapter.cur_discovery_type != SCAN_TYPE_DUAL)
- return false;
-
if (dev->bond_state == HAL_BOND_STATE_BONDED)
return false;
--
1.8.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] android/gatt: Fix regression introduced by b278efa5
2014-03-30 6:04 [PATCH] android/gatt: Fix regression introduced by b278efa5 Lukasz Rymanowski
@ 2014-03-30 22:07 ` Szymon Janc
0 siblings, 0 replies; 2+ messages in thread
From: Szymon Janc @ 2014-03-30 22:07 UTC (permalink / raw)
To: Lukasz Rymanowski; +Cc: linux-bluetooth, szymon.janc
Hi Łukasz,
On Sunday 30 March 2014 08:04:31 Lukasz Rymanowski wrote:
> Seems that GattService onScanResult is only looking into remote uuids in
> adverisement data. No device object is created in the Android framework,
> Therefore we need to send regular device found for BLE devices as well.
> Otherwise the Android GATT application will not be aware of remote device
> properties like name etc.
> ---
> android/bluetooth.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/android/bluetooth.c b/android/bluetooth.c
> index 690aaf6..734adeb 100644
> --- a/android/bluetooth.c
> +++ b/android/bluetooth.c
> @@ -1331,9 +1331,6 @@ static bool is_new_device(const struct device *dev)
> if (dev->found)
> return false;
>
> - if (adapter.cur_discovery_type != SCAN_TYPE_DUAL)
> - return false;
> -
> if (dev->bond_state == HAL_BOND_STATE_BONDED)
> return false;
Applied, thanks.
--
Szymon K. Janc
szymon.janc@gmail.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-30 22:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-30 6:04 [PATCH] android/gatt: Fix regression introduced by b278efa5 Lukasz Rymanowski
2014-03-30 22:07 ` Szymon Janc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox