[PATCH] Quirk for Apple Aluminum Bluetooth keyboard FN key

[PATCH] Quirk for Apple Aluminum Bluetooth keyboard FN key

[Mario Limonciello]

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

This patch was present in Ubuntu Hardy, but got dropped by accident in
Intrepid and never submitted upstream.  It adds a quirk enabling the FN
key on the Apple Aluminum Bluetooth Wireless Keyboard.


Signed-off-by: Mario Limonciello <Mario_Limonciello@Dell.com>
---
 net/bluetooth/hidp/core.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index 96434d7..fc6e643 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -684,6 +684,8 @@ static const struct {
 } hidp_blacklist[] = {
     /* Apple wireless Mighty Mouse */
     { 0x05ac, 0x030c, HID_QUIRK_MIGHTYMOUSE | HID_QUIRK_INVERT_HWHEEL },
+    /* Apple wireless Bluetooth Keyboard */
+    { 0x05ac, 0x022c, HID_QUIRK_APPLE_HAS_FN },
 
     { }    /* Terminating entry */
 };
-- 
1.5.4.3


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

Re: [PATCH] Quirk for Apple Aluminum Bluetooth keyboard FN key

[Marcel Holtmann]

Hi Mario,

> This patch was present in Ubuntu Hardy, but got dropped by accident in
> Intrepid and never submitted upstream.  It adds a quirk enabling the FN
> key on the Apple Aluminum Bluetooth Wireless Keyboard.

yeah, the Ubuntu kernel team is pretty bad in getting patches back to
upstream. However in this case please check with the upstream kernel
since the HID bus makes all quirks general to the HID subsystem.

Regards

Marcel

Re: [PATCH] Quirk for Apple Aluminum Bluetooth keyboard FN key

[Mario Limonciello]

[-- Attachment #1.1: Type: text/plain, Size: 839 bytes --]

Hi Marcel:

Marcel Holtmann wrote:
> Hi Mario,
> yeah, the Ubuntu kernel team is pretty bad in getting patches back to
> upstream. However in this case please check with the upstream kernel
> since the HID bus makes all quirks general to the HID subsystem.
>
> Regards
>
> Marcel
Yeah, that's what I was thinking should be happening, and a little bit
shocked that it didn't work properly since I saw a variation of this
quirk in the hid source files already.  I was a little thrown off though
since there is already a quirk for the mighty mouse sitting in this
section that I was patching, so it seemed sensible to add the quirk for
the keyboard there too.  I'll try to investigate why those quirks aren't
carrying over properly.

Regards
-- 
Mario Limonciello
*Dell | Linux Engineering*
mario_limonciello@dell.com

[-- Attachment #1.2: Type: text/html, Size: 1809 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]