public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 1/2] btsdio: free sk_buff with kfree_skb
@ 2008-10-26  7:16 Sergio Luis
  2008-10-27  6:09 ` David Miller
  0 siblings, 1 reply; 4+ messages in thread
From: Sergio Luis @ 2008-10-26  7:16 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: linux-bluetooth, linux-kernel

free sk_buff with kfree_skb, instead of kree
 
Signed-off-by: Sergio Luis <sergio@larces.uece.br>
Cc: Marcel Holtmann <marcel@holtmann.org>

drivers/bluetooth/btsdio.c         |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
index 58630cc..cda6c7c 100644
--- a/drivers/bluetooth/btsdio.c
+++ b/drivers/bluetooth/btsdio.c
@@ -152,7 +152,7 @@ static int btsdio_rx_packet(struct btsdio_data *data)
 
 	err = sdio_readsb(data->func, skb->data, REG_RDAT, len - 4);
 	if (err < 0) {
-		kfree(skb);
+		kfree_skb(skb);
 		return err;
 	}
 

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [patch 1/2] btsdio: free sk_buff with kfree_skb
  2008-10-26  7:16 [patch 1/2] btsdio: free sk_buff with kfree_skb Sergio Luis
@ 2008-10-27  6:09 ` David Miller
  2008-10-27  8:37   ` Marcel Holtmann
  0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2008-10-27  6:09 UTC (permalink / raw)
  To: sergio; +Cc: marcel, linux-bluetooth, linux-kernel

From: Sergio Luis <sergio@larces.uece.br>
Date: Sun, 26 Oct 2008 04:16:29 -0300

> free sk_buff with kfree_skb, instead of kree
>  
> Signed-off-by: Sergio Luis <sergio@larces.uece.br>

Since this is pretty obvious I'm applying this directly, I hope
Marcel doesn't mind :-)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch 1/2] btsdio: free sk_buff with kfree_skb
  2008-10-27  6:09 ` David Miller
@ 2008-10-27  8:37   ` Marcel Holtmann
  0 siblings, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2008-10-27  8:37 UTC (permalink / raw)
  To: David Miller; +Cc: sergio, linux-bluetooth, linux-kernel

Hi Dave,

> > free sk_buff with kfree_skb, instead of kree
> >  
> > Signed-off-by: Sergio Luis <sergio@larces.uece.br>
> 
> Since this is pretty obvious I'm applying this directly, I hope
> Marcel doesn't mind :-)

that is fine with me. No need to run this through me.

Regards

Marcel



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] btsdio: free sk_buff with kfree_skb
  2009-02-14 11:02 [PATCH 0/2] btsdio fixes on error path Tomas Winkler
@ 2009-02-14 11:02 ` Tomas Winkler
  0 siblings, 0 replies; 4+ messages in thread
From: Tomas Winkler @ 2009-02-14 11:02 UTC (permalink / raw)
  To: stable, marcel; +Cc: linux-bluetooth, Sergio Luis

From: Sergio Luis <sergio@larces.uece.br>

free sk_buff with kfree_skb, instead of kree

Signed-off-by: Sergio Luis <sergio@larces.uece.br>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/bluetooth/btsdio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
index 58630cc..cda6c7c 100644
--- a/drivers/bluetooth/btsdio.c
+++ b/drivers/bluetooth/btsdio.c
@@ -152,7 +152,7 @@ static int btsdio_rx_packet(struct btsdio_data *data)
 
 	err = sdio_readsb(data->func, skb->data, REG_RDAT, len - 4);
 	if (err < 0) {
-		kfree(skb);
+		kfree_skb(skb);
 		return err;
 	}
 
-- 
1.6.0.6

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-02-14 11:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-26  7:16 [patch 1/2] btsdio: free sk_buff with kfree_skb Sergio Luis
2008-10-27  6:09 ` David Miller
2008-10-27  8:37   ` Marcel Holtmann
  -- strict thread matches above, loose matches on Subject: below --
2009-02-14 11:02 [PATCH 0/2] btsdio fixes on error path Tomas Winkler
2009-02-14 11:02 ` [PATCH 1/2] btsdio: free sk_buff with kfree_skb Tomas Winkler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox