Support for Ralink RT3298 Bluetooth Module

Linux bluetooth development
 help / color / mirror / Atom feed

* Support for Ralink RT3298 Bluetooth Module
@ 2013-05-23 12:34 Mohit
  2013-05-23 17:00 ` Marcel Holtmann
  0 siblings, 1 reply; 3+ messages in thread
From: Mohit @ 2013-05-23 12:34 UTC (permalink / raw)
  To: linux-bluetooth

Hello,
There was a proprietary driver for Ralink RT3298 bluetooth module that 
compiled in kernel 3.2 but stopped compiling in kernel 3.3, 3.4 or 3.5 
which is available here 
http://downloads.zotac.com/mediadrivers/mb/download/NB087_Ubuntu.zip. I 
get the following output when compiling in kernel 3.5 :

mohit@linux-xmln:~/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3> make
make -C /lib/modules/3.7.10-1.4-desktop/build M=/home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3 modules
make[1]: Entering directory `/usr/src/linux-3.7.10-1.4-obj/x86_64/desktop'
   CC [M]  /home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_main.o
   CC [M]  /home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_init.o
   CC [M]  /home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.o
/home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.c: In function ‘rtbt_pci_suspend’:
/home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.c:60:43: error: ‘struct hci_dev’ has no member named ‘driver_data’
/home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.c: In function ‘rtbt_pci_resume’:
/home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.c:87:46: error: ‘struct hci_dev’ has no member named ‘driver_data’
/home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.c: In function ‘rtbt_pci_probe’:
/home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.c:198:1: warning: label ‘err_hps_iface’ defined but not used [-Wunused-label]
/home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.c: In function ‘rtbt_pci_remove’:
/home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.c:240:43: error: ‘struct hci_dev’ has no member named ‘driver_data’
/home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.c: In function ‘BthIsr’:
/home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.c:346:40: error: ‘struct hci_dev’ has no member named ‘driver_data’
make[4]: *** [/home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.o] Error 1
make[3]: *** [_module_/home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3] Error 2
make[2]: *** [sub-make] Error 2
make[1]: *** [all] Error 2
make[1]: Leaving directory `/usr/src/linux-3.7.10-1.4-obj/x86_64/desktop'
make: *** [all] Error 2



-- 









--
******************************************************************************************************************************************************************
"This e-Mail may contain proprietary and confidential information and is 
sent for the intended  recipient(s) only. If, by an addressing or 
transmission error, this mail has been misdirected to you, you are 
requested to delete this mail immediately.You are also hereby notified that 
any use, any form of reproduction, dissemination, copying, disclosure, 
modification, distribution and/or publication of this e-mail 
message,contents or its attachment(s) other than by its intended 
recipient(s) is strictly prohibited.Any opinions expressed in this email 
are those of the individual and not necessarily of the organization.Before 
opening attachment(s), please scan for viruses."
**********************************************************************************************************************************************************************


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Support for Ralink RT3298 Bluetooth Module
  2013-05-23 12:34 Support for Ralink RT3298 Bluetooth Module Mohit
@ 2013-05-23 17:00 ` Marcel Holtmann
       [not found]   ` <51A20F59.3060403@pdm.ac.in>
  0 siblings, 1 reply; 3+ messages in thread
From: Marcel Holtmann @ 2013-05-23 17:00 UTC (permalink / raw)
  To: Mohit; +Cc: linux-bluetooth

Hi Mohit,

> There was a proprietary driver for Ralink RT3298 bluetooth module that compiled in kernel 3.2 but stopped compiling in kernel 3.3, 3.4 or 3.5 which is available here http://downloads.zotac.com/mediadrivers/mb/download/NB087_Ubuntu.zip. I get the following output when compiling in kernel 3.5 :

if neither Ralink nor Ubuntu feels the need to get this upstream, why would we care if this compiles or not. This is not how Linux works. The community is not responsible for out-of-tree drivers.

> mohit@linux-xmln:~/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3> make
> make -C /lib/modules/3.7.10-1.4-desktop/build M=/home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3 modules
> make[1]: Entering directory `/usr/src/linux-3.7.10-1.4-obj/x86_64/desktop'
>  CC [M]  /home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_main.o
>  CC [M]  /home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_init.o
>  CC [M]  /home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.o
> /home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.c: In function ‘rtbt_pci_suspend’:
> /home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.c:60:43: error: ‘struct hci_dev’ has no member named ‘driver_data’


This change was made over a year ago. So seems nobody really cares enough.

commit 155961e8001719af6d87cbcc961111e8ce477843
Author: David Herrmann <dh.herrmann@googlemail.com>
Date:   Thu Feb 9 21:58:32 2012 +0100

    Bluetooth: Remove hci_dev->driver_data
    
    The linux device model provides dev_set/get_drvdata so we can use this
    to save private driver data.
    This also removes several unnecessary casts.
    
    Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
    Acked-by: Marcel Holtmann <marcel@holtmann.org>
    Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>

Regards

Marcel


^ permalink raw reply	[flat|nested] 3+ messages in thread

[parent not found: <51A20F59.3060403@pdm.ac.in>]

* Re: Support for Ralink RT3298 Bluetooth Module
       [not found]   ` <51A20F59.3060403@pdm.ac.in>
@ 2013-05-26 22:40     ` Marcel Holtmann
  0 siblings, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2013-05-26 22:40 UTC (permalink / raw)
  To: Mohit; +Cc: linux-bluetooth

Hi Mohit,

replying to me in private and not CC the mailing from a previous thread is not acceptable behavior on this mailing list. Please learn to press Reply All button.

>>> There was a proprietary driver for Ralink RT3298 bluetooth module that compiled in kernel 3.2 but stopped compiling in kernel 3.3, 3.4 or 3.5 which is available here http://downloads.zotac.com/mediadrivers/mb/download/NB087_Ubuntu.zip. I get the following output when compiling in kernel 3.5 :
>> if neither Ralink nor Ubuntu feels the need to get this upstream, why would we care if this compiles or not. This is not how Linux works. The community is not responsible for out-of-tree drivers.
>> 
>>> mohit@linux-xmln:~/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3> make
>>> make -C /lib/modules/3.7.10-1.4-desktop/build M=/home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3 modules
>>> make[1]: Entering directory `/usr/src/linux-3.7.10-1.4-obj/x86_64/desktop'
>>>  CC [M]  /home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_main.o
>>>  CC [M]  /home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_init.o
>>>  CC [M]  /home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.o
>>> /home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.c: In function ‘rtbt_pci_suspend’:
>>> /home/mohit/Downloads/NB087_Ubuntu/NB087_BT_ubuntu_release/rtbth_v3.9.3/rtbth_v3.9.3/rtbth_core_pci.c:60:43: error: ‘struct hci_dev’ has no member named ‘driver_data’
>> 
>> This change was made over a year ago. So seems nobody really cares enough.
>> 
>> commit 155961e8001719af6d87cbcc961111e8ce477843
>> Author: David Herrmann <dh.herrmann@googlemail.com>
>> Date:   Thu Feb 9 21:58:32 2012 +0100
>> 
>>     Bluetooth: Remove hci_dev->driver_data
>>          The linux device model provides dev_set/get_drvdata so we can use this
>>     to save private driver data.
>>     This also removes several unnecessary casts.
>>          Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
>>     Acked-by: Marcel Holtmann <marcel@holtmann.org>
>>     Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
>> 
> I removed hci_dev->driver_data, but there needs to be an expression in its place. Should i replace it with dev_set->driver_data or get_drvdata->driver_data??

I have no intention on trying to make this driver work. Please contact Ralink to provide you an updated driver or even better have some submitted this one upstream.

Regards

Marcel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-05-26 22:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-23 12:34 Support for Ralink RT3298 Bluetooth Module Mohit
2013-05-23 17:00 ` Marcel Holtmann
     [not found]   ` <51A20F59.3060403@pdm.ac.in>
2013-05-26 22:40     ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox