* [BlueZ PATCH v3] doc:Adding Roles property
@ 2020-04-23 14:23 Alain Michaud
2020-04-23 14:42 ` Szymon Janc
0 siblings, 1 reply; 5+ messages in thread
From: Alain Michaud @ 2020-04-23 14:23 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Alain Michaud
This change adds a new property to indicate the support for concurrent
roles which means that the controller has reported the appropriate
LE_Supported_States (hdev->le_states) and that the controller's driver
has reported correctly handling the various reported states.
---
doc/adapter-api.txt | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
index acae032d9..1a7255750 100644
--- a/doc/adapter-api.txt
+++ b/doc/adapter-api.txt
@@ -326,3 +326,11 @@ Properties string Address [readonly]
Local Device ID information in modalias format
used by the kernel and udev.
+
+ array{string} Roles [readonly]
+
+ List of supported roles. Possible values:
+ "central": Supports the central role.
+ "peripheral": Supports the peripheral role.
+ "central-peripheral": Supports both roles
+ concurrently.
--
2.26.1.301.g55bc3eb7cb9-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [BlueZ PATCH v3] doc:Adding Roles property
2020-04-23 14:23 [BlueZ PATCH v3] doc:Adding Roles property Alain Michaud
@ 2020-04-23 14:42 ` Szymon Janc
2020-04-23 14:51 ` Alain Michaud
0 siblings, 1 reply; 5+ messages in thread
From: Szymon Janc @ 2020-04-23 14:42 UTC (permalink / raw)
To: linux-bluetooth, Alain Michaud; +Cc: Alain Michaud
Hi,
On Thursday, 23 April 2020 16:23:05 CEST Alain Michaud wrote:
> This change adds a new property to indicate the support for concurrent
> roles which means that the controller has reported the appropriate
> LE_Supported_States (hdev->le_states) and that the controller's driver
> has reported correctly handling the various reported states.
> ---
>
> doc/adapter-api.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> index acae032d9..1a7255750 100644
> --- a/doc/adapter-api.txt
> +++ b/doc/adapter-api.txt
> @@ -326,3 +326,11 @@ Properties string Address [readonly]
>
> Local Device ID information in modalias format
> used by the kernel and udev.
> +
> + array{string} Roles [readonly]
> +
> + List of supported roles. Possible values:
> + "central": Supports the central role.
> + "peripheral": Supports the peripheral
role.
> + "central-peripheral": Supports both
roles
> +
concurrently.
If this is an array os strings why central-peripheral is needed?
--
pozdrawiam
Szymon Janc
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BlueZ PATCH v3] doc:Adding Roles property
2020-04-23 14:42 ` Szymon Janc
@ 2020-04-23 14:51 ` Alain Michaud
2020-04-27 14:57 ` Alain Michaud
0 siblings, 1 reply; 5+ messages in thread
From: Alain Michaud @ 2020-04-23 14:51 UTC (permalink / raw)
To: Szymon Janc; +Cc: BlueZ, Alain Michaud
On Thu, Apr 23, 2020 at 10:42 AM Szymon Janc <szymon.janc@codecoup.pl> wrote:
>
> Hi,
>
> On Thursday, 23 April 2020 16:23:05 CEST Alain Michaud wrote:
> > This change adds a new property to indicate the support for concurrent
> > roles which means that the controller has reported the appropriate
> > LE_Supported_States (hdev->le_states) and that the controller's driver
> > has reported correctly handling the various reported states.
> > ---
> >
> > doc/adapter-api.txt | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> > index acae032d9..1a7255750 100644
> > --- a/doc/adapter-api.txt
> > +++ b/doc/adapter-api.txt
> > @@ -326,3 +326,11 @@ Properties string Address [readonly]
> >
> > Local Device ID information in modalias format
> > used by the kernel and udev.
> > +
> > + array{string} Roles [readonly]
> > +
> > + List of supported roles. Possible values:
> > + "central": Supports the central role.
> > + "peripheral": Supports the peripheral
> role.
> > + "central-peripheral": Supports both
> roles
> > +
> concurrently.
>
> If this is an array os strings why central-peripheral is needed?
The keyword in the description is "concurrently". Not all adapters
support being peripheral and central concurrently.
>
>
> --
> pozdrawiam
> Szymon Janc
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BlueZ PATCH v3] doc:Adding Roles property
2020-04-23 14:51 ` Alain Michaud
@ 2020-04-27 14:57 ` Alain Michaud
2020-04-27 16:47 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 5+ messages in thread
From: Alain Michaud @ 2020-04-27 14:57 UTC (permalink / raw)
To: Szymon Janc; +Cc: BlueZ, Alain Michaud
Any more feedback on this Api design?
On Thu, Apr 23, 2020 at 10:51 AM Alain Michaud <alainmichaud@google.com> wrote:
>
> On Thu, Apr 23, 2020 at 10:42 AM Szymon Janc <szymon.janc@codecoup.pl> wrote:
> >
> > Hi,
> >
> > On Thursday, 23 April 2020 16:23:05 CEST Alain Michaud wrote:
> > > This change adds a new property to indicate the support for concurrent
> > > roles which means that the controller has reported the appropriate
> > > LE_Supported_States (hdev->le_states) and that the controller's driver
> > > has reported correctly handling the various reported states.
> > > ---
> > >
> > > doc/adapter-api.txt | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> > > index acae032d9..1a7255750 100644
> > > --- a/doc/adapter-api.txt
> > > +++ b/doc/adapter-api.txt
> > > @@ -326,3 +326,11 @@ Properties string Address [readonly]
> > >
> > > Local Device ID information in modalias format
> > > used by the kernel and udev.
> > > +
> > > + array{string} Roles [readonly]
> > > +
> > > + List of supported roles. Possible values:
> > > + "central": Supports the central role.
> > > + "peripheral": Supports the peripheral
> > role.
> > > + "central-peripheral": Supports both
> > roles
> > > +
> > concurrently.
> >
> > If this is an array os strings why central-peripheral is needed?
> The keyword in the description is "concurrently". Not all adapters
> support being peripheral and central concurrently.
>
> >
> >
> > --
> > pozdrawiam
> > Szymon Janc
> >
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BlueZ PATCH v3] doc:Adding Roles property
2020-04-27 14:57 ` Alain Michaud
@ 2020-04-27 16:47 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 5+ messages in thread
From: Luiz Augusto von Dentz @ 2020-04-27 16:47 UTC (permalink / raw)
To: Alain Michaud; +Cc: Szymon Janc, BlueZ, Alain Michaud
Hi Alain,
On Mon, Apr 27, 2020 at 8:02 AM Alain Michaud <alainmichaud@google.com> wrote:
>
> Any more feedback on this Api design?
>
> On Thu, Apr 23, 2020 at 10:51 AM Alain Michaud <alainmichaud@google.com> wrote:
> >
> > On Thu, Apr 23, 2020 at 10:42 AM Szymon Janc <szymon.janc@codecoup.pl> wrote:
> > >
> > > Hi,
> > >
> > > On Thursday, 23 April 2020 16:23:05 CEST Alain Michaud wrote:
> > > > This change adds a new property to indicate the support for concurrent
> > > > roles which means that the controller has reported the appropriate
> > > > LE_Supported_States (hdev->le_states) and that the controller's driver
> > > > has reported correctly handling the various reported states.
> > > > ---
> > > >
> > > > doc/adapter-api.txt | 8 ++++++++
> > > > 1 file changed, 8 insertions(+)
> > > >
> > > > diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> > > > index acae032d9..1a7255750 100644
> > > > --- a/doc/adapter-api.txt
> > > > +++ b/doc/adapter-api.txt
> > > > @@ -326,3 +326,11 @@ Properties string Address [readonly]
> > > >
> > > > Local Device ID information in modalias format
> > > > used by the kernel and udev.
> > > > +
> > > > + array{string} Roles [readonly]
> > > > +
> > > > + List of supported roles. Possible values:
> > > > + "central": Supports the central role.
> > > > + "peripheral": Supports the peripheral
> > > role.
> > > > + "central-peripheral": Supports both
> > > roles
> > > > +
> > > concurrently.
> > >
> > > If this is an array os strings why central-peripheral is needed?
> > The keyword in the description is "concurrently". Not all adapters
> > support being peripheral and central concurrently.
Applied, thanks.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-27 16:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-23 14:23 [BlueZ PATCH v3] doc:Adding Roles property Alain Michaud
2020-04-23 14:42 ` Szymon Janc
2020-04-23 14:51 ` Alain Michaud
2020-04-27 14:57 ` Alain Michaud
2020-04-27 16:47 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox