Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 01/12] android/hal-ipc-api: Add Remote Features notification
Date: Fri, 14 Feb 2014 11:34:40 +0100	[thread overview]
Message-ID: <5640209.0873DRHjq4@uw000953> (raw)
In-Reply-To: <1392304728-5061-1-git-send-email-luiz.dentz@gmail.com>

Hi Luiz,

On Thursday 13 of February 2014 17:18:37 Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> ---
>  android/hal-ipc-api.txt | 14 ++++++++++++--
>  android/hal-msg.h       |  6 ++++++
>  2 files changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
> index c1609c9..70f947d 100644
> --- a/android/hal-ipc-api.txt
> +++ b/android/hal-ipc-api.txt
> @@ -1300,8 +1300,18 @@ Android HAL name: "avrcp" (BT_PROFILE_AV_RC_ID)
>  		Valid type values : 0x00 = Interim
>  		                    0x01 = Changed
>  
> -	Opcode 0x81 - Get Play Status notification
> -	Opcode 0x82 - List Player Application Attributes notification
> +	Opcode 0x81 - Remote Features notification
> +
> +		Notification parameters: Remote address (6 octets)
> +		                         Features (1 octet)
> +
> +		Valid features values : 0x00 = None
> +		                        0x01 = Metadata
> +		                        0x02 = Absolute Volume
> +		                        0x03 = Browse
> +
> +	Opcode 0x82 - Get Play Status notification
> +	Opcode 0x83 - List Player Application Attributes notification
>  	...
>  
>  
> diff --git a/android/hal-msg.h b/android/hal-msg.h
> index ca1f6b5..f6cdf58 100644
> --- a/android/hal-msg.h
> +++ b/android/hal-msg.h
> @@ -881,3 +881,9 @@ struct hal_cmd_avrcp_register_notification {
>  	uint8_t len;
>  	uint8_t data[0];
>  } __attribute__((packed));
> +
> +#define HAL_EV_AVRCP_REMOTE_FEATURES		0x81
> +struct hal_ev_avrcp_remote_features {
> +	uint8_t bdaddr[6];
> +	uint8_t features;
> +} __attribute__((packed));
> 

All patches applied, thanks.

-- 
Best regards, 
Szymon Janc

      parent reply	other threads:[~2014-02-14 10:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 15:18 [PATCH BlueZ 01/12] android/hal-ipc-api: Add Remote Features notification Luiz Augusto von Dentz
2014-02-13 15:18 ` [PATCH BlueZ 02/12] android/hal-ipc-api: Add Get Play Status notification Luiz Augusto von Dentz
2014-02-13 15:18 ` [PATCH BlueZ 03/12] android/hal-ipc-api: Add List Player Attributes notification Luiz Augusto von Dentz
2014-02-13 15:18 ` [PATCH BlueZ 04/12] android/hal-ipc-api: Add List Player Values notification Luiz Augusto von Dentz
2014-02-13 15:18 ` [PATCH BlueZ 05/12] android/hal-ipc-api: Add Get " Luiz Augusto von Dentz
2014-02-13 15:18 ` [PATCH BlueZ 06/12] android/hal-ipc-api: Add Get Player Attributes Text notification Luiz Augusto von Dentz
2014-02-13 15:18 ` [PATCH BlueZ 07/12] android/hal-ipc-api: Add Get Player Values " Luiz Augusto von Dentz
2014-02-13 15:18 ` [PATCH BlueZ 08/12] android/hal-ipc-api: Add Set Player Values notification Luiz Augusto von Dentz
2014-02-13 15:18 ` [PATCH BlueZ 09/12] android/hal-ipc-api: Add Get Element Attributes notification Luiz Augusto von Dentz
2014-02-13 15:18 ` [PATCH BlueZ 10/12] android/hal-ipc-api: Add Register Notification notification Luiz Augusto von Dentz
2014-02-13 15:18 ` [PATCH BlueZ 11/12] android/hal-ipc-api: Add Volume Changed notification Luiz Augusto von Dentz
2014-02-13 15:18 ` [PATCH BlueZ 12/12] android/hal-ipc-api: Add Passthrough Command notification Luiz Augusto von Dentz
2014-02-14 10:34 ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5640209.0873DRHjq4@uw000953 \
    --to=szymon.janc@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox