[PATCH BlueZ 01/12] android/hal-ipc-api: Add Remote Features notification

[PATCH BlueZ 01/12] android/hal-ipc-api: Add Remote Features notification

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

---
 android/hal-ipc-api.txt | 14 ++++++++++++--
 android/hal-msg.h       |  6 ++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
index c1609c9..70f947d 100644
--- a/android/hal-ipc-api.txt
+++ b/android/hal-ipc-api.txt
@@ -1300,8 +1300,18 @@ Android HAL name: "avrcp" (BT_PROFILE_AV_RC_ID)
 		Valid type values : 0x00 = Interim
 		                    0x01 = Changed
 
-	Opcode 0x81 - Get Play Status notification
-	Opcode 0x82 - List Player Application Attributes notification
+	Opcode 0x81 - Remote Features notification
+
+		Notification parameters: Remote address (6 octets)
+		                         Features (1 octet)
+
+		Valid features values : 0x00 = None
+		                        0x01 = Metadata
+		                        0x02 = Absolute Volume
+		                        0x03 = Browse
+
+	Opcode 0x82 - Get Play Status notification
+	Opcode 0x83 - List Player Application Attributes notification
 	...
 
 
diff --git a/android/hal-msg.h b/android/hal-msg.h
index ca1f6b5..f6cdf58 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -881,3 +881,9 @@ struct hal_cmd_avrcp_register_notification {
 	uint8_t len;
 	uint8_t data[0];
 } __attribute__((packed));
+
+#define HAL_EV_AVRCP_REMOTE_FEATURES		0x81
+struct hal_ev_avrcp_remote_features {
+	uint8_t bdaddr[6];
+	uint8_t features;
+} __attribute__((packed));
-- 
1.8.5.3

[PATCH BlueZ 02/12] android/hal-ipc-api: Add Get Play Status notification

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

---
 android/hal-ipc-api.txt | 3 +++
 android/hal-msg.h       | 2 ++
 2 files changed, 5 insertions(+)

diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
index 70f947d..ce50b6c 100644
--- a/android/hal-ipc-api.txt
+++ b/android/hal-ipc-api.txt
@@ -1311,6 +1311,9 @@ Android HAL name: "avrcp" (BT_PROFILE_AV_RC_ID)
 		                        0x03 = Browse
 
 	Opcode 0x82 - Get Play Status notification
+
+		Notification parameters: <none>
+
 	Opcode 0x83 - List Player Application Attributes notification
 	...
 
diff --git a/android/hal-msg.h b/android/hal-msg.h
index f6cdf58..7dfbf2a 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -887,3 +887,5 @@ struct hal_ev_avrcp_remote_features {
 	uint8_t bdaddr[6];
 	uint8_t features;
 } __attribute__((packed));
+
+#define HAL_EV_AVRCP_GET_PLAY_STATUS		0x82
-- 
1.8.5.3

[PATCH BlueZ 03/12] android/hal-ipc-api: Add List Player Attributes notification

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

---
 android/hal-ipc-api.txt | 5 +++--
 android/hal-msg.h       | 1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
index ce50b6c..aa35050 100644
--- a/android/hal-ipc-api.txt
+++ b/android/hal-ipc-api.txt
@@ -1314,8 +1314,9 @@ Android HAL name: "avrcp" (BT_PROFILE_AV_RC_ID)
 
 		Notification parameters: <none>
 
-	Opcode 0x83 - List Player Application Attributes notification
-	...
+	Opcode 0x83 - List Player Attributes notification
+
+		Notification parameters: <none>
 
 
 Bluetooth GATT HAL (ID 9)
diff --git a/android/hal-msg.h b/android/hal-msg.h
index 7dfbf2a..9536b85 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -889,3 +889,4 @@ struct hal_ev_avrcp_remote_features {
 } __attribute__((packed));
 
 #define HAL_EV_AVRCP_GET_PLAY_STATUS		0x82
+#define HAL_EV_AVRCP_LIST_PLAYER_ATTRS		0x83
-- 
1.8.5.3

[PATCH BlueZ 04/12] android/hal-ipc-api: Add List Player Values notification

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

---
 android/hal-ipc-api.txt | 6 ++++++
 android/hal-msg.h       | 5 +++++
 2 files changed, 11 insertions(+)

diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
index aa35050..56df5b0 100644
--- a/android/hal-ipc-api.txt
+++ b/android/hal-ipc-api.txt
@@ -1318,6 +1318,12 @@ Android HAL name: "avrcp" (BT_PROFILE_AV_RC_ID)
 
 		Notification parameters: <none>
 
+	Opcode 0x84 - List Player Values notification
+
+		Notification parameters: Attribute (1 octet)
+
+		Valid attribute values: Same as in List Player Attributes
+
 
 Bluetooth GATT HAL (ID 9)
 =========================
diff --git a/android/hal-msg.h b/android/hal-msg.h
index 9536b85..55cea27 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -890,3 +890,8 @@ struct hal_ev_avrcp_remote_features {
 
 #define HAL_EV_AVRCP_GET_PLAY_STATUS		0x82
 #define HAL_EV_AVRCP_LIST_PLAYER_ATTRS		0x83
+
+#define HAL_EV_AVRCP_LIST_PLAYER_VALUES		0x84
+struct hal_ev_avrcp_list_player_values {
+	uint8_t attr;
+} __attribute__((packed));
-- 
1.8.5.3

[PATCH BlueZ 05/12] android/hal-ipc-api: Add Get Player Values notification

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

---
 android/hal-ipc-api.txt | 7 +++++++
 android/hal-msg.h       | 6 ++++++
 2 files changed, 13 insertions(+)

diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
index 56df5b0..fd687fb 100644
--- a/android/hal-ipc-api.txt
+++ b/android/hal-ipc-api.txt
@@ -1324,6 +1324,13 @@ Android HAL name: "avrcp" (BT_PROFILE_AV_RC_ID)
 
 		Valid attribute values: Same as in List Player Attributes
 
+	Opcode 0x85 - Get Player Values notification
+
+		Notification parameters: Number of attributes (1 octet)
+		                         Attribute # (1 octet)
+		                         ...
+
+		Valid attribute values: Same as in List Player Attributes
 
 Bluetooth GATT HAL (ID 9)
 =========================
diff --git a/android/hal-msg.h b/android/hal-msg.h
index 55cea27..d5d91dd 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -895,3 +895,9 @@ struct hal_ev_avrcp_remote_features {
 struct hal_ev_avrcp_list_player_values {
 	uint8_t attr;
 } __attribute__((packed));
+
+#define HAL_EV_AVRCP_GET_PLAYER_VALUES		0x85
+struct hal_ev_avrcp_get_player_values {
+	uint8_t number;
+	uint8_t attrs[0];
+} __attribute__((packed));
-- 
1.8.5.3

[PATCH BlueZ 06/12] android/hal-ipc-api: Add Get Player Attributes Text notification

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

---
 android/hal-ipc-api.txt | 8 ++++++++
 android/hal-msg.h       | 6 ++++++
 2 files changed, 14 insertions(+)

diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
index fd687fb..0810078 100644
--- a/android/hal-ipc-api.txt
+++ b/android/hal-ipc-api.txt
@@ -1332,6 +1332,14 @@ Android HAL name: "avrcp" (BT_PROFILE_AV_RC_ID)
 
 		Valid attribute values: Same as in List Player Attributes
 
+	Opcode 0x86 - Get Player Attributes Text notification
+
+		Notification parameters: Number of attributes (1 octet)
+		                         Attribute # (1 octet)
+		                         ...
+
+		Valid attribute values: Same as in List Player Attributes
+
 Bluetooth GATT HAL (ID 9)
 =========================
 
diff --git a/android/hal-msg.h b/android/hal-msg.h
index d5d91dd..67fccb9 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -901,3 +901,9 @@ struct hal_ev_avrcp_get_player_values {
 	uint8_t number;
 	uint8_t attrs[0];
 } __attribute__((packed));
+
+#define HAL_EV_AVRCP_GET_PLAYER_ATTRS_TEXT	0x86
+struct hal_ev_avrcp_get_player_attrs_text {
+	uint8_t number;
+	uint8_t attrs[0];
+} __attribute__((packed));
-- 
1.8.5.3

[PATCH BlueZ 07/12] android/hal-ipc-api: Add Get Player Values Text notification

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

---
 android/hal-ipc-api.txt | 9 +++++++++
 android/hal-msg.h       | 7 +++++++
 2 files changed, 16 insertions(+)

diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
index 0810078..362cdf4 100644
--- a/android/hal-ipc-api.txt
+++ b/android/hal-ipc-api.txt
@@ -1340,6 +1340,15 @@ Android HAL name: "avrcp" (BT_PROFILE_AV_RC_ID)
 
 		Valid attribute values: Same as in List Player Attributes
 
+	Opcode 0x87 - Get Player Values Text notification
+
+		Notification parameters: Attribute (1 octet)
+		                         Number of values (1 octet)
+		                         Value # (1 octet)
+		                         ...
+
+		Valid attribute values: Same as in List Player Attributes
+
 Bluetooth GATT HAL (ID 9)
 =========================
 
diff --git a/android/hal-msg.h b/android/hal-msg.h
index 67fccb9..188e7c2 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -907,3 +907,10 @@ struct hal_ev_avrcp_get_player_attrs_text {
 	uint8_t number;
 	uint8_t attrs[0];
 } __attribute__((packed));
+
+#define HAL_EV_AVRCP_GET_PLAYER_VALUES_TEXT	0x87
+struct hal_ev_avrcp_get_player_values_text {
+	uint8_t attr;
+	uint8_t number;
+	uint8_t values[0];
+} __attribute__((packed));
-- 
1.8.5.3

[PATCH BlueZ 08/12] android/hal-ipc-api: Add Set Player Values notification

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

---
 android/hal-ipc-api.txt | 9 +++++++++
 android/hal-msg.h       | 6 ++++++
 2 files changed, 15 insertions(+)

diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
index 362cdf4..3f7d017 100644
--- a/android/hal-ipc-api.txt
+++ b/android/hal-ipc-api.txt
@@ -1349,6 +1349,15 @@ Android HAL name: "avrcp" (BT_PROFILE_AV_RC_ID)
 
 		Valid attribute values: Same as in List Player Attributes
 
+	Opcode 0x88 - Set Player Values notification
+
+		Notification parameters: Number of attributes (1 octet)
+		                         Attribute # (1 octet)
+		                         Value # (1 octet)
+		                         ...
+
+		Valid attribute values: Same as in List Player Attributes
+
 Bluetooth GATT HAL (ID 9)
 =========================
 
diff --git a/android/hal-msg.h b/android/hal-msg.h
index 188e7c2..fd4b522 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -914,3 +914,9 @@ struct hal_ev_avrcp_get_player_values_text {
 	uint8_t number;
 	uint8_t values[0];
 } __attribute__((packed));
+
+#define HAL_EV_AVRCP_SET_PLAYER_VALUES		0x88
+struct hal_ev_avrcp_set_player_values {
+	uint8_t number;
+	struct hal_avrcp_player_attr_value attrs[0];
+} __attribute__((packed));
-- 
1.8.5.3

[PATCH BlueZ 09/12] android/hal-ipc-api: Add Get Element Attributes notification

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

---
 android/hal-ipc-api.txt | 8 ++++++++
 android/hal-msg.h       | 6 ++++++
 2 files changed, 14 insertions(+)

diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
index 3f7d017..f2427e1 100644
--- a/android/hal-ipc-api.txt
+++ b/android/hal-ipc-api.txt
@@ -1358,6 +1358,14 @@ Android HAL name: "avrcp" (BT_PROFILE_AV_RC_ID)
 
 		Valid attribute values: Same as in List Player Attributes
 
+	Opcode 0x89 - Get Element Attributes notification
+
+		Notification parameters: Number of attributes (1 octet)
+		                         Attribute # (1 octet)
+		                         ...
+
+		Valid attribute values: Same as in Get Element Attribute
+
 Bluetooth GATT HAL (ID 9)
 =========================
 
diff --git a/android/hal-msg.h b/android/hal-msg.h
index fd4b522..9bc2d2a 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -920,3 +920,9 @@ struct hal_ev_avrcp_set_player_values {
 	uint8_t number;
 	struct hal_avrcp_player_attr_value attrs[0];
 } __attribute__((packed));
+
+#define HAL_EV_AVRCP_GET_ELEMENT_ATTRS		0x89
+struct hal_ev_avrcp_get_element_attrs {
+	uint8_t number;
+	uint8_t attrs[0];
+} __attribute__((packed));
-- 
1.8.5.3

[PATCH BlueZ 10/12] android/hal-ipc-api: Add Register Notification notification

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

---
 android/hal-ipc-api.txt | 7 +++++++
 android/hal-msg.h       | 6 ++++++
 2 files changed, 13 insertions(+)

diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
index f2427e1..535e880 100644
--- a/android/hal-ipc-api.txt
+++ b/android/hal-ipc-api.txt
@@ -1366,6 +1366,13 @@ Android HAL name: "avrcp" (BT_PROFILE_AV_RC_ID)
 
 		Valid attribute values: Same as in Get Element Attribute
 
+	Opcode 0x8a - Register Notification notification
+
+		Notification parameters: Event (1 octet)
+		                         Parameter (4 octets)
+
+		Valid event values: Same as in Register Notification
+
 Bluetooth GATT HAL (ID 9)
 =========================
 
diff --git a/android/hal-msg.h b/android/hal-msg.h
index 9bc2d2a..a7df71a 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -926,3 +926,9 @@ struct hal_ev_avrcp_get_element_attrs {
 	uint8_t number;
 	uint8_t attrs[0];
 } __attribute__((packed));
+
+#define HAL_EV_AVRCP_REGISTER_NOTIFICATION	0x8a
+struct hal_ev_avrcp_register_notification {
+	uint8_t event;
+	uint32_t param;
+} __attribute__((packed));
-- 
1.8.5.3

[PATCH BlueZ 11/12] android/hal-ipc-api: Add Volume Changed notification

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

---
 android/hal-ipc-api.txt | 7 +++++++
 android/hal-msg.h       | 6 ++++++
 2 files changed, 13 insertions(+)

diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
index 535e880..99ecede 100644
--- a/android/hal-ipc-api.txt
+++ b/android/hal-ipc-api.txt
@@ -1373,6 +1373,13 @@ Android HAL name: "avrcp" (BT_PROFILE_AV_RC_ID)
 
 		Valid event values: Same as in Register Notification
 
+	Opcode 0x8b - Volume Changed notification
+
+		Notification parameters: Volume (1 octet)
+		                         Type (1 octet)
+
+		Valid type values: Same as in Register Notification
+
 Bluetooth GATT HAL (ID 9)
 =========================
 
diff --git a/android/hal-msg.h b/android/hal-msg.h
index a7df71a..0561894 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -932,3 +932,9 @@ struct hal_ev_avrcp_register_notification {
 	uint8_t event;
 	uint32_t param;
 } __attribute__((packed));
+
+#define HAL_EV_AVRCP_VOLUME_CHANGED		0x8b
+struct hal_ev_avrcp_volume_changed {
+	uint8_t volume;
+	uint8_t type;
+} __attribute__((packed));
-- 
1.8.5.3

[PATCH BlueZ 12/12] android/hal-ipc-api: Add Passthrough Command notification

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

---
 android/hal-ipc-api.txt | 5 +++++
 android/hal-msg.h       | 6 ++++++
 2 files changed, 11 insertions(+)

diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
index 99ecede..ee3bd76 100644
--- a/android/hal-ipc-api.txt
+++ b/android/hal-ipc-api.txt
@@ -1380,6 +1380,11 @@ Android HAL name: "avrcp" (BT_PROFILE_AV_RC_ID)
 
 		Valid type values: Same as in Register Notification
 
+	Opcode 0x8c - Passthrough Command notification
+
+		Notification parameters: ID (1 octet)
+		                         State (1 octet)
+
 Bluetooth GATT HAL (ID 9)
 =========================
 
diff --git a/android/hal-msg.h b/android/hal-msg.h
index 0561894..6504408 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -938,3 +938,9 @@ struct hal_ev_avrcp_volume_changed {
 	uint8_t volume;
 	uint8_t type;
 } __attribute__((packed));
+
+#define HAL_EV_AVRCP_PASSTHROUGH_CMD		0x8c
+struct hal_ev_avrcp_passthrough_cmd {
+	uint8_t id;
+	uint8_t state;
+} __attribute__((packed));
-- 
1.8.5.3

Re: [PATCH BlueZ 01/12] android/hal-ipc-api: Add Remote Features notification

[Szymon Janc]

Hi Luiz,

On Thursday 13 of February 2014 17:18:37 Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> ---
>  android/hal-ipc-api.txt | 14 ++++++++++++--
>  android/hal-msg.h       |  6 ++++++
>  2 files changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
> index c1609c9..70f947d 100644
> --- a/android/hal-ipc-api.txt
> +++ b/android/hal-ipc-api.txt
> @@ -1300,8 +1300,18 @@ Android HAL name: "avrcp" (BT_PROFILE_AV_RC_ID)
>  		Valid type values : 0x00 = Interim
>  		                    0x01 = Changed
>  
> -	Opcode 0x81 - Get Play Status notification
> -	Opcode 0x82 - List Player Application Attributes notification
> +	Opcode 0x81 - Remote Features notification
> +
> +		Notification parameters: Remote address (6 octets)
> +		                         Features (1 octet)
> +
> +		Valid features values : 0x00 = None
> +		                        0x01 = Metadata
> +		                        0x02 = Absolute Volume
> +		                        0x03 = Browse
> +
> +	Opcode 0x82 - Get Play Status notification
> +	Opcode 0x83 - List Player Application Attributes notification
>  	...
>  
>  
> diff --git a/android/hal-msg.h b/android/hal-msg.h
> index ca1f6b5..f6cdf58 100644
> --- a/android/hal-msg.h
> +++ b/android/hal-msg.h
> @@ -881,3 +881,9 @@ struct hal_cmd_avrcp_register_notification {
>  	uint8_t len;
>  	uint8_t data[0];
>  } __attribute__((packed));
> +
> +#define HAL_EV_AVRCP_REMOTE_FEATURES		0x81
> +struct hal_ev_avrcp_remote_features {
> +	uint8_t bdaddr[6];
> +	uint8_t features;
> +} __attribute__((packed));
> 

All patches applied, thanks.

-- 
Best regards, 
Szymon Janc