Linux bluetooth development
 help / color / mirror / Atom feed
* [PATCH] android/pts: Update GATT PTS results
@ 2014-05-28  9:34 Jakub Tyszkowski
  2014-05-28  9:39 ` Szymon Janc
  0 siblings, 1 reply; 3+ messages in thread
From: Jakub Tyszkowski @ 2014-05-28  9:34 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Jakub Tyszkowski

---
 android/pts-gatt.txt | 29 +++++++++++++++++++++++++----
 1 file changed, 25 insertions(+), 4 deletions(-)

diff --git a/android/pts-gatt.txt b/android/pts-gatt.txt
index 57c99dc..60968e2 100644
--- a/android/pts-gatt.txt
+++ b/android/pts-gatt.txt
@@ -159,9 +159,24 @@ TC_GAR_SR_BI_06_C	PASS	haltest:
 				gatts start_service
 TC_GAR_SR_BI_07_C	PASS
 TC_GAR_SR_BI_08_C	PASS
-TC_GAR_SR_BI_09_C	INC
-TC_GAR_SR_BI_10_C	INC
-TC_GAR_SR_BI_11_C	INC
+TC_GAR_SR_BI_09_C	PASS	haltest:
+				gatts add_service
+				gatts add_chaaracteristic:
+						<properties> 2 <permissions> 1
+				gatts start_service
+				gatts send_response: <status> 8
+TC_GAR_SR_BI_10_C	PASS	haltest:
+				gatts add_service
+				gatts add_chaaracteristic:
+						<properties> 2 <permissions> 1
+				gatts start_service
+				gatts send_response: <status> 5
+TC_GAR_SR_BI_11_C	PASS	haltest:
+				gatts add_service
+				gatts add_chaaracteristic:
+						<properties> 2 <permissions> 1
+				gatts start_service
+				gatts send_response: <status> 12
 TC_GAR_SR_BV_04_C	PASS	haltest:
 				gatts add_service
 				gatts add_chaaracteristic:
@@ -265,7 +280,13 @@ TC_GAR_SR_BV_07_C	PASS	haltest:
 				gatts send_response:
 						<data> value greater than MTU
 						repeat with correct offset
-TC_GAR_SR_BV_08_C	INC
+TC_GAR_SR_BV_08_C	PASS	haltest:
+				gatts add_service
+				gatts add_chaaracteristic:
+						<properties> 2 <permissions> 1
+				gatts add_descriptor: <permissions> 1
+				gatts start_service
+				gatts send_response: repeat with correct offset
 TC_GAR_SR_BI_28_C	PASS	haltest:
 				gatts add_service
 				gatts add_chaaracteristic:
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH] android/gatt: Fix not checking for read errors in read by type
@ 2014-05-28  7:48 Jakub Tyszkowski
  2014-05-28  8:52 ` [PATCH] android/pts: Update GATT PTS results Jakub Tyszkowski
  0 siblings, 1 reply; 3+ messages in thread
From: Jakub Tyszkowski @ 2014-05-28  7:48 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Jakub Tyszkowski

---
 android/gatt.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/android/gatt.c b/android/gatt.c
index 0c9837d..736c7cc 100644
--- a/android/gatt.c
+++ b/android/gatt.c
@@ -3677,9 +3677,15 @@ static void send_dev_pending_response(struct gatt_device *device,
 			goto done;
 		}
 
+		if (val->error) {
+			queue_destroy(temp, NULL);
+			error = val->error;
+			goto done;
+		}
+
 		length = val->length;
 
-		while (val && val->length == length) {
+		while (val && val->length == length && val->error == 0) {
 			queue_push_tail(temp, val);
 			val = queue_pop_head(device->pending_requests);
 		}
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-28  9:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-28  9:34 [PATCH] android/pts: Update GATT PTS results Jakub Tyszkowski
2014-05-28  9:39 ` Szymon Janc
  -- strict thread matches above, loose matches on Subject: below --
2014-05-28  7:48 [PATCH] android/gatt: Fix not checking for read errors in read by type Jakub Tyszkowski
2014-05-28  8:52 ` [PATCH] android/pts: Update GATT PTS results Jakub Tyszkowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox