* [PATCH] Bluetooth: hci_bcm: add BCM43752
@ 2026-06-28 1:10 Hugo Osvaldo Barrera
2026-06-28 8:42 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Hugo Osvaldo Barrera @ 2026-06-28 1:10 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Luiz Augusto von Dentz, linux-bluetooth, linux-kernel,
Hugo Osvaldo Barrera
Add the compatible for BCM43752 used in Fydetab Duo.
Signed-off-by: Hugo Osvaldo Barrera <hugo@whynothugo.nl>
---
.../devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml | 1 +
drivers/bluetooth/hci_bcm.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
index 95501e858e6f..04e8a968548d 100644
--- a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
@@ -29,6 +29,7 @@ properties:
- brcm,bcm43438-bt
- brcm,bcm4345c5
- brcm,bcm43540-bt
+ - brcm,bcm43752-bt
- brcm,bcm4335a0
- brcm,bcm4349-bt
- cypress,cyw4373a0-bt
diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 1a4fc3882fd2..443969afa747 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -1591,6 +1591,7 @@ static const struct of_device_id bcm_bluetooth_of_match[] = {
{ .compatible = "brcm,bcm43438-bt", .data = &bcm43438_device_data },
{ .compatible = "brcm,bcm4349-bt", .data = &bcm43438_device_data },
{ .compatible = "brcm,bcm43540-bt", .data = &bcm4354_device_data },
+ { .compatible = "brcm,bcm43752-bt" },
{ .compatible = "brcm,bcm4335a0" },
{ .compatible = "cypress,cyw4373a0-bt", .data = &cyw4373a0_device_data },
{ .compatible = "infineon,cyw55572-bt", .data = &cyw55572_device_data },
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Bluetooth: hci_bcm: add BCM43752
2026-06-28 1:10 [PATCH] Bluetooth: hci_bcm: add BCM43752 Hugo Osvaldo Barrera
@ 2026-06-28 8:42 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-28 8:42 UTC (permalink / raw)
To: Hugo Osvaldo Barrera, Marcel Holtmann
Cc: Luiz Augusto von Dentz, linux-bluetooth, linux-kernel
On 28/06/2026 03:10, Hugo Osvaldo Barrera wrote:
> Add the compatible for BCM43752 used in Fydetab Duo.
>
> Signed-off-by: Hugo Osvaldo Barrera <hugo@whynothugo.nl>
> ---
> .../devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml | 1 +
> drivers/bluetooth/hci_bcm.c | 1 +
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.
Please kindly resend and include all necessary To/Cc entries.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-28 8:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-28 1:10 [PATCH] Bluetooth: hci_bcm: add BCM43752 Hugo Osvaldo Barrera
2026-06-28 8:42 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox