Linux bluetooth development
 help / color / mirror / Atom feed
* [PATCH BlueZ] client: Remove reference to g_steal_pointer()
@ 2020-11-09 19:27 Inga Stotland
  2020-11-09 19:47 ` [BlueZ] " bluez.test.bot
  0 siblings, 1 reply; 3+ messages in thread
From: Inga Stotland @ 2020-11-09 19:27 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: luiz.von.dentz, Inga Stotland

In order to avoid requiring higher version of GLib, replace
g_steal_pointer() with explicitly setting the pointer value
to NULL.
---
 client/adv_monitor.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/client/adv_monitor.c b/client/adv_monitor.c
index 90ab0be09..8e81857af 100644
--- a/client/adv_monitor.c
+++ b/client/adv_monitor.c
@@ -254,10 +254,16 @@ void adv_monitor_add_manager(DBusConnection *conn, GDBusProxy *proxy)
 
 void adv_monitor_remove_manager(DBusConnection *conn)
 {
-	if (manager.supported_types != NULL)
-		g_slist_free(g_steal_pointer(&(manager.supported_types)));
-	if (manager.supported_features != NULL)
-		g_slist_free(g_steal_pointer(&(manager.supported_features)));
+	if (manager.supported_types != NULL) {
+		g_slist_free(manager.supported_types);
+		manager.supported_types = NULL;
+	}
+
+	if (manager.supported_features != NULL) {
+		g_slist_free(manager.supported_features);
+		manager.supported_features = NULL;
+	}
+
 	manager.proxy = NULL;
 	manager.app_registered = FALSE;
 }
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [BlueZ] client: Remove reference to g_steal_pointer()
  2020-11-09 19:27 [PATCH BlueZ] client: Remove reference to g_steal_pointer() Inga Stotland
@ 2020-11-09 19:47 ` bluez.test.bot
  2020-11-09 22:27   ` Luiz Augusto von Dentz
  0 siblings, 1 reply; 3+ messages in thread
From: bluez.test.bot @ 2020-11-09 19:47 UTC (permalink / raw)
  To: linux-bluetooth, inga.stotland

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=380609

---Test result---

##############################
Test: CheckPatch - PASS

##############################
Test: CheckGitLint - PASS

##############################
Test: CheckBuild - PASS

##############################
Test: MakeCheck - PASS



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BlueZ] client: Remove reference to g_steal_pointer()
  2020-11-09 19:47 ` [BlueZ] " bluez.test.bot
@ 2020-11-09 22:27   ` Luiz Augusto von Dentz
  0 siblings, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2020-11-09 22:27 UTC (permalink / raw)
  To: linux-bluetooth@vger.kernel.org; +Cc: Stotland, Inga

Hi Inga,

On Mon, Nov 9, 2020 at 11:50 AM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=380609
>
> ---Test result---
>
> ##############################
> Test: CheckPatch - PASS
>
> ##############################
> Test: CheckGitLint - PASS
>
> ##############################
> Test: CheckBuild - PASS
>
> ##############################
> Test: MakeCheck - PASS
>
>
>
> ---
> Regards,
> Linux Bluetooth

Applied, thanks.

-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-09 22:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-09 19:27 [PATCH BlueZ] client: Remove reference to g_steal_pointer() Inga Stotland
2020-11-09 19:47 ` [BlueZ] " bluez.test.bot
2020-11-09 22:27   ` Luiz Augusto von Dentz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox