[PATCH] Bluetooth: hci_bcm4377: Ignore reserved PHY in ext adv reports on BCM4378

[PATCH] Bluetooth: hci_bcm4377: Ignore reserved PHY in ext adv reports on BCM4378

[Lorenzo Stoakes (ARM)]

Commit ed2a2ef16a6b ("Bluetooth: Add quirk to ignore reserved PHY bits in
LE Extended Adv Report") added a quirk to handle creative use of the
reserved bits in the PHY fields for 4388 controllers in Apple silicon.

I observed the same issue with the BCM4378 Bluetooth controller (14e4:5f69,
rev 05) on an Apple MacBook Pro (13-inch, M2, 2022):

> HCI Event: LE Meta Event (0x3e) plen 51
      LE Extended Advertising Report (0x0d)
        Num reports: 1
        Entry 0
          Event type: 0x2513
            Props: 0x0013
              Connectable
              Scannable
              Use legacy advertising PDUs
            Data status: Complete
            Reserved (0x2500)
          Legacy PDU Type: Reserved (0x2513)
          Address type: Random (0x01)
          Address: EA:C1:82:F0:24:C6 (Static)
          Primary PHY: Reserved
          Secondary PHY: No packets
          SID: no ADI field (0xff)
          TX power: 127 dBm
          RSSI: -57 dBm (0xc7)
          Periodic advertising interval: 0.00 msec (0x0000)
          Direct address type: Public (0x00)
          Direct address: 00:00:00:00:00:00 (OUI 00-00-00)
          Data length: 25

This results in the firmware rejecting connection attempts with
"Unsupported Feature or Parameter Value" (0x11).

Fix the issue by using the same quirk for BCM4378 devices too.

I tested this locally and confirmed that the issue is resolved.

This was observed when attempting to connect a Kinesis Advantage 360
keyboard to the MacBook.

Assisted-by: Claude:claude-fable-5
Fixes: 2e7ed5f5e69b ("Bluetooth: hci_sync: Use advertised PHYs on hci_le_ext_create_conn_sync")
Cc: stable@vger.kernel.org
Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
---
 drivers/bluetooth/hci_bcm4377.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm4377.c
index 925d0a635945..66d49b471544 100644
--- a/drivers/bluetooth/hci_bcm4377.c
+++ b/drivers/bluetooth/hci_bcm4377.c
@@ -2490,6 +2490,7 @@ static const struct bcm4377_hw bcm4377_hw_variants[] = {
 		.has_bar0_core2_window2 = true,
 		.broken_mws_transport_config = true,
 		.broken_le_coded = true,
+		.broken_le_ext_adv_report_phy = true,
 		.send_calibration = bcm4378_send_calibration,
 		.send_ptb = bcm4378_send_ptb,
 	},

---
base-commit: 0f23d56f17fdfc7db69d51f64c8b91bbab947aa9
change-id: 20260818-fix-bcm4378-ext-adv-0737c3cfd66b

Best regards,
-- 
Lorenzo Stoakes (ARM) <ljs@kernel.org>

Re: [PATCH] Bluetooth: hci_bcm4377: Ignore reserved PHY in ext adv reports on BCM4378

[Sven Peter]

On 18.08.26 11:49, Lorenzo Stoakes (ARM) wrote:
> Commit ed2a2ef16a6b ("Bluetooth: Add quirk to ignore reserved PHY bits in
> LE Extended Adv Report") added a quirk to handle creative use of the
> reserved bits in the PHY fields for 4388 controllers in Apple silicon.
> 
> I observed the same issue with the BCM4378 Bluetooth controller (14e4:5f69,
> rev 05) on an Apple MacBook Pro (13-inch, M2, 2022):
> 
>> HCI Event: LE Meta Event (0x3e) plen 51
>        LE Extended Advertising Report (0x0d)
>          Num reports: 1
>          Entry 0
>            Event type: 0x2513
>              Props: 0x0013
>                Connectable
>                Scannable
>                Use legacy advertising PDUs
>              Data status: Complete
>              Reserved (0x2500)
>            Legacy PDU Type: Reserved (0x2513)
>            Address type: Random (0x01)
>            Address: EA:C1:82:F0:24:C6 (Static)
>            Primary PHY: Reserved
>            Secondary PHY: No packets
>            SID: no ADI field (0xff)
>            TX power: 127 dBm
>            RSSI: -57 dBm (0xc7)
>            Periodic advertising interval: 0.00 msec (0x0000)
>            Direct address type: Public (0x00)
>            Direct address: 00:00:00:00:00:00 (OUI 00-00-00)
>            Data length: 25
> 
> This results in the firmware rejecting connection attempts with
> "Unsupported Feature or Parameter Value" (0x11).
> 
> Fix the issue by using the same quirk for BCM4378 devices too.
> 
> I tested this locally and confirmed that the issue is resolved.
> 
> This was observed when attempting to connect a Kinesis Advantage 360
> keyboard to the MacBook.
> 
> Assisted-by: Claude:claude-fable-5
> Fixes: 2e7ed5f5e69b ("Bluetooth: hci_sync: Use advertised PHYs on hci_le_ext_create_conn_sync")
> Cc: stable@vger.kernel.org
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> ---

Reviewed-by: Sven Peter <sven@kernel.org>

Kinda surprised no one ran into this so far tbh.


Best,


Sven

RE: Bluetooth: hci_bcm4377: Ignore reserved PHY in ext adv reports on BCM4378

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1147701

---Test result---

Test Summary:
CheckPatch                    PASS      0.74 seconds
VerifyFixes                   PASS      0.42 seconds
VerifySignedoff               PASS      0.18 seconds
GitLint                       PASS      0.33 seconds
SubjectPrefix                 PASS      0.13 seconds
BuildKernel                   PASS      25.73 seconds
CheckAllWarning               PASS      28.79 seconds
CheckSparse                   PASS      27.87 seconds
BuildKernel32                 PASS      25.54 seconds
CheckKernelLLVM               SKIP      0.00 seconds
TestRunnerSetup               PASS      462.35 seconds
IncrementalBuild              PASS      25.06 seconds

Details
##############################
Test: CheckKernelLLVM - SKIP
Desc: Build kernel with LLVM + context analysis
Output:
Clang not found


https://github.com/bluez/bluetooth-next/pull/607

---
Regards,
Linux Bluetooth