* Bluetooth: btusb: Add USB HW IDs for MT7925
@ 2024-08-26 18:06 Michael Burch
2024-08-26 18:18 ` bluez.test.bot
2024-08-26 18:26 ` Paul Menzel
0 siblings, 2 replies; 3+ messages in thread
From: Michael Burch @ 2024-08-26 18:06 UTC (permalink / raw)
To: linux-bluetooth@vger.kernel.org
Add HW IDs for wireless module specific to ASUS
notebook model to ensure proper recognition and functionality.
These HW IDs are extracted from Windows driver inf file.
Signed-off-by: Michael Burch <me@michaelburch.net>
---
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 51d9d4532dda..d712f5acc338 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -690,6 +690,12 @@ static const struct usb_device_id quirks_table[] = {
{ USB_DEVICE(0x0489, 0xe113), .driver_info = BTUSB_MEDIATEK |
BTUSB_WIDEBAND_SPEECH |
BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x0489, 0xe118), .driver_info = BTUSB_MEDIATEK |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x0489, 0xe11e), .driver_info = BTUSB_MEDIATEK |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
{ USB_DEVICE(0x13d3, 0x3602), .driver_info = BTUSB_MEDIATEK |
BTUSB_WIDEBAND_SPEECH |
BTUSB_VALID_LE_STATES },
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: Bluetooth: btusb: Add USB HW IDs for MT7925
2024-08-26 18:06 Bluetooth: btusb: Add USB HW IDs for MT7925 Michael Burch
@ 2024-08-26 18:18 ` bluez.test.bot
2024-08-26 18:26 ` Paul Menzel
1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2024-08-26 18:18 UTC (permalink / raw)
To: linux-bluetooth, me
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
This is an automated email and please do not reply to this email.
Dear Submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.
----- Output -----
error: patch failed: drivers/bluetooth/btusb.c:690
error: drivers/bluetooth/btusb.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch
Please resolve the issue and submit the patches again.
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bluetooth: btusb: Add USB HW IDs for MT7925
2024-08-26 18:06 Bluetooth: btusb: Add USB HW IDs for MT7925 Michael Burch
2024-08-26 18:18 ` bluez.test.bot
@ 2024-08-26 18:26 ` Paul Menzel
1 sibling, 0 replies; 3+ messages in thread
From: Paul Menzel @ 2024-08-26 18:26 UTC (permalink / raw)
To: Michael Burch; +Cc: linux-bluetooth, Jiande Lu
Dear Michael,
Thank you for your patch. Adding Jiande to Cc. You could make the commit
message slightly more specific:
Add 2 USB HW IDs for MT7925
or
Add 2 USB HW IDs for MT7925 (0xe118/e)
Am 26.08.24 um 20:06 schrieb Michael Burch:
> Add HW IDs for wireless module specific to ASUS
> notebook model to ensure proper recognition and functionality.
> These HW IDs are extracted from Windows driver inf file.
Please add the URL to the commit message.
Were you able to test this on a device? If yes, please document that too.
(I’d also re-flow the commit message, so the first line is longer.)
> Signed-off-by: Michael Burch <me@michaelburch.net>
> ---
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 51d9d4532dda..d712f5acc338 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -690,6 +690,12 @@ static const struct usb_device_id quirks_table[] = {
> { USB_DEVICE(0x0489, 0xe113), .driver_info = BTUSB_MEDIATEK |
> BTUSB_WIDEBAND_SPEECH |
> BTUSB_VALID_LE_STATES },
> + { USB_DEVICE(0x0489, 0xe118), .driver_info = BTUSB_MEDIATEK |
> + BTUSB_WIDEBAND_SPEECH |
> + BTUSB_VALID_LE_STATES },
> + { USB_DEVICE(0x0489, 0xe11e), .driver_info = BTUSB_MEDIATEK |
> + BTUSB_WIDEBAND_SPEECH |
> + BTUSB_VALID_LE_STATES },
> { USB_DEVICE(0x13d3, 0x3602), .driver_info = BTUSB_MEDIATEK |
> BTUSB_WIDEBAND_SPEECH |
> BTUSB_VALID_LE_STATES },
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-26 18:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-26 18:06 Bluetooth: btusb: Add USB HW IDs for MT7925 Michael Burch
2024-08-26 18:18 ` bluez.test.bot
2024-08-26 18:26 ` Paul Menzel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox