* [PATCH] Bluetooth: bnep: Fix endianness in bnep_rx_frame() extension parsing
@ 2026-04-13 8:44 Dudu Lu
2026-04-13 9:41 ` bluez.test.bot
2026-04-13 16:54 ` [PATCH] " Luiz Augusto von Dentz
0 siblings, 2 replies; 3+ messages in thread
From: Dudu Lu @ 2026-04-13 8:44 UTC (permalink / raw)
To: linux-bluetooth; +Cc: marcel, luiz.dentz, Dudu Lu
In bnep_rx_frame(), the extension header parsing for
BNEP_FILTER_NET_TYPE_SET and BNEP_FILTER_MULTI_ADDR_SET uses
*(u16 *)(skb->data + 1) to read the 2-byte length field. This
performs a native-endian read, but the BNEP protocol specifies this
field in big-endian (network byte order).
On little-endian architectures (x86, ARM), the bytes are swapped,
causing the length to be wildly incorrect. For example, a length
of 3 (0x00 0x03) is read as 768 (0x0300). This causes either:
- skb_pull failure (length too large) -> frame dropped
- Insufficient pull (length too small) -> frame parsing corruption
The same file correctly uses get_unaligned_be16() for identical
fields in bnep_ctrl_set_netfilter() (line 110) and
bnep_ctrl_set_mcfilter() (line 156), confirming the inconsistency.
Replace *(u16 *)(skb->data + 1) with get_unaligned_be16(skb->data + 1).
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Dudu Lu <phx0fer@gmail.com>
---
net/bluetooth/bnep/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/bnep/core.c b/net/bluetooth/bnep/core.c
index d44987d4515c..2d1cb2061045 100644
--- a/net/bluetooth/bnep/core.c
+++ b/net/bluetooth/bnep/core.c
@@ -332,7 +332,7 @@ static int bnep_rx_frame(struct bnep_session *s, struct sk_buff *skb)
case BNEP_FILTER_MULTI_ADDR_SET:
case BNEP_FILTER_NET_TYPE_SET:
/* Pull: ctrl type (1 b), len (2 b), data (len bytes) */
- if (!skb_pull(skb, 3 + *(u16 *)(skb->data + 1) * 2))
+ if (!skb_pull(skb, 3 + get_unaligned_be16(skb->data + 1) * 2))
goto badframe;
break;
default:
--
2.39.3 (Apple Git-145)
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: Bluetooth: bnep: Fix endianness in bnep_rx_frame() extension parsing
2026-04-13 8:44 [PATCH] Bluetooth: bnep: Fix endianness in bnep_rx_frame() extension parsing Dudu Lu
@ 2026-04-13 9:41 ` bluez.test.bot
2026-04-13 16:54 ` [PATCH] " Luiz Augusto von Dentz
1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2026-04-13 9:41 UTC (permalink / raw)
To: linux-bluetooth, phx0fer
[-- Attachment #1: Type: text/plain, Size: 6871 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1080572
---Test result---
Test Summary:
CheckPatch PENDING 0.46 seconds
GitLint PENDING 0.41 seconds
SubjectPrefix PASS 0.12 seconds
BuildKernel PASS 26.05 seconds
CheckAllWarning PASS 28.97 seconds
CheckSparse PASS 28.08 seconds
BuildKernel32 PASS 25.95 seconds
TestRunnerSetup PASS 539.48 seconds
TestRunner_l2cap-tester PASS 28.18 seconds
TestRunner_iso-tester PASS 39.47 seconds
TestRunner_bnep-tester PASS 6.45 seconds
TestRunner_mgmt-tester FAIL 116.46 seconds
TestRunner_rfcomm-tester PASS 9.55 seconds
TestRunner_sco-tester FAIL 14.30 seconds
TestRunner_ioctl-tester PASS 10.15 seconds
TestRunner_mesh-tester FAIL 11.60 seconds
TestRunner_smp-tester PASS 10.58 seconds
TestRunner_userchan-tester PASS 6.79 seconds
TestRunner_6lowpan-tester FAIL 8.84 seconds
IncrementalBuild PENDING 0.27 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
Read Exp Feature - Success Failed 0.111 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
7.0.0-rc2-gc26941412ef4 #1 Not tainted
------------------------------------------------------
kworker/u5:2/117 is trying to acquire lock:
ffff888001abe240 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}, at: sco_connect_cfm+0x358/0x8d0
but task is already holding lock:
ffff888002090c20 (&conn->lock){+.+.}-{3:3}, at: sco_connect_cfm+0x22d/0x8d0
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&conn->lock){+.+.}-{3:3}:
lock_acquire+0xf7/0x2c0
_raw_spin_lock+0x2a/0x40
sco_sock_connect+0x4d7/0x1280
__sys_connect+0x1a3/0x260
__x64_sys_connect+0x6e/0xb0
do_syscall_64+0xa0/0x570
entry_SYSCALL_64_after_hwframe+0x74/0x7c
-> #0 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}:
check_prev_add+0xe9/0xc70
__lock_acquire+0x1457/0x1df0
lock_acquire+0xf7/0x2c0
lock_sock_nested+0x36/0xd0
sco_connect_cfm+0x358/0x8d0
hci_sync_conn_complete_evt+0x3d3/0x8e0
hci_event_packet+0x74f/0xb10
hci_rx_work+0x398/0xd00
process_scheduled_works+0xb16/0x1ac0
worker_thread+0x4ff/0xba0
kthread+0x368/0x490
ret_from_fork+0x498/0x7e0
ret_from_fork_asm+0x19/0x30
other info that might help us debug this:
...
BUG: sleeping function called from invalid context at net/core/sock.c:3782
in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 117, name: kworker/u5:2
preempt_count: 1, expected: 0
RCU nest depth: 0, expected: 0
INFO: lockdep is turned off.
CPU: 0 UID: 0 PID: 117 Comm: kworker/u5:2 Not tainted 7.0.0-rc2-gc26941412ef4 #1 PREEMPT(lazy)
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-1ubuntu1.1 04/01/2014
Workqueue: hci0 hci_rx_work
Call Trace:
<TASK>
dump_stack_lvl+0x49/0x60
__might_resched+0x2ea/0x500
lock_sock_nested+0x47/0xd0
? sco_connect_cfm+0x358/0x8d0
sco_connect_cfm+0x358/0x8d0
? hci_debugfs_create_conn+0x190/0x210
? __pfx_sco_connect_cfm+0x10/0x10
hci_sync_conn_complete_evt+0x3d3/0x8e0
hci_event_packet+0x74f/0xb10
? __pfx_hci_sync_conn_complete_evt+0x10/0x10
? __pfx_hci_event_packet+0x10/0x10
? mark_held_locks+0x49/0x80
? lockdep_hardirqs_on_prepare+0xd4/0x180
? _raw_spin_unlock_irqrestore+0x2c/0x50
hci_rx_work+0x398/0xd00
process_scheduled_works+0xb16/0x1ac0
? __pfx_process_scheduled_works+0x10/0x10
? lock_acquire+0xf7/0x2c0
? lock_is_held_type+0x9b/0x110
? __pfx_hci_rx_work+0x10/0x10
worker_thread+0x4ff/0xba0
? _raw_spin_unlock_irqrestore+0x2c/0x50
? __pfx_worker_thread+0x10/0x10
kthread+0x368/0x490
? _raw_spin_unlock_irq+0x23/0x40
? __pfx_kthread+0x10/0x10
ret_from_fork+0x498/0x7e0
? __pfx_ret_from_fork+0x10/0x10
? __switch_to+0x9e4/0xe50
? __switch_to_asm+0x32/0x60
...
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 1.788 seconds
Mesh - Send cancel - 2 Timed out 1.993 seconds
##############################
Test: TestRunner_6lowpan-tester - FAIL
Desc: Run 6lowpan-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
7.0.0-rc2-gc26941412ef4 #1 Not tainted
------------------------------------------------------
kworker/0:1/11 is trying to acquire lock:
ffff8880026e8940 ((wq_completion)hci0#2){+.+.}-{0:0}, at: touch_wq_lockdep_map+0x75/0x180
but task is already holding lock:
ffffffff98c4d720 (rtnl_mutex){+.+.}-{4:4}, at: lowpan_unregister_netdev+0xd/0x30
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #4 (rtnl_mutex){+.+.}-{4:4}:
lock_acquire+0xf7/0x2c0
__mutex_lock+0x16b/0x1fc0
lowpan_register_netdev+0x11/0x30
chan_ready_cb+0x836/0xd00
l2cap_recv_frame+0x6a06/0x8920
l2cap_recv_acldata+0x790/0xdf0
hci_rx_work+0x500/0xd00
process_scheduled_works+0xb16/0x1ac0
worker_thread+0x4ff/0xba0
kthread+0x368/0x490
ret_from_fork+0x498/0x7e0
ret_from_fork_asm+0x19/0x30
-> #3 (&chan->lock#3/1){+.+.}-{4:4}:
lock_acquire+0xf7/0x2c0
__mutex_lock+0x16b/0x1fc0
l2cap_chan_connect+0x74e/0x1980
lowpan_control_write+0x523/0x660
full_proxy_write+0x10b/0x190
vfs_write+0x1c0/0xf60
ksys_write+0xf1/0x1d0
do_syscall_64+0xa0/0x570
entry_SYSCALL_64_after_hwframe+0x74/0x7c
-> #2 (&conn->lock){+.+.}-{4:4}:
...
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
https://github.com/bluez/bluetooth-next/pull/76
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Bluetooth: bnep: Fix endianness in bnep_rx_frame() extension parsing
2026-04-13 8:44 [PATCH] Bluetooth: bnep: Fix endianness in bnep_rx_frame() extension parsing Dudu Lu
2026-04-13 9:41 ` bluez.test.bot
@ 2026-04-13 16:54 ` Luiz Augusto von Dentz
1 sibling, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2026-04-13 16:54 UTC (permalink / raw)
To: Dudu Lu; +Cc: linux-bluetooth, marcel
Hi Dudu,
On Mon, Apr 13, 2026 at 4:44 AM Dudu Lu <phx0fer@gmail.com> wrote:
>
> In bnep_rx_frame(), the extension header parsing for
> BNEP_FILTER_NET_TYPE_SET and BNEP_FILTER_MULTI_ADDR_SET uses
> *(u16 *)(skb->data + 1) to read the 2-byte length field. This
> performs a native-endian read, but the BNEP protocol specifies this
> field in big-endian (network byte order).
>
> On little-endian architectures (x86, ARM), the bytes are swapped,
> causing the length to be wildly incorrect. For example, a length
> of 3 (0x00 0x03) is read as 768 (0x0300). This causes either:
> - skb_pull failure (length too large) -> frame dropped
> - Insufficient pull (length too small) -> frame parsing corruption
>
> The same file correctly uses get_unaligned_be16() for identical
> fields in bnep_ctrl_set_netfilter() (line 110) and
> bnep_ctrl_set_mcfilter() (line 156), confirming the inconsistency.
>
> Replace *(u16 *)(skb->data + 1) with get_unaligned_be16(skb->data + 1).
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Dudu Lu <phx0fer@gmail.com>
> ---
> net/bluetooth/bnep/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/bnep/core.c b/net/bluetooth/bnep/core.c
> index d44987d4515c..2d1cb2061045 100644
> --- a/net/bluetooth/bnep/core.c
> +++ b/net/bluetooth/bnep/core.c
> @@ -332,7 +332,7 @@ static int bnep_rx_frame(struct bnep_session *s, struct sk_buff *skb)
> case BNEP_FILTER_MULTI_ADDR_SET:
> case BNEP_FILTER_NET_TYPE_SET:
> /* Pull: ctrl type (1 b), len (2 b), data (len bytes) */
> - if (!skb_pull(skb, 3 + *(u16 *)(skb->data + 1) * 2))
> + if (!skb_pull(skb, 3 + get_unaligned_be16(skb->data + 1) * 2))
This change seems wrong, it should probably drop the * 2:
https://sashiko.dev/#/patchset/20260413084442.68604-1-phx0fer%40gmail.com
We should probably use `skb_pull_data`, assign it to an `hdr`
variable, and then add a check for if (!skb_pull(skb, hdr->len)).
> goto badframe;
> break;
> default:
> --
> 2.39.3 (Apple Git-145)
>
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-13 16:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-13 8:44 [PATCH] Bluetooth: bnep: Fix endianness in bnep_rx_frame() extension parsing Dudu Lu
2026-04-13 9:41 ` bluez.test.bot
2026-04-13 16:54 ` [PATCH] " Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox