[PATCH v1] Bluetooth: btintel_pcie: Fix build error when CONFIG_ACPI is disabled

[PATCH v1] Bluetooth: btintel_pcie: Fix build error when CONFIG_ACPI is disabled

[Chandrashekar Devegowda]

btintel_pcie_acpi_reset_method() uses ACPI APIs such as
acpi_evaluate_object() and acpi_has_method() which are not available
when CONFIG_ACPI is disabled, causing build errors on architectures
like ppc64le that lack ACPI support.

Guard btintel_pcie_acpi_reset_method() with IS_ENABLED(CONFIG_ACPI)
and provide a stub returning -ENODEV when ACPI is not enabled.

Fixes: 912a499a7955 ("Bluetooth: btintel_pcie: Support Product level reset")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
---
 drivers/bluetooth/btintel_pcie.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
index 076beb45c410..4d136ff342b8 100644
--- a/drivers/bluetooth/btintel_pcie.c
+++ b/drivers/bluetooth/btintel_pcie.c
@@ -2280,6 +2280,7 @@ static void btintel_pcie_inc_recovery_count(struct pci_dev *pdev,
 static int btintel_pcie_setup_hdev(struct btintel_pcie_data *data);
 static void btintel_pcie_reset(struct hci_dev *hdev);
 
+#if IS_ENABLED(CONFIG_ACPI)
 static int btintel_pcie_acpi_reset_method(struct btintel_pcie_data *data)
 {
 	union acpi_object *obj, argv4;
@@ -2333,6 +2334,12 @@ static int btintel_pcie_acpi_reset_method(struct btintel_pcie_data *data)
 	pci_dev_unlock(data->pdev);
 	return ret;
 }
+#else
+static int btintel_pcie_acpi_reset_method(struct btintel_pcie_data *data)
+{
+	return -ENODEV;
+}
+#endif
 
 static void btintel_pcie_perform_pldr(struct btintel_pcie_data *data)
 {
-- 
2.43.0

RE: [v1] Bluetooth: btintel_pcie: Fix build error when CONFIG_ACPI is disabled

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----

error: patch failed: drivers/bluetooth/btintel_pcie.c:2280
error: drivers/bluetooth/btintel_pcie.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch

Please resolve the issue and submit the patches again.


---
Regards,
Linux Bluetooth

Re: [PATCH v1] Bluetooth: btintel_pcie: Fix build error when CONFIG_ACPI is disabled

[Paul Menzel]

Dear Chandrashekar,


Am 16.04.26 um 08:03 schrieb Chandrashekar Devegowda:
> btintel_pcie_acpi_reset_method() uses ACPI APIs such as
> acpi_evaluate_object() and acpi_has_method() which are not available
> when CONFIG_ACPI is disabled, causing build errors on architectures
> like ppc64le that lack ACPI support.
> 
> Guard btintel_pcie_acpi_reset_method() with IS_ENABLED(CONFIG_ACPI)
> and provide a stub returning -ENODEV when ACPI is not enabled.
> 
> Fixes: 912a499a7955 ("Bluetooth: btintel_pcie: Support Product level reset")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
> ---
>   drivers/bluetooth/btintel_pcie.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
> index 076beb45c410..4d136ff342b8 100644
> --- a/drivers/bluetooth/btintel_pcie.c
> +++ b/drivers/bluetooth/btintel_pcie.c
> @@ -2280,6 +2280,7 @@ static void btintel_pcie_inc_recovery_count(struct pci_dev *pdev,
>   static int btintel_pcie_setup_hdev(struct btintel_pcie_data *data);
>   static void btintel_pcie_reset(struct hci_dev *hdev);
>   
> +#if IS_ENABLED(CONFIG_ACPI)
>   static int btintel_pcie_acpi_reset_method(struct btintel_pcie_data *data)
>   {
>   	union acpi_object *obj, argv4;
> @@ -2333,6 +2334,12 @@ static int btintel_pcie_acpi_reset_method(struct btintel_pcie_data *data)
>   	pci_dev_unlock(data->pdev);
>   	return ret;
>   }
> +#else
> +static int btintel_pcie_acpi_reset_method(struct btintel_pcie_data *data)
> +{
> +	return -ENODEV;
> +}
> +#endif

Please look into using something similar like the macro `PTR_IF()`, 
defined in `include/linux/util_macros.h`. It’s returning NULL, so not 
applicable here, but all the code needs to be build tested.

Also, if ACPI is not enabled, does it make sense to call 
`btintel_pcie_perform_pldr()` at all?

>   
>   static void btintel_pcie_perform_pldr(struct btintel_pcie_data *data)
>   {


Kind regards,

Paul

RE: [PATCH v1] Bluetooth: btintel_pcie: Fix build error when CONFIG_ACPI is disabled

[Devegowda, Chandrashekar]

Hi Paul,
    Thanks for the comments

> -----Original Message-----
> From: Paul Menzel <pmenzel@molgen.mpg.de>
> Sent: Thursday, April 16, 2026 1:32 PM
> To: Devegowda, Chandrashekar <chandrashekar.devegowda@intel.com>
> Cc: linux-bluetooth@vger.kernel.org; linux-pci@vger.kernel.org;
> bhelgaas@google.com; Srivatsa, Ravishankar
> <ravishankar.srivatsa@intel.com>; Tumkur Narayan, Chethan
> <chethan.tumkur.narayan@intel.com>; lkp <lkp@intel.com>
> Subject: Re: [PATCH v1] Bluetooth: btintel_pcie: Fix build error when
> CONFIG_ACPI is disabled
> 
> Dear Chandrashekar,
> 
> 
> Am 16.04.26 um 08:03 schrieb Chandrashekar Devegowda:
> > btintel_pcie_acpi_reset_method() uses ACPI APIs such as
> > acpi_evaluate_object() and acpi_has_method() which are not available
> > when CONFIG_ACPI is disabled, causing build errors on architectures
> > like ppc64le that lack ACPI support.
> >
> > Guard btintel_pcie_acpi_reset_method() with IS_ENABLED(CONFIG_ACPI)
> > and provide a stub returning -ENODEV when ACPI is not enabled.
> >
> > Fixes: 912a499a7955 ("Bluetooth: btintel_pcie: Support Product level
> > reset")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Chandrashekar Devegowda
> > <chandrashekar.devegowda@intel.com>
> > ---
> >   drivers/bluetooth/btintel_pcie.c | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btintel_pcie.c
> > b/drivers/bluetooth/btintel_pcie.c
> > index 076beb45c410..4d136ff342b8 100644
> > --- a/drivers/bluetooth/btintel_pcie.c
> > +++ b/drivers/bluetooth/btintel_pcie.c
> > @@ -2280,6 +2280,7 @@ static void
> btintel_pcie_inc_recovery_count(struct pci_dev *pdev,
> >   static int btintel_pcie_setup_hdev(struct btintel_pcie_data *data);
> >   static void btintel_pcie_reset(struct hci_dev *hdev);
> >
> > +#if IS_ENABLED(CONFIG_ACPI)
> >   static int btintel_pcie_acpi_reset_method(struct btintel_pcie_data *data)
> >   {
> >   	union acpi_object *obj, argv4;
> > @@ -2333,6 +2334,12 @@ static int btintel_pcie_acpi_reset_method(struct
> btintel_pcie_data *data)
> >   	pci_dev_unlock(data->pdev);
> >   	return ret;
> >   }
> > +#else
> > +static int btintel_pcie_acpi_reset_method(struct btintel_pcie_data
> > +*data) {
> > +	return -ENODEV;
> > +}
> > +#endif
> 
> Please look into using something similar like the macro `PTR_IF()`, defined in
> `include/linux/util_macros.h`. It’s returning NULL, so not applicable here, but
> all the code needs to be build tested.
> 

Tested for few platforms but missed testing for ppc64le , where ACPI is disabled will cover the testing before sending the next patch. 

> Also, if ACPI is not enabled, does it make sense to call
> `btintel_pcie_perform_pldr()` at all?

Ack will update in v2

> 
> >
> >   static void btintel_pcie_perform_pldr(struct btintel_pcie_data *data)
> >   {
> 
> 
> Kind regards,
> 
> Paul