[PATCH] Bluetooth: btrtl: fix uninitialized scalar value

[PATCH] Bluetooth: btrtl: fix uninitialized scalar value

[Alonso Garrigues]

There is a path where the variable is read uninitialized:
If the opcode switch case is RTL_PATCH_SECURITY_HEADER and key_id is
not set, the if statement condition immediately following the switch
checks an uninitialized rc

Signed-off-by: Alonso Garrigues <agarrigues@riseup.net>
---
 drivers/bluetooth/btrtl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 62f9d4df3a4f..aa0d5af26b5f 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -543,7 +543,7 @@ static int rtlbt_parse_firmware_v2(struct hci_dev *hdev,
 				   unsigned char **_buf)
 {
 	struct rtl_epatch_header_v2 *hdr;
-	int rc;
+	int rc = 0;
 	u8 key_id;
 	u32 num_sections;
 	struct rtl_section *section;
-- 
2.53.0

RE: Bluetooth: btrtl: fix uninitialized scalar value

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1085529

---Test result---

Test Summary:
CheckPatch                    PASS      0.74 seconds
GitLint                       PASS      0.35 seconds
SubjectPrefix                 PASS      0.13 seconds
BuildKernel                   PASS      26.84 seconds
CheckAllWarning               PASS      29.70 seconds
CheckSparse                   PASS      28.22 seconds
BuildKernel32                 PASS      26.14 seconds
TestRunnerSetup               PASS      577.33 seconds
IncrementalBuild              PASS      26.22 seconds



https://github.com/bluez/bluetooth-next/pull/126

---
Regards,
Linux Bluetooth