[PATCH BlueZ] advertising: add property with advertisement ID

[PATCH BlueZ] advertising: add property with advertisement ID

[Michal Dzik]

Identifier is an internal value, but it must be exposed to client app
if client app wants to use a advertisement in BAP broadcast
---
 doc/org.bluez.LEAdvertisement.rst |  6 ++++++
 src/advertising.c                 | 13 ++++++++++++-
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/doc/org.bluez.LEAdvertisement.rst b/doc/org.bluez.LEAdvertisement.rst
index aae80f08f..4dd36a0cc 100644
--- a/doc/org.bluez.LEAdvertisement.rst
+++ b/doc/org.bluez.LEAdvertisement.rst
@@ -235,3 +235,9 @@ The provided value is used only if the "CanSetTxPower" feature is enabled on the
 **org.bluez.LEAdvertisingManager(5)**.
 
 Values must be in range [-127 to +20], where units are in dBm.
+
+byte Identifier [read-write, optional]
+``````````````````````````````````````
+
+Identifier of the advertisement. Set by bluetoothd after advertisement is registered with
+**org.bluez.LEAdvertisingManager(5)**.
diff --git a/src/advertising.c b/src/advertising.c
index f529ecd14..3b758f51e 100644
--- a/src/advertising.c
+++ b/src/advertising.c
@@ -1511,8 +1511,19 @@ static void add_client_complete(struct btd_adv_client *client, uint8_t status)
 		queue_remove(client->manager->clients, client);
 		g_idle_add(client_free_idle_cb, client);
 
-	} else
+	} else {
+		DBusMessageIter iter;
+
+		/* Check if the attribute has the Identifier property */
+		if (g_dbus_proxy_get_property(client->proxy, "Identifier",
+								&iter)) {
+			g_dbus_proxy_set_property_basic(client->proxy,
+				"Identifier", DBUS_TYPE_BYTE, &client->instance,
+				NULL, NULL, NULL);
+		}
+
 		reply = dbus_message_new_method_return(client->reg);
+	}
 
 	g_dbus_send_message(btd_get_dbus_connection(), reply);
 	dbus_message_unref(client->reg);
-- 
2.43.0

RE: [BlueZ] advertising: add property with advertisement ID

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2518 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1100171

---Test result---

Test Summary:
CheckPatch                    PASS      0.34 seconds
GitLint                       PASS      0.23 seconds
BuildEll                      PASS      19.89 seconds
BluezMake                     PASS      638.08 seconds
MakeCheck                     FAIL      19.19 seconds
MakeDistcheck                 FAIL      227.16 seconds
CheckValgrind                 FAIL      290.16 seconds
CheckSmatch                   WARNING   347.82 seconds
bluezmakeextell               PASS      187.84 seconds
IncrementalBuild              PASS      658.32 seconds
ScanBuild                     PASS      1026.14 seconds

Details
##############################
Test: MakeCheck - FAIL
Desc: Run Bluez Make Check
Output:

make[3]: *** [Makefile:10239: test-suite.log] Error 1
make[2]: *** [Makefile:10347: check-TESTS] Error 2
make[1]: *** [Makefile:10818: check-am] Error 2
make: *** [Makefile:10820: check] Error 2
##############################
Test: MakeDistcheck - FAIL
Desc: Run Bluez Make Distcheck
Output:

make[4]: *** [Makefile:10239: test-suite.log] Error 1
make[3]: *** [Makefile:10347: check-TESTS] Error 2
make[2]: *** [Makefile:10818: check-am] Error 2
make[1]: *** [Makefile:10820: check] Error 2
make: *** [Makefile:10741: distcheck] Error 1
##############################
Test: CheckValgrind - FAIL
Desc: Run Bluez Make Check with Valgrind
Output:

tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12990:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12990 | int main(int argc, char *argv[])
      |     ^~~~
make[3]: *** [Makefile:10239: test-suite.log] Error 1
make[2]: *** [Makefile:10347: check-TESTS] Error 2
make[1]: *** [Makefile:10818: check-am] Error 2
make: *** [Makefile:10820: check] Error 2
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/advertising.c: note: in included file:./src/shared/mgmt.h:95:25: error: redefinition of unsigned int enum mgmt_io_capabilitysrc/advertising.c: note: in included file:./src/shared/mgmt.h:95:25: error: redefinition of unsigned int enum mgmt_io_capability


https://github.com/bluez/bluez/pull/2149

---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ] advertising: add property with advertisement ID

[Luiz Augusto von Dentz]

Hi Michal,

On Mon, May 25, 2026 at 12:12 AM Michal Dzik
<michal.dzik@streamunlimited.com> wrote:
>
> Identifier is an internal value, but it must be exposed to client app
> if client app wants to use a advertisement in BAP broadcast
> ---
>  doc/org.bluez.LEAdvertisement.rst |  6 ++++++
>  src/advertising.c                 | 13 ++++++++++++-
>  2 files changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/doc/org.bluez.LEAdvertisement.rst b/doc/org.bluez.LEAdvertisement.rst
> index aae80f08f..4dd36a0cc 100644
> --- a/doc/org.bluez.LEAdvertisement.rst
> +++ b/doc/org.bluez.LEAdvertisement.rst
> @@ -235,3 +235,9 @@ The provided value is used only if the "CanSetTxPower" feature is enabled on the
>  **org.bluez.LEAdvertisingManager(5)**.
>
>  Values must be in range [-127 to +20], where units are in dBm.
> +
> +byte Identifier [read-write, optional]
> +``````````````````````````````````````

We use the term instance in other part of the API so Id got with that:

https://github.com/bluez/bluez/blob/master/doc/org.bluez.LEAdvertisingManager.rst#byte-activeinstances-readonly

> +Identifier of the advertisement. Set by bluetoothd after advertisement is registered with
> +**org.bluez.LEAdvertisingManager(5)**.
> diff --git a/src/advertising.c b/src/advertising.c
> index f529ecd14..3b758f51e 100644
> --- a/src/advertising.c
> +++ b/src/advertising.c
> @@ -1511,8 +1511,19 @@ static void add_client_complete(struct btd_adv_client *client, uint8_t status)
>                 queue_remove(client->manager->clients, client);
>                 g_idle_add(client_free_idle_cb, client);
>
> -       } else
> +       } else {
> +               DBusMessageIter iter;
> +
> +               /* Check if the attribute has the Identifier property */
> +               if (g_dbus_proxy_get_property(client->proxy, "Identifier",
> +                                                               &iter)) {
> +                       g_dbus_proxy_set_property_basic(client->proxy,
> +                               "Identifier", DBUS_TYPE_BYTE, &client->instance,
> +                               NULL, NULL, NULL);
> +               }
> +
>                 reply = dbus_message_new_method_return(client->reg);
> +       }
>
>         g_dbus_send_message(btd_get_dbus_connection(), reply);
>         dbus_message_unref(client->reg);
> --
> 2.43.0
>
>


-- 
Luiz Augusto von Dentz