* [PATCH v2] Bluetooth: Add SPDX id lines to some source files
@ 2026-06-04 0:41 Tim Bird
2026-06-04 5:48 ` [v2] " bluez.test.bot
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Tim Bird @ 2026-06-04 0:41 UTC (permalink / raw)
To: marcel, luiz.dentz, jannh, kuba, kiran.k, chharry, gustavo,
prameela.j04cs, salvatore.benedetto, maxk
Cc: tim.bird, linux-bluetooth, linux-spdx, linux-kernel
Many bluetooth source files are missing SPDX-License-Identifier
lines. Add appropriate IDs to these files, and remove other
license lines from the headers.
Leave the warranty disclaimer in files where the license ID is
GPL-2.0 but the wording of the disclaimer is slightly different
from that of the GPL v2 disclaimer.
It is not different enough to cause licensing conflicts, but is
kept to honor the original contributors' legal intent.
---
V1 -> V2:
- Leave different warranty disclaimers (which is most them)
- Remove files recently removed from drivers/bluetooth from the patch
Signed-off-by: Tim Bird <tim.bird@sony.com>
---
drivers/bluetooth/btrsi.c | 12 +-----------
include/net/bluetooth/bluetooth.h | 5 +----
include/net/bluetooth/hci.h | 5 +----
include/net/bluetooth/hci_core.h | 5 +----
include/net/bluetooth/hci_mon.h | 5 +----
include/net/bluetooth/hci_sock.h | 5 +----
include/net/bluetooth/l2cap.h | 5 +----
include/net/bluetooth/mgmt.h | 5 +----
include/net/bluetooth/rfcomm.h | 5 +----
include/net/bluetooth/sco.h | 5 +----
net/bluetooth/af_bluetooth.c | 5 +----
net/bluetooth/bnep/core.c | 5 +----
net/bluetooth/bnep/netdev.c | 5 +----
net/bluetooth/bnep/sock.c | 5 +----
net/bluetooth/ecdh_helper.c | 5 +----
net/bluetooth/ecdh_helper.h | 5 +----
net/bluetooth/hci_conn.c | 5 +----
net/bluetooth/hci_core.c | 5 +----
net/bluetooth/hci_debugfs.c | 5 +----
net/bluetooth/hci_debugfs.h | 5 +----
net/bluetooth/hci_event.c | 5 +----
net/bluetooth/hci_sock.c | 5 +----
net/bluetooth/hidp/core.c | 5 +----
net/bluetooth/hidp/hidp.h | 5 +----
net/bluetooth/hidp/sock.c | 5 +----
net/bluetooth/l2cap_core.c | 5 +----
net/bluetooth/l2cap_sock.c | 5 +----
net/bluetooth/lib.c | 5 +----
net/bluetooth/mgmt.c | 5 +----
net/bluetooth/mgmt_util.c | 5 +----
net/bluetooth/mgmt_util.h | 5 +----
net/bluetooth/rfcomm/core.c | 5 +----
net/bluetooth/rfcomm/sock.c | 5 +----
net/bluetooth/rfcomm/tty.c | 5 +----
net/bluetooth/sco.c | 5 +----
net/bluetooth/selftest.c | 5 +----
net/bluetooth/selftest.h | 5 +----
net/bluetooth/smp.c | 5 +----
net/bluetooth/smp.h | 5 +----
39 files changed, 39 insertions(+), 163 deletions(-)
diff --git a/drivers/bluetooth/btrsi.c b/drivers/bluetooth/btrsi.c
index c68dd2fba01c..59ad0b9b14c3 100644
--- a/drivers/bluetooth/btrsi.c
+++ b/drivers/bluetooth/btrsi.c
@@ -1,17 +1,7 @@
+// SPDX-License-Identifier: ISC
/*
* Copyright (c) 2017 Redpine Signals Inc.
*
- * Permission to use, copy, modify, and/or distribute this software for any
- * purpose with or without fee is hereby granted, provided that the above
- * copyright notice and this permission notice appear in all copies.
- *
- * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
#include <linux/module.h>
#include <linux/kernel.h>
diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
index 3faea66b1979..b624da5026f5 100644
--- a/include/net/bluetooth/bluetooth.h
+++ b/include/net/bluetooth/bluetooth.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2000-2001 Qualcomm Incorporated
@@ -5,10 +6,6 @@
Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
index 572b1c620c5d..a8b2e8781054 100644
--- a/include/net/bluetooth/hci.h
+++ b/include/net/bluetooth/hci.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2000-2001 Qualcomm Incorporated
@@ -5,10 +6,6 @@
Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
index aa600fbf9a53..7e15da47fe3a 100644
--- a/include/net/bluetooth/hci_core.h
+++ b/include/net/bluetooth/hci_core.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (c) 2000-2001, 2010, Code Aurora Forum. All rights reserved.
@@ -5,10 +6,6 @@
Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/include/net/bluetooth/hci_mon.h b/include/net/bluetooth/hci_mon.h
index bbd752494ef9..4b2a0af4ed58 100644
--- a/include/net/bluetooth/hci_mon.h
+++ b/include/net/bluetooth/hci_mon.h
@@ -1,12 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2011-2012 Intel Corporation
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/include/net/bluetooth/hci_sock.h b/include/net/bluetooth/hci_sock.h
index 13e8cd4414a1..16f150b861be 100644
--- a/include/net/bluetooth/hci_sock.h
+++ b/include/net/bluetooth/hci_sock.h
@@ -1,13 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2000-2001 Qualcomm Incorporated
Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
index 5172afee5494..b1039ebdf06f 100644
--- a/include/net/bluetooth/l2cap.h
+++ b/include/net/bluetooth/l2cap.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2000-2001 Qualcomm Incorporated
@@ -6,10 +7,6 @@
Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
index 8234915854b6..08daed7a96d5 100644
--- a/include/net/bluetooth/mgmt.h
+++ b/include/net/bluetooth/mgmt.h
@@ -1,13 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2010 Nokia Corporation
Copyright (C) 2011-2012 Intel Corporation
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/include/net/bluetooth/rfcomm.h b/include/net/bluetooth/rfcomm.h
index c05882476900..feb6b3ae5e69 100644
--- a/include/net/bluetooth/rfcomm.h
+++ b/include/net/bluetooth/rfcomm.h
@@ -1,12 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
RFCOMM implementation for Linux Bluetooth stack (BlueZ)
Copyright (C) 2002 Maxim Krasnyansky <maxk@qualcomm.com>
Copyright (C) 2002 Marcel Holtmann <marcel@holtmann.org>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/include/net/bluetooth/sco.h b/include/net/bluetooth/sco.h
index f40ddb4264fc..214409527b35 100644
--- a/include/net/bluetooth/sco.h
+++ b/include/net/bluetooth/sco.h
@@ -1,13 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2000-2001 Qualcomm Incorporated
Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/af_bluetooth.c b/net/bluetooth/af_bluetooth.c
index 1a6aa3f8d4d6..bcbc11c9cb15 100644
--- a/net/bluetooth/af_bluetooth.c
+++ b/net/bluetooth/af_bluetooth.c
@@ -1,13 +1,10 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2000-2001 Qualcomm Incorporated
Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/bnep/core.c b/net/bluetooth/bnep/core.c
index 0de5df690bd0..b18e1cf28bb4 100644
--- a/net/bluetooth/bnep/core.c
+++ b/net/bluetooth/bnep/core.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BNEP implementation for Linux Bluetooth stack (BlueZ).
Copyright (C) 2001-2002 Inventel Systemes
@@ -7,10 +8,6 @@
Copyright (C) 2002 Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/bnep/netdev.c b/net/bluetooth/bnep/netdev.c
index cc1cff63194f..ee1e39a3daff 100644
--- a/net/bluetooth/bnep/netdev.c
+++ b/net/bluetooth/bnep/netdev.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BNEP implementation for Linux Bluetooth stack (BlueZ).
Copyright (C) 2001-2002 Inventel Systemes
@@ -7,10 +8,6 @@
Copyright (C) 2002 Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/bnep/sock.c b/net/bluetooth/bnep/sock.c
index 00d47bcf4d7d..f3fe818d0e4c 100644
--- a/net/bluetooth/bnep/sock.c
+++ b/net/bluetooth/bnep/sock.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BNEP implementation for Linux Bluetooth stack (BlueZ).
Copyright (C) 2001-2002 Inventel Systemes
@@ -6,10 +7,6 @@
Copyright (C) 2002 Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/ecdh_helper.c b/net/bluetooth/ecdh_helper.c
index 0efc93fdae8a..1938e5559d88 100644
--- a/net/bluetooth/ecdh_helper.c
+++ b/net/bluetooth/ecdh_helper.c
@@ -1,12 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
/*
* ECDH helper functions - KPP wrappings
*
* Copyright (C) 2017 Intel Corporation
*
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation;
- *
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
* OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/ecdh_helper.h b/net/bluetooth/ecdh_helper.h
index 830723971cf8..9d787d3c8797 100644
--- a/net/bluetooth/ecdh_helper.h
+++ b/net/bluetooth/ecdh_helper.h
@@ -1,12 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* ECDH helper functions - KPP wrappings
*
* Copyright (C) 2017 Intel Corporation
*
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation;
- *
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
* OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index 54eabaa46960..c335372e4062 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (c) 2000-2001, 2010, Code Aurora Forum. All rights reserved.
@@ -5,10 +6,6 @@
Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 28d7929dc593..243d01069a91 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2000-2001 Qualcomm Incorporated
@@ -5,10 +6,6 @@
Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/hci_debugfs.c b/net/bluetooth/hci_debugfs.c
index 99e2e9fc70e8..0635e4641db4 100644
--- a/net/bluetooth/hci_debugfs.c
+++ b/net/bluetooth/hci_debugfs.c
@@ -1,12 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2014 Intel Corporation
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/hci_debugfs.h b/net/bluetooth/hci_debugfs.h
index 9a8a7c93bb12..92365cbc922a 100644
--- a/net/bluetooth/hci_debugfs.h
+++ b/net/bluetooth/hci_debugfs.h
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2014 Intel Corporation
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index eea2f810aafa..e588c744ce36 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (c) 2000-2001, 2010, Code Aurora Forum. All rights reserved.
@@ -5,10 +6,6 @@
Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c
index 0290dea081f6..c81852411250 100644
--- a/net/bluetooth/hci_sock.c
+++ b/net/bluetooth/hci_sock.c
@@ -1,13 +1,10 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2000-2001 Qualcomm Incorporated
Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index 70344bd3248a..0e24c5e2955e 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -1,12 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
/*
HIDP implementation for Linux Bluetooth stack (BlueZ).
Copyright (C) 2003-2004 Marcel Holtmann <marcel@holtmann.org>
Copyright (C) 2013 David Herrmann <dh.herrmann@gmail.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/hidp/hidp.h b/net/bluetooth/hidp/hidp.h
index 6ef88d0a1919..959b745bb770 100644
--- a/net/bluetooth/hidp/hidp.h
+++ b/net/bluetooth/hidp/hidp.h
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
HIDP implementation for Linux Bluetooth stack (BlueZ).
Copyright (C) 2003-2004 Marcel Holtmann <marcel@holtmann.org>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/hidp/sock.c b/net/bluetooth/hidp/sock.c
index c93aaeb3a3fa..b75bea3cf422 100644
--- a/net/bluetooth/hidp/sock.c
+++ b/net/bluetooth/hidp/sock.c
@@ -1,11 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
/*
HIDP implementation for Linux Bluetooth stack (BlueZ).
Copyright (C) 2003-2004 Marcel Holtmann <marcel@holtmann.org>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 45b175399e8d..ad2f26d935ca 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2000-2001 Qualcomm Incorporated
@@ -8,10 +9,6 @@
Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
index c138aa4ae266..e3eda309f1b3 100644
--- a/net/bluetooth/l2cap_sock.c
+++ b/net/bluetooth/l2cap_sock.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2000-2001 Qualcomm Incorporated
@@ -7,10 +8,6 @@
Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/lib.c b/net/bluetooth/lib.c
index 305044a84478..cea21a4c49a0 100644
--- a/net/bluetooth/lib.c
+++ b/net/bluetooth/lib.c
@@ -1,13 +1,10 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2000-2001 Qualcomm Incorporated
Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index de5bd6b637b2..a732b586979d 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -1,13 +1,10 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2010 Nokia Corporation
Copyright (C) 2011-2012 Intel Corporation
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/mgmt_util.c b/net/bluetooth/mgmt_util.c
index 4f19654d41a9..6ea107c0e054 100644
--- a/net/bluetooth/mgmt_util.c
+++ b/net/bluetooth/mgmt_util.c
@@ -1,12 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2015 Intel Corporation
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/mgmt_util.h b/net/bluetooth/mgmt_util.h
index bcba8c9d8952..20810cf06e81 100644
--- a/net/bluetooth/mgmt_util.h
+++ b/net/bluetooth/mgmt_util.h
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2015 Intel Coropration
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/rfcomm/core.c b/net/bluetooth/rfcomm/core.c
index d11bd5337d57..593583c694a7 100644
--- a/net/bluetooth/rfcomm/core.c
+++ b/net/bluetooth/rfcomm/core.c
@@ -1,12 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
/*
RFCOMM implementation for Linux Bluetooth stack (BlueZ).
Copyright (C) 2002 Maxim Krasnyansky <maxk@qualcomm.com>
Copyright (C) 2002 Marcel Holtmann <marcel@holtmann.org>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/rfcomm/sock.c b/net/bluetooth/rfcomm/sock.c
index bd7d959c6e9e..bb7cf98f85cf 100644
--- a/net/bluetooth/rfcomm/sock.c
+++ b/net/bluetooth/rfcomm/sock.c
@@ -1,12 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
/*
RFCOMM implementation for Linux Bluetooth stack (BlueZ).
Copyright (C) 2002 Maxim Krasnyansky <maxk@qualcomm.com>
Copyright (C) 2002 Marcel Holtmann <marcel@holtmann.org>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/rfcomm/tty.c b/net/bluetooth/rfcomm/tty.c
index 91bf5274262e..4b9a699ec59b 100644
--- a/net/bluetooth/rfcomm/tty.c
+++ b/net/bluetooth/rfcomm/tty.c
@@ -1,12 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
/*
RFCOMM implementation for Linux Bluetooth stack (BlueZ).
Copyright (C) 2002 Maxim Krasnyansky <maxk@qualcomm.com>
Copyright (C) 2002 Marcel Holtmann <marcel@holtmann.org>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c
index f1799c6a6f87..be5614a6c5ee 100644
--- a/net/bluetooth/sco.c
+++ b/net/bluetooth/sco.c
@@ -1,13 +1,10 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2000-2001 Qualcomm Incorporated
Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/selftest.c b/net/bluetooth/selftest.c
index f49604d44b87..ae5b44bb9d3d 100644
--- a/net/bluetooth/selftest.c
+++ b/net/bluetooth/selftest.c
@@ -1,12 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2014 Intel Corporation
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/selftest.h b/net/bluetooth/selftest.h
index 2aa0a346a913..34d684ee84fd 100644
--- a/net/bluetooth/selftest.h
+++ b/net/bluetooth/selftest.h
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2014 Intel Corporation
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/smp.c b/net/bluetooth/smp.c
index 98f1da4f5f55..ef464568b9c7 100644
--- a/net/bluetooth/smp.c
+++ b/net/bluetooth/smp.c
@@ -1,11 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2011 Nokia Corporation and/or its subsidiary(-ies).
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
diff --git a/net/bluetooth/smp.h b/net/bluetooth/smp.h
index c5da53dfab04..eac27bd541bb 100644
--- a/net/bluetooth/smp.h
+++ b/net/bluetooth/smp.h
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
BlueZ - Bluetooth protocol stack for Linux
Copyright (C) 2011 Nokia Corporation and/or its subsidiary(-ies).
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License version 2 as
- published by the Free Software Foundation;
-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
--
2.43.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* RE: [v2] Bluetooth: Add SPDX id lines to some source files
2026-06-04 0:41 [PATCH v2] Bluetooth: Add SPDX id lines to some source files Tim Bird
@ 2026-06-04 5:48 ` bluez.test.bot
2026-06-04 11:32 ` [PATCH v2] " Bastien Nocera
2026-06-04 15:28 ` Luiz Augusto von Dentz
2 siblings, 0 replies; 9+ messages in thread
From: bluez.test.bot @ 2026-06-04 5:48 UTC (permalink / raw)
To: linux-bluetooth, Tim.Bird
[-- Attachment #1: Type: text/plain, Size: 2473 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1105609
---Test result---
Test Summary:
CheckPatch PASS 11.11 seconds
VerifyFixes PASS 0.12 seconds
VerifySignedoff PASS 0.12 seconds
GitLint PASS 0.29 seconds
SubjectPrefix PASS 0.16 seconds
BuildKernel PASS 24.21 seconds
CheckAllWarning PASS 26.43 seconds
CheckSparse PASS 25.14 seconds
BuildKernel32 PASS 23.25 seconds
TestRunnerSetup PASS 521.43 seconds
TestRunner_l2cap-tester FAIL 60.35 seconds
TestRunner_iso-tester PASS 82.36 seconds
TestRunner_bnep-tester PASS 18.66 seconds
TestRunner_mgmt-tester FAIL 212.20 seconds
TestRunner_rfcomm-tester PASS 25.41 seconds
TestRunner_sco-tester PASS 32.36 seconds
TestRunner_ioctl-tester PASS 25.64 seconds
TestRunner_mesh-tester FAIL 24.88 seconds
TestRunner_smp-tester PASS 23.19 seconds
TestRunner_userchan-tester PASS 19.58 seconds
TestRunner_6lowpan-tester PASS 22.48 seconds
IncrementalBuild PASS 22.52 seconds
Details
##############################
Test: TestRunner_l2cap-tester - FAIL
Desc: Run l2cap-tester with test-runner
Output:
Total: 96, Passed: 95 (99.0%), Failed: 1, Not Run: 0
Failed Test Cases
L2CAP BR/EDR Server - Set PHY 3M Failed 0.277 seconds
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
Read Exp Feature - Success Failed 0.243 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 1.857 seconds
Mesh - Send cancel - 2 Timed out 1.989 seconds
https://github.com/bluez/bluetooth-next/pull/285
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] Bluetooth: Add SPDX id lines to some source files
2026-06-04 0:41 [PATCH v2] Bluetooth: Add SPDX id lines to some source files Tim Bird
2026-06-04 5:48 ` [v2] " bluez.test.bot
@ 2026-06-04 11:32 ` Bastien Nocera
2026-06-04 15:16 ` Luiz Augusto von Dentz
2026-06-04 16:38 ` Bird, Tim
2026-06-04 15:28 ` Luiz Augusto von Dentz
2 siblings, 2 replies; 9+ messages in thread
From: Bastien Nocera @ 2026-06-04 11:32 UTC (permalink / raw)
To: Tim Bird, marcel, luiz.dentz, jannh, kuba, kiran.k, chharry,
gustavo, prameela.j04cs, salvatore.benedetto, maxk
Cc: linux-bluetooth, linux-spdx, linux-kernel
Hello Tim,
On Wed, 2026-06-03 at 18:41 -0600, Tim Bird wrote:
> Many bluetooth source files are missing SPDX-License-Identifier
> lines. Add appropriate IDs to these files, and remove other
> license lines from the headers.
I think it would be useful to separate the changes in drivers/bluetooth
and the ones in {include/,}net/bluetooth.
Why do some of the id lines use C-style comments and others C++-style
comments? (/* */ vs. //) ?
> Leave the warranty disclaimer in files where the license ID is
> GPL-2.0 but the wording of the disclaimer is slightly different
> from that of the GPL v2 disclaimer.
>
> It is not different enough to cause licensing conflicts, but is
> kept to honor the original contributors' legal intent.
Good job doing this, do you know if there's a plan to automate this
somehow? It would be great to be able to re-run a script on top of a
codebase to verify that no sources were missed, and that we got the
same license ID assigned for the same license verbiage in the source
headers.
Cheers
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] Bluetooth: Add SPDX id lines to some source files
2026-06-04 11:32 ` [PATCH v2] " Bastien Nocera
@ 2026-06-04 15:16 ` Luiz Augusto von Dentz
2026-06-04 16:38 ` Bird, Tim
1 sibling, 0 replies; 9+ messages in thread
From: Luiz Augusto von Dentz @ 2026-06-04 15:16 UTC (permalink / raw)
To: Bastien Nocera
Cc: Tim Bird, marcel, jannh, kuba, kiran.k, chharry, gustavo,
prameela.j04cs, salvatore.benedetto, maxk, linux-bluetooth,
linux-spdx, linux-kernel
Hi Bastien,
On Thu, Jun 4, 2026 at 7:32 AM Bastien Nocera <hadess@hadess.net> wrote:
>
> Hello Tim,
>
> On Wed, 2026-06-03 at 18:41 -0600, Tim Bird wrote:
> > Many bluetooth source files are missing SPDX-License-Identifier
> > lines. Add appropriate IDs to these files, and remove other
> > license lines from the headers.
>
> I think it would be useful to separate the changes in drivers/bluetooth
> and the ones in {include/,}net/bluetooth.
>
> Why do some of the id lines use C-style comments and others C++-style
> comments? (/* */ vs. //) ?
It seems to be a common practice where on *.c it uses // and on *.h /*
*/ is used, it is consistent across other subsystems and the BlueZ
userspace tree as well.
> > Leave the warranty disclaimer in files where the license ID is
> > GPL-2.0 but the wording of the disclaimer is slightly different
> > from that of the GPL v2 disclaimer.
> >
> > It is not different enough to cause licensing conflicts, but is
> > kept to honor the original contributors' legal intent.
>
> Good job doing this, do you know if there's a plan to automate this
> somehow? It would be great to be able to re-run a script on top of a
> codebase to verify that no sources were missed, and that we got the
> same license ID assigned for the same license verbiage in the source
> headers.
>
> Cheers
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH v2] Bluetooth: Add SPDX id lines to some source files
2026-06-04 11:32 ` [PATCH v2] " Bastien Nocera
2026-06-04 15:16 ` Luiz Augusto von Dentz
@ 2026-06-04 16:38 ` Bird, Tim
1 sibling, 0 replies; 9+ messages in thread
From: Bird, Tim @ 2026-06-04 16:38 UTC (permalink / raw)
To: Bastien Nocera, marcel@holtmann.org, luiz.dentz@gmail.com,
jannh@google.com, kuba@kernel.org, kiran.k@intel.com,
chharry@chromium.org, gustavo@padovan.org,
prameela.j04cs@gmail.com, salvatore.benedetto@intel.com,
maxk@qualcomm.com
Cc: linux-bluetooth@vger.kernel.org, linux-spdx@vger.kernel.org,
linux-kernel@vger.kernel.org
Hey Bastien,
> -----Original Message-----
> From: Bastien Nocera <hadess@hadess.net>
> Hello Tim,
>
> On Wed, 2026-06-03 at 18:41 -0600, Tim Bird wrote:
> > Many bluetooth source files are missing SPDX-License-Identifier
> > lines. Add appropriate IDs to these files, and remove other
> > license lines from the headers.
>
> I think it would be useful to separate the changes in drivers/bluetooth
> and the ones in {include/,}net/bluetooth.
I thought about that. There's only one file in drivers/bluetooth in this patch,
and it's got a very straightforward and unambiguous license situation.
I thought it would be easier for the Bluetooth maintainers to see one patch
instead of multiple, but I can break that one file out if needed.
These types of changes are usually done in batches, with patch boundaries
matching maintainer or sub-system boundaries, rather than directory
boundaries.
>
> Why do some of the id lines use C-style comments and others C++-style
> comments? (/* */ vs. //) ?
This is due to some old parsers that operate on kernel source not handling
// in .h files very well.
See Documentation/process/license-rules.rst (Section 2 on Style:)
> > Leave the warranty disclaimer in files where the license ID is
> > GPL-2.0 but the wording of the disclaimer is slightly different
> > from that of the GPL v2 disclaimer.
> >
> > It is not different enough to cause licensing conflicts, but is
> > kept to honor the original contributors' legal intent.
>
> Good job doing this, do you know if there's a plan to automate this
> somehow?
A lot of what could be done automatically was already done, in
2017 by Greg KH and in 2019 by Thomas Gleixner. I'm following up
now on files that were either overlooked, or have special issues.
I do use tools for analysis and to help automate some tasks.
See https://github.com/tbird20d/spdx-project
> It would be great to be able to re-run a script on top of a
> codebase to verify that no sources were missed, and that we got the
> same license ID assigned for the same license verbiage in the source
> headers.
See scripts/spdxcheck.py.
I also have some automation that checks
the overall status (by top-level kernel directory), with results posted here:
https://birdcloud.org/bc/KTest_Missing_SPDX
Some of the tools I use check the license verbiage in the source headers,
but I also manually compare the verbiage to make sure I am assigning
the right license. In the case of these Bluetooth files, the verbiage is quite
clear about the intended license, but I got caught by some differences
in the warranty disclaimer that I missed, making a second version of this
patch necessary.
-- Tim
P.S. I gave a talk on this work at Open Source Summit North America a few weeks ago.
You can find my slides and info about that talk here:
https://osselcna2026.sched.com/event/2JQtC/spdx-and-sbom-work-for-the-linux-kernel-tim-bird-sony-electronics
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] Bluetooth: Add SPDX id lines to some source files
2026-06-04 0:41 [PATCH v2] Bluetooth: Add SPDX id lines to some source files Tim Bird
2026-06-04 5:48 ` [v2] " bluez.test.bot
2026-06-04 11:32 ` [PATCH v2] " Bastien Nocera
@ 2026-06-04 15:28 ` Luiz Augusto von Dentz
2026-06-04 16:41 ` Bird, Tim
2 siblings, 1 reply; 9+ messages in thread
From: Luiz Augusto von Dentz @ 2026-06-04 15:28 UTC (permalink / raw)
To: Tim Bird
Cc: marcel, jannh, kuba, kiran.k, chharry, gustavo, prameela.j04cs,
salvatore.benedetto, maxk, linux-bluetooth, linux-spdx,
linux-kernel
Hi Tim,
On Wed, Jun 3, 2026 at 8:44 PM Tim Bird <tim.bird@sony.com> wrote:
>
> Many bluetooth source files are missing SPDX-License-Identifier
> lines. Add appropriate IDs to these files, and remove other
> license lines from the headers.
>
> Leave the warranty disclaimer in files where the license ID is
> GPL-2.0 but the wording of the disclaimer is slightly different
> from that of the GPL v2 disclaimer.
>
> It is not different enough to cause licensing conflicts, but is
> kept to honor the original contributors' legal intent.
>
> ---
> V1 -> V2:
> - Leave different warranty disclaimers (which is most them)
> - Remove files recently removed from drivers/bluetooth from the patch
>
> Signed-off-by: Tim Bird <tim.bird@sony.com>
`git am` doesn't pick up your Signed-off-by because it is after ---`,
it seems to be considered a comment.
> ---
> drivers/bluetooth/btrsi.c | 12 +-----------
> include/net/bluetooth/bluetooth.h | 5 +----
> include/net/bluetooth/hci.h | 5 +----
> include/net/bluetooth/hci_core.h | 5 +----
> include/net/bluetooth/hci_mon.h | 5 +----
> include/net/bluetooth/hci_sock.h | 5 +----
> include/net/bluetooth/l2cap.h | 5 +----
> include/net/bluetooth/mgmt.h | 5 +----
> include/net/bluetooth/rfcomm.h | 5 +----
> include/net/bluetooth/sco.h | 5 +----
> net/bluetooth/af_bluetooth.c | 5 +----
> net/bluetooth/bnep/core.c | 5 +----
> net/bluetooth/bnep/netdev.c | 5 +----
> net/bluetooth/bnep/sock.c | 5 +----
> net/bluetooth/ecdh_helper.c | 5 +----
> net/bluetooth/ecdh_helper.h | 5 +----
> net/bluetooth/hci_conn.c | 5 +----
> net/bluetooth/hci_core.c | 5 +----
> net/bluetooth/hci_debugfs.c | 5 +----
> net/bluetooth/hci_debugfs.h | 5 +----
> net/bluetooth/hci_event.c | 5 +----
> net/bluetooth/hci_sock.c | 5 +----
> net/bluetooth/hidp/core.c | 5 +----
> net/bluetooth/hidp/hidp.h | 5 +----
> net/bluetooth/hidp/sock.c | 5 +----
> net/bluetooth/l2cap_core.c | 5 +----
> net/bluetooth/l2cap_sock.c | 5 +----
> net/bluetooth/lib.c | 5 +----
> net/bluetooth/mgmt.c | 5 +----
> net/bluetooth/mgmt_util.c | 5 +----
> net/bluetooth/mgmt_util.h | 5 +----
> net/bluetooth/rfcomm/core.c | 5 +----
> net/bluetooth/rfcomm/sock.c | 5 +----
> net/bluetooth/rfcomm/tty.c | 5 +----
> net/bluetooth/sco.c | 5 +----
> net/bluetooth/selftest.c | 5 +----
> net/bluetooth/selftest.h | 5 +----
> net/bluetooth/smp.c | 5 +----
> net/bluetooth/smp.h | 5 +----
> 39 files changed, 39 insertions(+), 163 deletions(-)
>
> diff --git a/drivers/bluetooth/btrsi.c b/drivers/bluetooth/btrsi.c
> index c68dd2fba01c..59ad0b9b14c3 100644
> --- a/drivers/bluetooth/btrsi.c
> +++ b/drivers/bluetooth/btrsi.c
> @@ -1,17 +1,7 @@
> +// SPDX-License-Identifier: ISC
> /*
> * Copyright (c) 2017 Redpine Signals Inc.
> *
> - * Permission to use, copy, modify, and/or distribute this software for any
> - * purpose with or without fee is hereby granted, provided that the above
> - * copyright notice and this permission notice appear in all copies.
> - *
> - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
> - * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
> - * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
> - * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
> - * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
> - * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
> - * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
> */
> #include <linux/module.h>
> #include <linux/kernel.h>
> diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
> index 3faea66b1979..b624da5026f5 100644
> --- a/include/net/bluetooth/bluetooth.h
> +++ b/include/net/bluetooth/bluetooth.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2000-2001 Qualcomm Incorporated
> @@ -5,10 +6,6 @@
>
> Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index 572b1c620c5d..a8b2e8781054 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2000-2001 Qualcomm Incorporated
> @@ -5,10 +6,6 @@
>
> Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> index aa600fbf9a53..7e15da47fe3a 100644
> --- a/include/net/bluetooth/hci_core.h
> +++ b/include/net/bluetooth/hci_core.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (c) 2000-2001, 2010, Code Aurora Forum. All rights reserved.
> @@ -5,10 +6,6 @@
>
> Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/include/net/bluetooth/hci_mon.h b/include/net/bluetooth/hci_mon.h
> index bbd752494ef9..4b2a0af4ed58 100644
> --- a/include/net/bluetooth/hci_mon.h
> +++ b/include/net/bluetooth/hci_mon.h
> @@ -1,12 +1,9 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> BlueZ - Bluetooth protocol stack for Linux
>
> Copyright (C) 2011-2012 Intel Corporation
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/include/net/bluetooth/hci_sock.h b/include/net/bluetooth/hci_sock.h
> index 13e8cd4414a1..16f150b861be 100644
> --- a/include/net/bluetooth/hci_sock.h
> +++ b/include/net/bluetooth/hci_sock.h
> @@ -1,13 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2000-2001 Qualcomm Incorporated
>
> Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
> index 5172afee5494..b1039ebdf06f 100644
> --- a/include/net/bluetooth/l2cap.h
> +++ b/include/net/bluetooth/l2cap.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2000-2001 Qualcomm Incorporated
> @@ -6,10 +7,6 @@
>
> Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
> index 8234915854b6..08daed7a96d5 100644
> --- a/include/net/bluetooth/mgmt.h
> +++ b/include/net/bluetooth/mgmt.h
> @@ -1,13 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> BlueZ - Bluetooth protocol stack for Linux
>
> Copyright (C) 2010 Nokia Corporation
> Copyright (C) 2011-2012 Intel Corporation
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/include/net/bluetooth/rfcomm.h b/include/net/bluetooth/rfcomm.h
> index c05882476900..feb6b3ae5e69 100644
> --- a/include/net/bluetooth/rfcomm.h
> +++ b/include/net/bluetooth/rfcomm.h
> @@ -1,12 +1,9 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> RFCOMM implementation for Linux Bluetooth stack (BlueZ)
> Copyright (C) 2002 Maxim Krasnyansky <maxk@qualcomm.com>
> Copyright (C) 2002 Marcel Holtmann <marcel@holtmann.org>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/include/net/bluetooth/sco.h b/include/net/bluetooth/sco.h
> index f40ddb4264fc..214409527b35 100644
> --- a/include/net/bluetooth/sco.h
> +++ b/include/net/bluetooth/sco.h
> @@ -1,13 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2000-2001 Qualcomm Incorporated
>
> Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/af_bluetooth.c b/net/bluetooth/af_bluetooth.c
> index 1a6aa3f8d4d6..bcbc11c9cb15 100644
> --- a/net/bluetooth/af_bluetooth.c
> +++ b/net/bluetooth/af_bluetooth.c
> @@ -1,13 +1,10 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2000-2001 Qualcomm Incorporated
>
> Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/bnep/core.c b/net/bluetooth/bnep/core.c
> index 0de5df690bd0..b18e1cf28bb4 100644
> --- a/net/bluetooth/bnep/core.c
> +++ b/net/bluetooth/bnep/core.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BNEP implementation for Linux Bluetooth stack (BlueZ).
> Copyright (C) 2001-2002 Inventel Systemes
> @@ -7,10 +8,6 @@
>
> Copyright (C) 2002 Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/bnep/netdev.c b/net/bluetooth/bnep/netdev.c
> index cc1cff63194f..ee1e39a3daff 100644
> --- a/net/bluetooth/bnep/netdev.c
> +++ b/net/bluetooth/bnep/netdev.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BNEP implementation for Linux Bluetooth stack (BlueZ).
> Copyright (C) 2001-2002 Inventel Systemes
> @@ -7,10 +8,6 @@
>
> Copyright (C) 2002 Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/bnep/sock.c b/net/bluetooth/bnep/sock.c
> index 00d47bcf4d7d..f3fe818d0e4c 100644
> --- a/net/bluetooth/bnep/sock.c
> +++ b/net/bluetooth/bnep/sock.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BNEP implementation for Linux Bluetooth stack (BlueZ).
> Copyright (C) 2001-2002 Inventel Systemes
> @@ -6,10 +7,6 @@
>
> Copyright (C) 2002 Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/ecdh_helper.c b/net/bluetooth/ecdh_helper.c
> index 0efc93fdae8a..1938e5559d88 100644
> --- a/net/bluetooth/ecdh_helper.c
> +++ b/net/bluetooth/ecdh_helper.c
> @@ -1,12 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * ECDH helper functions - KPP wrappings
> *
> * Copyright (C) 2017 Intel Corporation
> *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation;
> - *
> * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> * OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/ecdh_helper.h b/net/bluetooth/ecdh_helper.h
> index 830723971cf8..9d787d3c8797 100644
> --- a/net/bluetooth/ecdh_helper.h
> +++ b/net/bluetooth/ecdh_helper.h
> @@ -1,12 +1,9 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> * ECDH helper functions - KPP wrappings
> *
> * Copyright (C) 2017 Intel Corporation
> *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation;
> - *
> * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> * OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
> index 54eabaa46960..c335372e4062 100644
> --- a/net/bluetooth/hci_conn.c
> +++ b/net/bluetooth/hci_conn.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (c) 2000-2001, 2010, Code Aurora Forum. All rights reserved.
> @@ -5,10 +6,6 @@
>
> Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index 28d7929dc593..243d01069a91 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2000-2001 Qualcomm Incorporated
> @@ -5,10 +6,6 @@
>
> Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/hci_debugfs.c b/net/bluetooth/hci_debugfs.c
> index 99e2e9fc70e8..0635e4641db4 100644
> --- a/net/bluetooth/hci_debugfs.c
> +++ b/net/bluetooth/hci_debugfs.c
> @@ -1,12 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BlueZ - Bluetooth protocol stack for Linux
>
> Copyright (C) 2014 Intel Corporation
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/hci_debugfs.h b/net/bluetooth/hci_debugfs.h
> index 9a8a7c93bb12..92365cbc922a 100644
> --- a/net/bluetooth/hci_debugfs.h
> +++ b/net/bluetooth/hci_debugfs.h
> @@ -1,11 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2014 Intel Corporation
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index eea2f810aafa..e588c744ce36 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (c) 2000-2001, 2010, Code Aurora Forum. All rights reserved.
> @@ -5,10 +6,6 @@
>
> Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c
> index 0290dea081f6..c81852411250 100644
> --- a/net/bluetooth/hci_sock.c
> +++ b/net/bluetooth/hci_sock.c
> @@ -1,13 +1,10 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2000-2001 Qualcomm Incorporated
>
> Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
> index 70344bd3248a..0e24c5e2955e 100644
> --- a/net/bluetooth/hidp/core.c
> +++ b/net/bluetooth/hidp/core.c
> @@ -1,12 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> HIDP implementation for Linux Bluetooth stack (BlueZ).
> Copyright (C) 2003-2004 Marcel Holtmann <marcel@holtmann.org>
> Copyright (C) 2013 David Herrmann <dh.herrmann@gmail.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/hidp/hidp.h b/net/bluetooth/hidp/hidp.h
> index 6ef88d0a1919..959b745bb770 100644
> --- a/net/bluetooth/hidp/hidp.h
> +++ b/net/bluetooth/hidp/hidp.h
> @@ -1,11 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> HIDP implementation for Linux Bluetooth stack (BlueZ).
> Copyright (C) 2003-2004 Marcel Holtmann <marcel@holtmann.org>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/hidp/sock.c b/net/bluetooth/hidp/sock.c
> index c93aaeb3a3fa..b75bea3cf422 100644
> --- a/net/bluetooth/hidp/sock.c
> +++ b/net/bluetooth/hidp/sock.c
> @@ -1,11 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> HIDP implementation for Linux Bluetooth stack (BlueZ).
> Copyright (C) 2003-2004 Marcel Holtmann <marcel@holtmann.org>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index 45b175399e8d..ad2f26d935ca 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2000-2001 Qualcomm Incorporated
> @@ -8,10 +9,6 @@
>
> Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
> index c138aa4ae266..e3eda309f1b3 100644
> --- a/net/bluetooth/l2cap_sock.c
> +++ b/net/bluetooth/l2cap_sock.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2000-2001 Qualcomm Incorporated
> @@ -7,10 +8,6 @@
>
> Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/lib.c b/net/bluetooth/lib.c
> index 305044a84478..cea21a4c49a0 100644
> --- a/net/bluetooth/lib.c
> +++ b/net/bluetooth/lib.c
> @@ -1,13 +1,10 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2000-2001 Qualcomm Incorporated
>
> Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index de5bd6b637b2..a732b586979d 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -1,13 +1,10 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BlueZ - Bluetooth protocol stack for Linux
>
> Copyright (C) 2010 Nokia Corporation
> Copyright (C) 2011-2012 Intel Corporation
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/mgmt_util.c b/net/bluetooth/mgmt_util.c
> index 4f19654d41a9..6ea107c0e054 100644
> --- a/net/bluetooth/mgmt_util.c
> +++ b/net/bluetooth/mgmt_util.c
> @@ -1,12 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BlueZ - Bluetooth protocol stack for Linux
>
> Copyright (C) 2015 Intel Corporation
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/mgmt_util.h b/net/bluetooth/mgmt_util.h
> index bcba8c9d8952..20810cf06e81 100644
> --- a/net/bluetooth/mgmt_util.h
> +++ b/net/bluetooth/mgmt_util.h
> @@ -1,11 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2015 Intel Coropration
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/rfcomm/core.c b/net/bluetooth/rfcomm/core.c
> index d11bd5337d57..593583c694a7 100644
> --- a/net/bluetooth/rfcomm/core.c
> +++ b/net/bluetooth/rfcomm/core.c
> @@ -1,12 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> RFCOMM implementation for Linux Bluetooth stack (BlueZ).
> Copyright (C) 2002 Maxim Krasnyansky <maxk@qualcomm.com>
> Copyright (C) 2002 Marcel Holtmann <marcel@holtmann.org>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/rfcomm/sock.c b/net/bluetooth/rfcomm/sock.c
> index bd7d959c6e9e..bb7cf98f85cf 100644
> --- a/net/bluetooth/rfcomm/sock.c
> +++ b/net/bluetooth/rfcomm/sock.c
> @@ -1,12 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> RFCOMM implementation for Linux Bluetooth stack (BlueZ).
> Copyright (C) 2002 Maxim Krasnyansky <maxk@qualcomm.com>
> Copyright (C) 2002 Marcel Holtmann <marcel@holtmann.org>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/rfcomm/tty.c b/net/bluetooth/rfcomm/tty.c
> index 91bf5274262e..4b9a699ec59b 100644
> --- a/net/bluetooth/rfcomm/tty.c
> +++ b/net/bluetooth/rfcomm/tty.c
> @@ -1,12 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> RFCOMM implementation for Linux Bluetooth stack (BlueZ).
> Copyright (C) 2002 Maxim Krasnyansky <maxk@qualcomm.com>
> Copyright (C) 2002 Marcel Holtmann <marcel@holtmann.org>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c
> index f1799c6a6f87..be5614a6c5ee 100644
> --- a/net/bluetooth/sco.c
> +++ b/net/bluetooth/sco.c
> @@ -1,13 +1,10 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2000-2001 Qualcomm Incorporated
>
> Written 2000,2001 by Maxim Krasnyansky <maxk@qualcomm.com>
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/selftest.c b/net/bluetooth/selftest.c
> index f49604d44b87..ae5b44bb9d3d 100644
> --- a/net/bluetooth/selftest.c
> +++ b/net/bluetooth/selftest.c
> @@ -1,12 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BlueZ - Bluetooth protocol stack for Linux
>
> Copyright (C) 2014 Intel Corporation
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/selftest.h b/net/bluetooth/selftest.h
> index 2aa0a346a913..34d684ee84fd 100644
> --- a/net/bluetooth/selftest.h
> +++ b/net/bluetooth/selftest.h
> @@ -1,11 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2014 Intel Corporation
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/smp.c b/net/bluetooth/smp.c
> index 98f1da4f5f55..ef464568b9c7 100644
> --- a/net/bluetooth/smp.c
> +++ b/net/bluetooth/smp.c
> @@ -1,11 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2011 Nokia Corporation and/or its subsidiary(-ies).
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> diff --git a/net/bluetooth/smp.h b/net/bluetooth/smp.h
> index c5da53dfab04..eac27bd541bb 100644
> --- a/net/bluetooth/smp.h
> +++ b/net/bluetooth/smp.h
> @@ -1,11 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> BlueZ - Bluetooth protocol stack for Linux
> Copyright (C) 2011 Nokia Corporation and/or its subsidiary(-ies).
>
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License version 2 as
> - published by the Free Software Foundation;
> -
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
> --
> 2.43.0
>
>
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v2] Bluetooth: Add SPDX id lines to some source files
2026-06-04 15:28 ` Luiz Augusto von Dentz
@ 2026-06-04 16:41 ` Bird, Tim
2026-06-04 16:53 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 9+ messages in thread
From: Bird, Tim @ 2026-06-04 16:41 UTC (permalink / raw)
To: Luiz Augusto von Dentz
Cc: marcel@holtmann.org, jannh@google.com, kuba@kernel.org,
kiran.k@intel.com, chharry@chromium.org, gustavo@padovan.org,
prameela.j04cs@gmail.com, salvatore.benedetto@intel.com,
maxk@qualcomm.com, linux-bluetooth@vger.kernel.org,
linux-spdx@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> Hi Tim,
>
> On Wed, Jun 3, 2026 at 8:44 PM Tim Bird <tim.bird@sony.com> wrote:
> >
> > Many bluetooth source files are missing SPDX-License-Identifier
> > lines. Add appropriate IDs to these files, and remove other
> > license lines from the headers.
> >
> > Leave the warranty disclaimer in files where the license ID is
> > GPL-2.0 but the wording of the disclaimer is slightly different
> > from that of the GPL v2 disclaimer.
> >
> > It is not different enough to cause licensing conflicts, but is
> > kept to honor the original contributors' legal intent.
> >
> > ---
> > V1 -> V2:
> > - Leave different warranty disclaimers (which is most them)
> > - Remove files recently removed from drivers/bluetooth from the patch
> >
> > Signed-off-by: Tim Bird <tim.bird@sony.com>
>
> `git am` doesn't pick up your Signed-off-by because it is after ---`,
> it seems to be considered a comment.
Ah crud!! What a dumb mistake on my part.
Thanks for the heads up.
Should I send a v3 to fix this?
-- Tim
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] Bluetooth: Add SPDX id lines to some source files
2026-06-04 16:41 ` Bird, Tim
@ 2026-06-04 16:53 ` Luiz Augusto von Dentz
2026-06-04 17:03 ` Bird, Tim
0 siblings, 1 reply; 9+ messages in thread
From: Luiz Augusto von Dentz @ 2026-06-04 16:53 UTC (permalink / raw)
To: Bird, Tim
Cc: marcel@holtmann.org, jannh@google.com, kuba@kernel.org,
kiran.k@intel.com, chharry@chromium.org, gustavo@padovan.org,
prameela.j04cs@gmail.com, salvatore.benedetto@intel.com,
maxk@qualcomm.com, linux-bluetooth@vger.kernel.org,
linux-spdx@vger.kernel.org, linux-kernel@vger.kernel.org
Hi Tim,
On Thu, Jun 4, 2026 at 12:41 PM Bird, Tim <Tim.Bird@sony.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> > Hi Tim,
> >
> > On Wed, Jun 3, 2026 at 8:44 PM Tim Bird <tim.bird@sony.com> wrote:
> > >
> > > Many bluetooth source files are missing SPDX-License-Identifier
> > > lines. Add appropriate IDs to these files, and remove other
> > > license lines from the headers.
> > >
> > > Leave the warranty disclaimer in files where the license ID is
> > > GPL-2.0 but the wording of the disclaimer is slightly different
> > > from that of the GPL v2 disclaimer.
> > >
> > > It is not different enough to cause licensing conflicts, but is
> > > kept to honor the original contributors' legal intent.
> > >
> > > ---
> > > V1 -> V2:
> > > - Leave different warranty disclaimers (which is most them)
> > > - Remove files recently removed from drivers/bluetooth from the patch
> > >
> > > Signed-off-by: Tim Bird <tim.bird@sony.com>
> >
> > `git am` doesn't pick up your Signed-off-by because it is after ---`,
> > it seems to be considered a comment.
>
> Ah crud!! What a dumb mistake on my part.
> Thanks for the heads up.
>
> Should I send a v3 to fix this?
I can readd it manually if you are not planning a v3 to address other comments.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v2] Bluetooth: Add SPDX id lines to some source files
2026-06-04 16:53 ` Luiz Augusto von Dentz
@ 2026-06-04 17:03 ` Bird, Tim
0 siblings, 0 replies; 9+ messages in thread
From: Bird, Tim @ 2026-06-04 17:03 UTC (permalink / raw)
To: Luiz Augusto von Dentz
Cc: marcel@holtmann.org, jannh@google.com, kuba@kernel.org,
kiran.k@intel.com, chharry@chromium.org, gustavo@padovan.org,
prameela.j04cs@gmail.com, maxk@qualcomm.com,
linux-bluetooth@vger.kernel.org, linux-spdx@vger.kernel.org,
linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> Hi Tim,
>
> On Thu, Jun 4, 2026 at 12:41 PM Bird, Tim <Tim.Bird@sony.com> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> > > Hi Tim,
> > >
> > > On Wed, Jun 3, 2026 at 8:44 PM Tim Bird <tim.bird@sony.com> wrote:
> > > >
> > > > Many bluetooth source files are missing SPDX-License-Identifier
> > > > lines. Add appropriate IDs to these files, and remove other
> > > > license lines from the headers.
> > > >
> > > > Leave the warranty disclaimer in files where the license ID is
> > > > GPL-2.0 but the wording of the disclaimer is slightly different
> > > > from that of the GPL v2 disclaimer.
> > > >
> > > > It is not different enough to cause licensing conflicts, but is
> > > > kept to honor the original contributors' legal intent.
> > > >
> > > > ---
> > > > V1 -> V2:
> > > > - Leave different warranty disclaimers (which is most them)
> > > > - Remove files recently removed from drivers/bluetooth from the patch
> > > >
> > > > Signed-off-by: Tim Bird <tim.bird@sony.com>
> > >
> > > `git am` doesn't pick up your Signed-off-by because it is after ---`,
> > > it seems to be considered a comment.
> >
> > Ah crud!! What a dumb mistake on my part.
> > Thanks for the heads up.
> >
> > Should I send a v3 to fix this?
>
> I can readd it manually if you are not planning a v3 to address other comments.
I've got a v3 with this fix already made, and ready to send, but I was holding off to
see if any other comments showed up. I had planned to wait until tomorrow to send
it. I'm fine with either option: sending again, or having you manually fix it.
...
Ah, what the heck, out of an abundance of overconfidence, I'll send a v3 and
people can look at that...
Look for one shortly.
-- Tim
P.S. I removed the 'To:' for Salvatore Benedetto since I was getting bounces.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-06-04 17:05 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-04 0:41 [PATCH v2] Bluetooth: Add SPDX id lines to some source files Tim Bird
2026-06-04 5:48 ` [v2] " bluez.test.bot
2026-06-04 11:32 ` [PATCH v2] " Bastien Nocera
2026-06-04 15:16 ` Luiz Augusto von Dentz
2026-06-04 16:38 ` Bird, Tim
2026-06-04 15:28 ` Luiz Augusto von Dentz
2026-06-04 16:41 ` Bird, Tim
2026-06-04 16:53 ` Luiz Augusto von Dentz
2026-06-04 17:03 ` Bird, Tim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox