[PATCH BlueZ v2] profiles/ranging: Read measured_freq_offset field-16 bit as per Core Spec

[PATCH BlueZ v2] profiles/ranging: Read measured_freq_offset field-16 bit as per Core Spec

[Prathibha Madugonde]

From: Prathibha Madugonde <prathibha.madugonde@oss.qualcomm.com>

Fix in V2:
Fixed compilation issue.

---
 profiles/ranging/rap_hci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/profiles/ranging/rap_hci.c b/profiles/ranging/rap_hci.c
index 8e65e5ef8..febe23384 100644
--- a/profiles/ranging/rap_hci.c
+++ b/profiles/ranging/rap_hci.c
@@ -601,7 +601,7 @@ static void parse_mode_zero_data(struct iovec *iov,
 				 struct cs_mode_zero_data *mode_data,
 				 uint8_t cs_role)
 {
-	uint32_t freq_offset;
+	uint16_t freq_offset;
 
 	if (iov->iov_len < 3) {
 		DBG("Mode 0: too short (<3)");
@@ -614,7 +614,7 @@ static void parse_mode_zero_data(struct iovec *iov,
 	DBG("CS Step mode 0");
 
 	if (cs_role == CS_INITIATOR && iov->iov_len >= 4) {
-		util_iov_pull_le32(iov, &freq_offset);
+		util_iov_pull_le16(iov, &freq_offset);
 		mode_data->init_measured_freq_offset = freq_offset;
 	}
 }
-- 
2.34.1

Re: [PATCH BlueZ v2] profiles/ranging: Read measured_freq_offset field-16 bit as per Core Spec

[Bastien Nocera]

On Thu, 2026-06-04 at 15:32 +0530, Prathibha Madugonde wrote:
> From: Prathibha Madugonde <prathibha.madugonde@oss.qualcomm.com>

Could you please add a reference in the commit message to the part of
the Core spec that's relevant?

> 
> Fix in V2:
> Fixed compilation issue.

This should appear under the "---", so that it doesn't get into the
commit message itself when the patch gets applied.

> ---
>  profiles/ranging/rap_hci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/profiles/ranging/rap_hci.c b/profiles/ranging/rap_hci.c
> index 8e65e5ef8..febe23384 100644
> --- a/profiles/ranging/rap_hci.c
> +++ b/profiles/ranging/rap_hci.c
> @@ -601,7 +601,7 @@ static void parse_mode_zero_data(struct iovec
> *iov,
>  				 struct cs_mode_zero_data
> *mode_data,
>  				 uint8_t cs_role)
>  {
> -	uint32_t freq_offset;
> +	uint16_t freq_offset;
>  
>  	if (iov->iov_len < 3) {
>  		DBG("Mode 0: too short (<3)");
> @@ -614,7 +614,7 @@ static void parse_mode_zero_data(struct iovec
> *iov,
>  	DBG("CS Step mode 0");
>  
>  	if (cs_role == CS_INITIATOR && iov->iov_len >= 4) {
> -		util_iov_pull_le32(iov, &freq_offset);
> +		util_iov_pull_le16(iov, &freq_offset);
>  		mode_data->init_measured_freq_offset = freq_offset;
>  	}
>  }

RE: [BlueZ,v2] profiles/ranging: Read measured_freq_offset field-16 bit as per Core Spec

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1105853

---Test result---

Test Summary:
CheckPatch                    PASS      0.39 seconds
GitLint                       FAIL      0.28 seconds
BuildEll                      PASS      15.92 seconds
BluezMake                     PASS      493.79 seconds
CheckSmatch                   PASS      252.60 seconds
bluezmakeextell               PASS      128.51 seconds
IncrementalBuild              PASS      486.66 seconds
ScanBuild                     PASS      713.49 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,v2] profiles/ranging: Read measured_freq_offset field-16 bit as per Core Spec

1: T1 Title exceeds max length (84>80): "[BlueZ,v2] profiles/ranging: Read measured_freq_offset field-16 bit as per Core Spec"


https://github.com/bluez/bluez/pull/2178

---
Regards,
Linux Bluetooth

Re: [BlueZ,v2] profiles/ranging: Read measured_freq_offset field-16 bit as per Core Spec

[Bastien Nocera]

On Thu, 2026-06-04 at 05:00 -0700, bluez.test.bot@gmail.com wrote:
> This is automated email and please do not reply to this email!
> 
> Dear submitter,
> 
> Thank you for submitting the patches to the linux bluetooth mailing
> list.
> This is a CI test results with your patch series:
> PW
> Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1105
> 853
> 
> ---Test result---
> 
> Test Summary:
> CheckPatch                    PASS      0.39 seconds
> GitLint                       FAIL      0.28 seconds
> BuildEll                      PASS      15.92 seconds
> BluezMake                     PASS      493.79 seconds
> CheckSmatch                   PASS      252.60 seconds
> bluezmakeextell               PASS      128.51 seconds
> IncrementalBuild              PASS      486.66 seconds
> ScanBuild                     PASS      713.49 seconds
> 
> Details
> ##############################
> Test: GitLint - FAIL
> Desc: Run gitlint
> Output:
> [BlueZ,v2] profiles/ranging: Read measured_freq_offset field-16 bit
> as per Core Spec
> 
> 1: T1 Title exceeds max length (84>80): "[BlueZ,v2] profiles/ranging:
> Read measured_freq_offset field-16 bit as per Core Spec"

I think that this gitlint error is wrong, and filed:
https://github.com/jorisroovers/gitlint/issues/566

Cheers

> 
> 
> https://github.com/bluez/bluez/pull/2178
> 
> ---
> Regards,
> Linux Bluetooth

Re: [PATCH BlueZ v2] profiles/ranging: Read measured_freq_offset field-16 bit as per Core Spec

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu,  4 Jun 2026 15:32:33 +0530 you wrote:
> From: Prathibha Madugonde <prathibha.madugonde@oss.qualcomm.com>
> 
> Fix in V2:
> Fixed compilation issue.
> 
> ---
>  profiles/ranging/rap_hci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
  - [BlueZ,v2] profiles/ranging: Read measured_freq_offset field-16 bit as per Core Spec
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=42b2c543a70c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html